[GitHub] [fineract] avikganguly01 commented on a change in pull request #1883: FINERACT-982 - Completely ditch use of Drizzle JDBC Driver after all

[GitBox <gi...@apache.org>]

avikganguly01 commented on a change in pull request #1883:
URL: https://github.com/apache/fineract/pull/1883#discussion_r726003492



##########
File path: build.gradle
##########
@@ -115,7 +115,7 @@ allprojects  {
             dependency 'com.google.truth.extensions:truth-java8-extension:1.1.3'
             dependency 'org.apache.commons:commons-email:1.5'
             dependency 'commons-io:commons-io:2.11.0'
-            dependency 'org.drizzle.jdbc:drizzle-jdbc:1.4'
+            dependency 'org.mariadb.jdbc:mariadb-java-client:2.7.3'
             dependency 'com.github.librepdf:openpdf:1.3.26'

Review comment:
       @IOhacker @ptuomola : In terms of bundling it as a dependency as an optional build time flag instead of putting it in the release JAR, there is a complication : -
   There are places in the code where return type casting is based on Drizzle (search Drizzle in codebase). There is no consistency between JDBC drivers when it comes to some return types so this needs some work in those source files as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org