Re: [PR] [SPARK-58392][SQL] Pass all options while loading relations [spark]

["yyanyy (via GitHub)" <gi...@apache.org>]

yyanyy commented on code in PR #57585:
URL: https://github.com/apache/spark/pull/57585#discussion_r3724246261


##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/RelationCatalog.java:
##########
@@ -134,6 +135,26 @@ public interface RelationCatalog extends TableCatalog, ViewCatalog {
    */
   Relation loadRelation(Identifier ident) throws NoSuchTableException;
 
+  /**
+   * Load the relation for an identifier that may resolve to either a table or a view, forwarding
+   * all user-specified options.
+   * <p>
+   * Behaves like {@link #loadRelation(Identifier)} but also receives the options passed to the
+   * read, so a catalog can take them into account when producing the {@link Table} or
+   * {@link View}. The default implementation ignores {@code options} and delegates to
+   * {@link #loadRelation(Identifier)}; override it to make use of the options.
+   *
+   * @param ident the identifier
+   * @param options all options passed to the read
+   * @return a {@link Table} for tables, or a {@link View} for views
+   * @throws NoSuchTableException if neither a table nor a view exists at {@code ident}
+   * @since 4.2.0

Review Comment:
   fixed, thanks for the review!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org