You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/08/19 01:45:19 UTC

[GitHub] [samza] mynameborat commented on pull request #1418: SAMZA-2583: Fix NPE in update SamzaHistogram Gauge values

mynameborat commented on pull request #1418:
URL: https://github.com/apache/samza/pull/1418#issuecomment-675803613


   > > @vishwajith-s Can you please add a unit test for this issue so that you fix doesn't get refactored away. Thanks for the quick fix!
   > 
   > Had to add implement MockMetricRegistry class instead of using Mockito framework as we had to ensure getValue is being called as part of newGauge creation.
   
   Would stubbing the call to mockMetricsRegistry and respond with an answer that invokes `value.getValue()` work? You can use the invocationContext to get the actual arguments.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org