You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/24 23:47:04 UTC

[jira] [Commented] (SAMZA-1233) Fix SamzaTaskProxy system admin instantiation

    [ https://issues.apache.org/jira/browse/SAMZA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982129#comment-15982129 ] 

ASF GitHub Bot commented on SAMZA-1233:
---------------------------------------

GitHub user shanthoosh opened a pull request:

    https://github.com/apache/samza/pull/138

    SAMZA-1233: Create SystemAdmin only for JobCoordinator System in SamzaTaskProxy

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shanthoosh/samza fix_samza_task_proxy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #138
    
----
commit 4f4b1ebab4123c1275fd1893125997028781a536
Author: Shanthoosh Venkataraman <sv...@linkedin.com>
Date:   2017-04-24T22:46:57Z

    SAMZA-1233: Create SystemAdmin only for JobCoordinator System in SamzaTaskProxy.

----


> Fix SamzaTaskProxy system admin instantiation
> ---------------------------------------------
>
>                 Key: SAMZA-1233
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1233
>             Project: Samza
>          Issue Type: Task
>            Reporter: Shanthoosh Venkataraman
>            Assignee: Shanthoosh Venkataraman
>            Priority: Minor
>
> SamzaTaskProxy instantiates all SystemAdmin classes defined in 
> job configuration. 
> This is unnecessary and sometimes leads to ClassNotFoundException when  different SystemAdmin(HdfsSystemAdmin, ElasticSearchAdmin) classes are not available in classpath during samza-rest deployment and introduces library dependency from all system modules (samza-kakfa, samza-hdfs etc)directly into samza-rest. 
> To solve this problem, instantiate SystemAdmin for job coordinator alone in SamzaTaskProxy. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)