[GitHub] [airflow] mik-laj commented on pull request #13440: Additional properties should be allowed in provider schema

[GitBox <gi...@apache.org>]

mik-laj commented on pull request #13440:
URL: https://github.com/apache/airflow/pull/13440#issuecomment-753879145


   > I am using jsonpath-ng for that - very neat library that implements jsonpath and we can easily specify the path to filter out from Dictionary object (in case of logo simply integrations..logo does the trick
   
   This can cause some problems. Although it is a devel dependency, these dependencies appear in the constraints.txt file, which may make installing a new version of this library difficult in the future.  Google has a slightly different policy on adding dependencies to their libraries, which seems sensible to apply to our project as well, as in some cases this is how our project should be treated.
   
   > The feature must not add unnecessary dependencies (where "unnecessary" is of course subjective, but new dependencies should be discussed).
   
   https://github.com/googleapis/python-bigquery/blob/master/CONTRIBUTING.rst
   
   Another example is the `beautifulsoup4` library, which even has version requirements in `setup.py`
   https://github.com/apache/airflow/blob/4437137effd2bedc3f9c23391d06316480aa3727/setup.py#L451
   As a result, the user may have to use a version that was released 1 year, 11 months ago - 4.7.1.
   https://github.com/apache/airflow/blob/38fbcadf2f443d5bf17e0813f629b39f5627d13e/constraints-3.8.txt#L80
   Latest version is 4.9.3 (3 months ago)
   
   However, we can address this issue when we get a report about it. I just wanted to warn you against adding development dependencies if it's not necessary.
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org