You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andy Pang <pa...@huawei.com> on 2017/08/22 01:56:36 UTC
Review Request 61808: Add task env overwriting executor env glog print
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61808/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Jie Yu.
Repository: mesos
Description
-------
When user assign environment by `CommandInfo` environment, it will overwrite the same name environment get by before.
Diffs
-----
src/slave/containerizer/docker.cpp b84c392
Diff: https://reviews.apache.org/r/61808/diff/1/
Testing
-------
make check
Thanks,
Andy Pang
Re: Review Request 61808: Add task env overwriting executor env glog
print
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61808/#review183431
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61808]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 21, 2017, 6:56 p.m., Andy Pang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61808/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 6:56 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When user assign environment by `CommandInfo` environment, it will overwrite the same name environment get by before.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp b84c392
>
>
> Diff: https://reviews.apache.org/r/61808/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andy Pang
>
>
Re: Review Request 61808: Add task env overwriting executor env glog
print
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61808/#review183701
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 22, 2017, 1:56 a.m., Andy Pang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61808/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 1:56 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When user assign environment by `CommandInfo` environment, it will overwrite the same name environment get by before.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp b84c392
>
>
> Diff: https://reviews.apache.org/r/61808/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andy Pang
>
>