You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2013/04/23 23:49:22 UTC
Review Request: Merging changes to marvin after ipclearance from
cloudstack-qa
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10741/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Description
-------
Merging changes to marvin after ipclearance from cloudstack-qa
- Base classes for Router, Tag, PrivateGateway and StaticRoute etc.
- VPC support for existing base classes
- Read hypervisor config from setting file
- Support for keypair authentication in remoteSSHClient
Diffs
-----
tools/marvin/marvin/asyncJobMgr.py 40304fa
tools/marvin/marvin/cloudstackConnection.py 214a878
tools/marvin/marvin/cloudstackTestClient.py 85552ed
tools/marvin/marvin/dbConnection.py 8fa8643
tools/marvin/marvin/deployDataCenter.py d358789
tools/marvin/marvin/integration/lib/base.py 92cdf81
tools/marvin/marvin/integration/lib/utils.py cff24a1
tools/marvin/marvin/remoteSSHClient.py 4fb2f0d
Diff: https://reviews.apache.org/r/10741/diff/
Testing
-------
Thanks,
Ashutosh Kelkar
Re: Review Request: Merging changes to marvin after ipclearance from
cloudstack-qa
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10741/#review19618
-----------------------------------------------------------
tools/marvin/marvin/integration/lib/base.py
<https://reviews.apache.org/r/10741/#comment40530>
in the absence of serviceofferingid,
cmd.serviceofferingid = services["serviceoffering"] might not be correct as we need to create a service offering and pass on its id
tools/marvin/marvin/integration/lib/base.py
<https://reviews.apache.org/r/10741/#comment40529>
I am wondering what happens in the absence of diskofferingid?
cmd.diskofferingid = services["diskoffering"] will not be correct diskofferingid assignment.
- SrikanteswaraRao Talluri
On April 23, 2013, 9:49 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10741/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 9:49 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> Merging changes to marvin after ipclearance from cloudstack-qa
>
> - Base classes for Router, Tag, PrivateGateway and StaticRoute etc.
> - VPC support for existing base classes
> - Read hypervisor config from setting file
> - Support for keypair authentication in remoteSSHClient
>
>
> Diffs
> -----
>
> tools/marvin/marvin/asyncJobMgr.py 40304fa
> tools/marvin/marvin/cloudstackConnection.py 214a878
> tools/marvin/marvin/cloudstackTestClient.py 85552ed
> tools/marvin/marvin/dbConnection.py 8fa8643
> tools/marvin/marvin/deployDataCenter.py d358789
> tools/marvin/marvin/integration/lib/base.py 92cdf81
> tools/marvin/marvin/integration/lib/utils.py cff24a1
> tools/marvin/marvin/remoteSSHClient.py 4fb2f0d
>
> Diff: https://reviews.apache.org/r/10741/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request: Merging changes to marvin after ipclearance from
cloudstack-qa
Posted by Prasanna Santhanam <ts...@apache.org>.
Sorry - failed to push this last night.
Here's the actual commit:
commit 2f40a90c53067c3901cf9e5c9a33309907e48aab
Author: Ashutosh Kelkar <as...@clogeny.com>
Date: Wed Apr 24 15:03:10 2013 +0530
Multiple fixes to marvin framework
1. adding hypervisor information to configs
TODO: support for multi-hypervisor zones?
2. CLOUDSTACK-601: Marvin unicode decode errors when running mysql
queries via dbClient
3. adding keypair support for remotessh client
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
On Wed, Apr 24, 2013 at 03:51:16PM -0000, Prasanna Santhanam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10741/#review19624
> -----------------------------------------------------------
>
> Ship it!
>
>
> Applied but edited the log message to reflect the nature of fixes.
>
> commit a1ef9d7312c2de037e09718abf367af774cc288a
> Author: Ashutosh Kelkar <as...@clogeny.com>
> Date: Wed Apr 24 15:03:10 2013 +0530
>
> Multiple fixes to marvin framework
>
> 1. adding hypervisor information to configs
> TODO: support for multi-hypervisor zones?
> 2. CLOUDSTACK-601: Marvin unicode decode errors when running mysql
> queries via dbClient
> 3. adding keypair support for remotessh client
>
> Signed-off-by: Prasanna Santhanam <ts...@apache.org>
>
>
> - Prasanna Santhanam
>
>
> On April 23, 2013, 9:49 p.m., Ashutosh Kelkar wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/10741/
> > -----------------------------------------------------------
> >
> > (Updated April 23, 2013, 9:49 p.m.)
> >
> >
> > Review request for cloudstack and Prasanna Santhanam.
> >
> >
> > Description
> > -------
> >
> > Merging changes to marvin after ipclearance from cloudstack-qa
> >
> > - Base classes for Router, Tag, PrivateGateway and StaticRoute etc.
> > - VPC support for existing base classes
> > - Read hypervisor config from setting file
> > - Support for keypair authentication in remoteSSHClient
> >
> >
> > Diffs
> > -----
> >
> > tools/marvin/marvin/asyncJobMgr.py 40304fa
> > tools/marvin/marvin/cloudstackConnection.py 214a878
> > tools/marvin/marvin/cloudstackTestClient.py 85552ed
> > tools/marvin/marvin/dbConnection.py 8fa8643
> > tools/marvin/marvin/deployDataCenter.py d358789
> > tools/marvin/marvin/integration/lib/base.py 92cdf81
> > tools/marvin/marvin/integration/lib/utils.py cff24a1
> > tools/marvin/marvin/remoteSSHClient.py 4fb2f0d
> >
> > Diff: https://reviews.apache.org/r/10741/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Ashutosh Kelkar
> >
> >
>
--
Prasanna.,
------------------------
Powered by BigRock.com
Re: Potential problem with IP ownership of a commit. WAS: Re: Review
Request: Merging changes to marvin after ipclearance from cloudstack-qa
Posted by Chip Childers <ch...@sungard.com>.
On Thu, Apr 25, 2013 at 10:25:12PM +0530, Prasanna Santhanam wrote:
> Not quite : I emailed Ashutosh about the controversial subject earlier
> today. We marked off 'ipclearance' as a point-in-time. This was when
> (January?) the tests were contributed to ASF and went into some legal
> issues. It is the point-in-time that is referred to in the request not
> the code itself. This code is post-ipclearance changes made to the
> framework and sent as a patch.
Thanks for clarifying!
No objection then.
Re: Potential problem with IP ownership of a commit. WAS: Re: Review
Request: Merging changes to marvin after ipclearance from cloudstack-qa
Posted by Prasanna Santhanam <ts...@apache.org>.
Not quite : I emailed Ashutosh about the controversial subject earlier
today. We marked off 'ipclearance' as a point-in-time. This was when
(January?) the tests were contributed to ASF and went into some legal
issues. It is the point-in-time that is referred to in the request not
the code itself. This code is post-ipclearance changes made to the
framework and sent as a patch.
On Thu, Apr 25, 2013 at 12:33:07PM -0400, Chip Childers wrote:
>
> Did we actually process IP Clearance for these? The summary of the
> review board record implies that we did.
>
> I do *not* see it listed on the official IP Clearance page [1]. Is this
> the code that was under discussion to be granted by Citrix to ASF (but
> was developed by Clogeny)? AFAIK, this was still pending CTXS signing a
> new grant. If that grant *was* signed, I still have to take it through
> the IP clearance process before the code is submitted.
>
> I'll give this 24 hours, and then revert the commit if I don't hear back
> from anyone as to the legal status of this patch.
>
> -chip
>
> [1] http://incubator.apache.org/ip-clearance/index.html
>
>
> On Wed, Apr 24, 2013 at 03:51:16PM +0000, Prasanna Santhanam wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/10741/#review19624
> > -----------------------------------------------------------
> >
> > Ship it!
> >
> >
> > Applied but edited the log message to reflect the nature of fixes.
> >
> > commit a1ef9d7312c2de037e09718abf367af774cc288a
> > Author: Ashutosh Kelkar <as...@clogeny.com>
> > Date: Wed Apr 24 15:03:10 2013 +0530
> >
> > Multiple fixes to marvin framework
> >
> > 1. adding hypervisor information to configs
> > TODO: support for multi-hypervisor zones?
> > 2. CLOUDSTACK-601: Marvin unicode decode errors when running mysql
> > queries via dbClient
> > 3. adding keypair support for remotessh client
> >
> > Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> >
> >
> > - Prasanna Santhanam
> >
> >
> > On April 23, 2013, 9:49 p.m., Ashutosh Kelkar wrote:
> > >
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/10741/
> > > -----------------------------------------------------------
> > >
> > > (Updated April 23, 2013, 9:49 p.m.)
> > >
> > >
> > > Review request for cloudstack and Prasanna Santhanam.
> > >
> > >
> > > Description
> > > -------
> > >
> > > Merging changes to marvin after ipclearance from cloudstack-qa
> > >
> > > - Base classes for Router, Tag, PrivateGateway and StaticRoute etc.
> > > - VPC support for existing base classes
> > > - Read hypervisor config from setting file
> > > - Support for keypair authentication in remoteSSHClient
> > >
> > >
> > > Diffs
> > > -----
> > >
> > > tools/marvin/marvin/asyncJobMgr.py 40304fa
> > > tools/marvin/marvin/cloudstackConnection.py 214a878
> > > tools/marvin/marvin/cloudstackTestClient.py 85552ed
> > > tools/marvin/marvin/dbConnection.py 8fa8643
> > > tools/marvin/marvin/deployDataCenter.py d358789
> > > tools/marvin/marvin/integration/lib/base.py 92cdf81
> > > tools/marvin/marvin/integration/lib/utils.py cff24a1
> > > tools/marvin/marvin/remoteSSHClient.py 4fb2f0d
> > >
> > > Diff: https://reviews.apache.org/r/10741/diff/
> > >
> > >
> > > Testing
> > > -------
> > >
> > >
> > > Thanks,
> > >
> > > Ashutosh Kelkar
> > >
> > >
> >
--
Prasanna.,
------------------------
Powered by BigRock.com
Potential problem with IP ownership of a commit. WAS: Re: Review
Request: Merging changes to marvin after ipclearance from cloudstack-qa
Posted by Chip Childers <ch...@sungard.com>.
Did we actually process IP Clearance for these? The summary of the
review board record implies that we did.
I do *not* see it listed on the official IP Clearance page [1]. Is this
the code that was under discussion to be granted by Citrix to ASF (but
was developed by Clogeny)? AFAIK, this was still pending CTXS signing a
new grant. If that grant *was* signed, I still have to take it through
the IP clearance process before the code is submitted.
I'll give this 24 hours, and then revert the commit if I don't hear back
from anyone as to the legal status of this patch.
-chip
[1] http://incubator.apache.org/ip-clearance/index.html
On Wed, Apr 24, 2013 at 03:51:16PM +0000, Prasanna Santhanam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10741/#review19624
> -----------------------------------------------------------
>
> Ship it!
>
>
> Applied but edited the log message to reflect the nature of fixes.
>
> commit a1ef9d7312c2de037e09718abf367af774cc288a
> Author: Ashutosh Kelkar <as...@clogeny.com>
> Date: Wed Apr 24 15:03:10 2013 +0530
>
> Multiple fixes to marvin framework
>
> 1. adding hypervisor information to configs
> TODO: support for multi-hypervisor zones?
> 2. CLOUDSTACK-601: Marvin unicode decode errors when running mysql
> queries via dbClient
> 3. adding keypair support for remotessh client
>
> Signed-off-by: Prasanna Santhanam <ts...@apache.org>
>
>
> - Prasanna Santhanam
>
>
> On April 23, 2013, 9:49 p.m., Ashutosh Kelkar wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/10741/
> > -----------------------------------------------------------
> >
> > (Updated April 23, 2013, 9:49 p.m.)
> >
> >
> > Review request for cloudstack and Prasanna Santhanam.
> >
> >
> > Description
> > -------
> >
> > Merging changes to marvin after ipclearance from cloudstack-qa
> >
> > - Base classes for Router, Tag, PrivateGateway and StaticRoute etc.
> > - VPC support for existing base classes
> > - Read hypervisor config from setting file
> > - Support for keypair authentication in remoteSSHClient
> >
> >
> > Diffs
> > -----
> >
> > tools/marvin/marvin/asyncJobMgr.py 40304fa
> > tools/marvin/marvin/cloudstackConnection.py 214a878
> > tools/marvin/marvin/cloudstackTestClient.py 85552ed
> > tools/marvin/marvin/dbConnection.py 8fa8643
> > tools/marvin/marvin/deployDataCenter.py d358789
> > tools/marvin/marvin/integration/lib/base.py 92cdf81
> > tools/marvin/marvin/integration/lib/utils.py cff24a1
> > tools/marvin/marvin/remoteSSHClient.py 4fb2f0d
> >
> > Diff: https://reviews.apache.org/r/10741/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Ashutosh Kelkar
> >
> >
>
Re: Review Request: Merging changes to marvin after ipclearance from
cloudstack-qa
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10741/#review19624
-----------------------------------------------------------
Ship it!
Applied but edited the log message to reflect the nature of fixes.
commit a1ef9d7312c2de037e09718abf367af774cc288a
Author: Ashutosh Kelkar <as...@clogeny.com>
Date: Wed Apr 24 15:03:10 2013 +0530
Multiple fixes to marvin framework
1. adding hypervisor information to configs
TODO: support for multi-hypervisor zones?
2. CLOUDSTACK-601: Marvin unicode decode errors when running mysql
queries via dbClient
3. adding keypair support for remotessh client
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- Prasanna Santhanam
On April 23, 2013, 9:49 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10741/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 9:49 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> Merging changes to marvin after ipclearance from cloudstack-qa
>
> - Base classes for Router, Tag, PrivateGateway and StaticRoute etc.
> - VPC support for existing base classes
> - Read hypervisor config from setting file
> - Support for keypair authentication in remoteSSHClient
>
>
> Diffs
> -----
>
> tools/marvin/marvin/asyncJobMgr.py 40304fa
> tools/marvin/marvin/cloudstackConnection.py 214a878
> tools/marvin/marvin/cloudstackTestClient.py 85552ed
> tools/marvin/marvin/dbConnection.py 8fa8643
> tools/marvin/marvin/deployDataCenter.py d358789
> tools/marvin/marvin/integration/lib/base.py 92cdf81
> tools/marvin/marvin/integration/lib/utils.py cff24a1
> tools/marvin/marvin/remoteSSHClient.py 4fb2f0d
>
> Diff: https://reviews.apache.org/r/10741/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>