You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/03/31 00:34:58 UTC

[kudu-CR] Add internal IS NOT NULL predicate type

Hello Jean-Daniel Cryans, Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2671

to review the following change.

Change subject: Add internal IS NOT NULL predicate type
......................................................................

Add internal IS NOT NULL predicate type

This commit adds an internal IS NOT NULL predicate type, and changes LESS_EQUAL
predicate simplification to result in the IS NOT NULL predicate type when converting
to a LESS predicate fails, and the column is nullable. This fixes scans with
predicates such as 'WHERE my_nullable_int8_col <= 127`. A followup commit will
contain comprehensive predicate tests covering this case.

Change-Id: Ifcf29b1f274df2ef5c5ac7a7a17cc06dfd59e191
---
M src/kudu/client/scan_predicate.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
M src/kudu/common/common.proto
M src/kudu/tserver/tablet_service.cc
7 files changed, 98 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/2671/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcf29b1f274df2ef5c5ac7a7a17cc06dfd59e191
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>