[GitHub] [beam] kennknowles commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java

[GitBox <gi...@apache.org>]

kennknowles commented on a change in pull request #11243:
URL: https://github.com/apache/beam/pull/11243#discussion_r450467677



##########
File path: sdks/java/container/build.gradle
##########
@@ -68,6 +73,28 @@ golang {
   }
 }
 
+// this is a workaround to call generateLicenseReport task from project root directory.
+// generateLicenseReport does not return correct dependency list when not called from the root.
+task generateThirdPartyLicenses(type: Exec) {
+  workingDir project.rootProject.projectDir
+  commandLine './sdks/java/container/license_scripts/license_script.sh'
+}
+
+//command: ./gradlew generateLicenseReport
+import com.github.jk1.license.render.*
+licenseReport {
+  outputDir = 'java_third_party_licenses'
+  projects = [project.rootProject] + project.rootProject.subprojects
+  excludeOwnGroup = true
+  configurations = ALL

Review comment:
       Why ALL? Should this just be `runtime`?
   
   This pulls in lots of configurations that only are used to run static analysis at build time, etc, and do not affect the license of the container.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org