[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #3036: ARTEMIS-2669 Improve AMQPStandardMessage::reencode on depaging not durable messages

[GitBox <gi...@apache.org>]

franz1981 commented on a change in pull request #3036: ARTEMIS-2669 Improve AMQPStandardMessage::reencode on depaging not durable messages
URL: https://github.com/apache/activemq-artemis/pull/3036#discussion_r395674138
 
 

 ##########
 File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
 ##########
 @@ -837,16 +837,26 @@ protected synchronized void lazyScanAfterReloadPersistence() {
       messageDataScanned = MessageDataScanningStatus.SCANNED.code;
       modified = false;
 
+      makeDurable();
+   }
+
+   private void makeDurable() {
+      assert messageDataScanned == MessageDataScanningStatus.SCANNED.code;
       // Message state should reflect that is came from persistent storage which
       // can happen when moved to a durable location.  We must re-encode here to
       // avoid a subsequent redelivery from suddenly appearing with a durable header
       // tag when the initial delivery did not.
       if (!isDurable()) {
 
 Review comment:
   It would be the best possible scenario: just don't know if we have test coverage to be sure that it won't break anything...still need to investigate why we have this..idea?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services