You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Gordon Sim (JIRA)" <ji...@apache.org> on 2014/12/15 17:43:13 UTC
[jira] [Commented] (QPID-6271) [AMQP 1.0] receivers never removed
from sessions list
[ https://issues.apache.org/jira/browse/QPID-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246816#comment-14246816 ]
Gordon Sim commented on QPID-6271:
----------------------------------
Suggested fix (I'm assuming detach() may want to hold onto the receiver):
{noformat}
diff --git a/qpid/java/amqp-1-0-client/src/main/java/org/apache/qpid/amqp_1_0/client/Receiver.java b/qpid/java/amqp-1-0-client/src/main/java/org/apache/qpid/amqp_1_0/client/Receiver.java
index 826a757..1d9ec0f 100644
--- a/qpid/java/amqp-1-0-client/src/main/java/org/apache/qpid/amqp_1_0/client/Receiver.java
+++ b/qpid/java/amqp-1-0-client/src/main/java/org/apache/qpid/amqp_1_0/client/Receiver.java
@@ -530,6 +530,7 @@ public class Receiver implements DeliveryStateHandler
{
release(msg);
}
+ _session.removeReceiver(this);
}
{noformat}
> [AMQP 1.0] receivers never removed from sessions list
> -----------------------------------------------------
>
> Key: QPID-6271
> URL: https://issues.apache.org/jira/browse/QPID-6271
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.30
> Reporter: Gordon Sim
>
> The amqp-1.0-client Session records every created Receiver in its private _receivers list. There is a package visible removeReceiver() method, but I can't find any use of that.
> So even when a receiver is closed, it remains in the sessions list. I came across this while investigating an apparent leak with a jms QueueBrowser, but just from inspection it looks slightly wider in applicability.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org