You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/06/03 19:11:47 UTC
Re: Review Request 32356: Refactor synchronized to use mutex,
recursive_mutex, atomic_flag.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32356/
-----------------------------------------------------------
(Updated June 3, 2015, 5:11 p.m.)
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Bugs: MESOS-2805
https://issues.apache.org/jira/browse/MESOS-2805
Repository: mesos
Description
-------
The synchronized(m) macro now supports passing any of the following by pointer or reference:
1. `std::mutex`
2. `std::recursive_mutex`
3. `std::atomic_flag`
You no longer need to initialize your synchronization primitives using `Synchronizable` and `SYNCHRONIZED_INITIALIZER`.
Remember to initialize `std::atomic_flag` with `ATOMIC_FLAG_INIT`.
Diffs (updated)
-----
3rdparty/libprocess/src/clock.cpp bff53107b07483d055d4c89e3085b0225f4ccb9d
3rdparty/libprocess/src/libev.hpp e4a403d9e769c13182f26034e0dd1c4db92b04cb
3rdparty/libprocess/src/libev.cpp 610dfb896ed8f9c00f9cf8fc8dbfc7d434f7d1e5
3rdparty/libprocess/src/process.cpp 4a5ab7924ab3e6782f958f2a2b8cd12f3b5a2d08
3rdparty/libprocess/src/synchronized.hpp 6a341b851d516bcecb2f893fbb5d08a769b09b3a
Diff: https://reviews.apache.org/r/32356/diff/
Testing
-------
make check
Thanks,
Joris Van Remoortere
Re: Review Request 32356: Refactor synchronized to use mutex,
recursive_mutex, atomic_flag.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32356/#review86564
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On June 3, 2015, 5:11 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32356/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 5:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Bugs: MESOS-2805
> https://issues.apache.org/jira/browse/MESOS-2805
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The synchronized(m) macro now supports passing any of the following by pointer or reference:
> 1. `std::mutex`
> 2. `std::recursive_mutex`
> 3. `std::atomic_flag`
> You no longer need to initialize your synchronization primitives using `Synchronizable` and `SYNCHRONIZED_INITIALIZER`.
> Remember to initialize `std::atomic_flag` with `ATOMIC_FLAG_INIT`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/clock.cpp bff53107b07483d055d4c89e3085b0225f4ccb9d
> 3rdparty/libprocess/src/libev.hpp e4a403d9e769c13182f26034e0dd1c4db92b04cb
> 3rdparty/libprocess/src/libev.cpp 610dfb896ed8f9c00f9cf8fc8dbfc7d434f7d1e5
> 3rdparty/libprocess/src/process.cpp 4a5ab7924ab3e6782f958f2a2b8cd12f3b5a2d08
> 3rdparty/libprocess/src/synchronized.hpp 6a341b851d516bcecb2f893fbb5d08a769b09b3a
>
> Diff: https://reviews.apache.org/r/32356/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>