You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/09/03 01:53:10 UTC
[GitHub] [incubator-dolphinscheduler] codecov-commenter commented on pull request #3605: [Test][API] full cover DataAnalysisServiceImpl
codecov-commenter commented on pull request #3605:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3605#issuecomment-686184495
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3605?src=pr&el=h1) Report
> Merging [#3605](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3605?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/ac4ed94061e91563268c3bc588c554182d22d277?el=desc) will **increase** coverage by `0.21%`.
> The diff coverage is `82.14%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3605?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #3605 +/- ##
============================================
+ Coverage 39.16% 39.37% +0.21%
- Complexity 2831 2861 +30
============================================
Files 456 456
Lines 21629 21604 -25
Branches 2623 2625 +2
============================================
+ Hits 8470 8506 +36
+ Misses 12371 12311 -60
+ Partials 788 787 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3605?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/dolphinscheduler/api/dto/TaskCountDto.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3605/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by9UYXNrQ291bnREdG8uamF2YQ==) | `57.35% <50.00%> (+2.66%)` | `5.00 <0.00> (+2.00)` | |
| [...he/dolphinscheduler/api/dto/CommandStateCount.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3605/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by9Db21tYW5kU3RhdGVDb3VudC5qYXZh) | `79.31% <64.28%> (+45.97%)` | `12.00 <5.00> (+11.00)` | |
| [...pache/dolphinscheduler/api/dto/TaskStateCount.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3605/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by9UYXNrU3RhdGVDb3VudC5qYXZh) | `61.90% <72.72%> (+21.90%)` | `7.00 <5.00> (+6.00)` | |
| [...uler/api/service/impl/DataAnalysisServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3605/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9EYXRhQW5hbHlzaXNTZXJ2aWNlSW1wbC5qYXZh) | `100.00% <100.00%> (+42.65%)` | `29.00 <1.00> (+13.00)` | |
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3605/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | `3.00% <0.00%> (-1.00%)` | |
| [...inscheduler/service/zk/CuratorZookeeperClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3605/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQ3VyYXRvclpvb2tlZXBlckNsaWVudC5qYXZh) | `56.75% <0.00%> (-2.71%)` | `6.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3605?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3605?src=pr&el=footer). Last update [ac4ed94...14410c6](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org