[GitHub] [maven] Tibor17 commented on pull request #526: [MNG-7129] Incremental build and shared cache feature

[GitBox <gi...@apache.org>]

Tibor17 commented on pull request #526:
URL: https://github.com/apache/maven/pull/526#issuecomment-908227539


   Hi Alex,
   
   Excellent work and an elaborat.
   Unfortunately the xxHash algorithm is not in the list
   https://docs.oracle.com/javase/8/docs/technotes/guides/security/StandardNames.html
   We must guarantee that every java would support it.
   T
   
   On Wed, Aug 25, 2021 at 1:05 PM Alex ***@***.***> wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In Documentation/CACHE-HOWTO.md
   > <https://github.com/apache/maven/pull/526#discussion_r695641759>:
   >
   > > +Cache configuration provides you additional control over incremental maven behavior. Follow it step by step to
   > +understand how it works and figure out your optimal config
   > +
   > +### Minimal config
   > +
   > +Absolutely minimal config which enables incremental maven with local cache
   > +
   > +```xml
   > +<?xml version="1.0" encoding="UTF-8" ?>
   > +<cache xmlns="org:apache:maven:cache:config:v1"
   > +       xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
   > +       xsi:schemaLocation="org:apache:maven:cache:config:v1 cache-config.xsd">
   > +
   > +    <configuration>
   > +        <enabled>true</enabled>
   > +        <hashAlgorithm>XX</hashAlgorithm>
   >
   > [image: benchmark]
   > <https://camo.githubusercontent.com/35f343cf91b12df3cc73f30216e26ccda56c8983a62d0714014e0a3e07b63b35/68747470733a2f2f686162726173746f726167652e6f72672f776562742f69792f6f352f7a6a2f69796f357a6a6a36366665723179796d7176672d6163783961756d2e706e67>
   > Setup:
   >
   >    - run on Oracle JDK 1.8.0.201 on Windows and Linux
   >    - use 100 jar files with different size from 3 KB to 90 MB, total size
   >    474 MB
   >    - read in single thread, calculate hash for each file and total
   >    checksum
   >    - separate folder for each algorithm to avoid disk cache testing
   >    - 100 rounds to minimize CPU interference from external loads
   >    - time in seconds, candle body is 25-75 percentile, shadow is min/max
   >    values
   >
   > Results:
   >
   >    - xxHash shows stable time (3-4 sec) on both Windows and Linux
   >    platforms
   >    - xxHash with Memory Mapped buffer (XXMM) gives another small gain on
   >    Linux, useful on CI
   >    - SHA-256 about 4 times slower with a difference of 10 seconds even on
   >    this small test
   >
   > P.S. also tested 5157 files with total size 2.6 GB, difference between
   > xxHash and SHA-256 was about 1.5-2 min
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/maven/pull/526#discussion_r695641759>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAH7ER2RHTUYOLVYHGF46E3T6TE53ANCNFSM5CPVYJEA>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org