You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/06/07 23:29:21 UTC

[GitHub] [activemq-artemis] rtista commented on pull request #3365: ARTEMIS-1883 Improve FQQN validation

rtista commented on pull request #3365:
URL: https://github.com/apache/activemq-artemis/pull/3365#issuecomment-856326904


   > You've done some good work on this PR, @rtista. However, I think that this is ultimately a solution looking for a problem that doesn't actually exist.
   > 
   > As currently written and used throughout the code-base, the `isFullyQualified` method is meant to denote whether or not any attempt to use FQQN was made, not necessarily whether or not it is semantically valid. Therefore, input like `::foo` and `foo::` will result in `true` because they contain `::`. However, they may result in exceptions later since they are not semantically valid.
   > 
   > Given this I'm closing this PR.
   
   @jbertram Not a problem! Glad of what I've already learned however, I'll be picking other Jira Issues for fun 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org