You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Dan Harvey <da...@gmail.com> on 2015/06/05 18:03:20 UTC
Re: Review Request 33297: [SAMZA-654] Added
ElasticsearchSystemProducer and
Factory to output messages into Elasticseach indexes.
> On April 17, 2015, 9:49 p.m., Jakob Homan wrote:
> > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, line 97
> > <https://reviews.apache.org/r/33297/diff/1/?file=933092#file933092line97>
> >
> > Can we catch for invalid casts here and throw with a more verbose exception, to aid in future debugging?
I now check the type and thrown an exception if it's not supported currently.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33297/#review80538
-----------------------------------------------------------
On May 1, 2015, 6:23 p.m., Dan Harvey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33297/
> -----------------------------------------------------------
>
> (Updated May 1, 2015, 6:23 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.
>
>
> Diffs
> -----
>
> build.gradle 97de3a28f6379e3862eec845da87587b1d4f742e
> docs/learn/documentation/versioned/jobs/configuration-table.html 5ebe8a77bc3284de43268655897df33c003d56d6
> gradle/dependency-versions.gradle ee6dfc411b7ab90b187df79f109884127953862e
> samza-elasticsearch/src/main/java/org/apache/samza/config/ElasticsearchConfig.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/BulkProcessorFactory.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemAdmin.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemFactory.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/client/ClientFactory.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/client/NodeClientFactory.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/client/TransportClientFactory.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/indexrequest/DefaultIndexRequestFactory.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/indexrequest/IndexRequestFactory.java PRE-CREATION
> samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerTest.java PRE-CREATION
> samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/client/NodeClientFactoryTest.java PRE-CREATION
> samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/client/TransportClientFactoryTest.java PRE-CREATION
> samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/indexrequest/DefaultIndexRequestFactoryTest.java PRE-CREATION
> settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb
>
> Diff: https://reviews.apache.org/r/33297/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Harvey
>
>