You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ma...@apache.org on 2016/01/26 11:22:15 UTC
svn commit: r1726759 [2/3] - in /james/project/trunk:
backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/
mailbox/api/src/main/java/org/apache/james/mailbox/
mailbox/api/src/main/java/org/apache/james/mailbox/acl/ mailbox/...
Modified: james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/quota/InMemoryPerUserMaxQuotaManager.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/quota/InMemoryPerUserMaxQuotaManager.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/quota/InMemoryPerUserMaxQuotaManager.java (original)
+++ james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/quota/InMemoryPerUserMaxQuotaManager.java Tue Jan 26 10:22:12 2016
@@ -34,8 +34,8 @@ public class InMemoryPerUserMaxQuotaMana
private long maxMessage = Quota.UNLIMITED;
private long maxStorage = Quota.UNLIMITED;
- private Map<String, Long> userMaxStorage = new ConcurrentHashMap<String, Long>();
- private Map<String, Long> userMaxMessage = new ConcurrentHashMap<String, Long>();
+ private final Map<String, Long> userMaxStorage = new ConcurrentHashMap<String, Long>();
+ private final Map<String, Long> userMaxMessage = new ConcurrentHashMap<String, Long>();
@Override
public void setDefaultMaxStorage(long maxStorage) throws MailboxException {
Modified: james/project/trunk/mailbox/spring/src/main/java/org/apache/james/mailbox/spring/SpringMailbox.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/spring/src/main/java/org/apache/james/mailbox/spring/SpringMailbox.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/spring/src/main/java/org/apache/james/mailbox/spring/SpringMailbox.java (original)
+++ james/project/trunk/mailbox/spring/src/main/java/org/apache/james/mailbox/spring/SpringMailbox.java Tue Jan 26 10:22:12 2016
@@ -23,7 +23,7 @@ import org.springframework.context.suppo
public class SpringMailbox {
- private ApplicationContext applicationContext;
+ private final ApplicationContext applicationContext;
public SpringMailbox() {
applicationContext = new ClassPathXmlApplicationContext("META-INF/spring/spring-mailbox.xml",
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/GroupFolderResolver.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/GroupFolderResolver.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/GroupFolderResolver.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/GroupFolderResolver.java Tue Jan 26 10:22:12 2016
@@ -25,7 +25,7 @@ import org.apache.james.mailbox.store.ma
public class GroupFolderResolver {
- private MailboxSession mailboxSession;
+ private final MailboxSession mailboxSession;
public GroupFolderResolver(MailboxSession mailboxSession) {
this.mailboxSession = mailboxSession;
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/MessageResultImpl.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/MessageResultImpl.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/MessageResultImpl.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/MessageResultImpl.java Tue Jan 26 10:22:12 2016
@@ -374,7 +374,7 @@ public class MessageResultImpl implement
private final class HeadersImpl implements Headers {
- private Message msg;
+ private final Message msg;
private List<Header> headers;
public HeadersImpl(Message msg) {
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/SimpleMessageMetaData.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/SimpleMessageMetaData.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/SimpleMessageMetaData.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/SimpleMessageMetaData.java Tue Jan 26 10:22:12 2016
@@ -28,11 +28,11 @@ import org.apache.james.mailbox.store.ma
public class SimpleMessageMetaData implements MessageMetaData{
- private long uid;
- private Flags flags;
- private long size;
- private Date internalDate;
- private long modSeq;
+ private final long uid;
+ private final Flags flags;
+ private final long size;
+ private final Date internalDate;
+ private final long modSeq;
public SimpleMessageMetaData(long uid, long modSeq, Flags flags, long size, Date internalDate) {
this.uid = uid;
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java Tue Jan 26 10:22:12 2016
@@ -103,7 +103,7 @@ public class StoreMailboxManager<Id exte
private int moveBatchSize = 0;
- private MailboxPathLocker locker;
+ private final MailboxPathLocker locker;
private MessageSearchIndex<Id> index;
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java Tue Jan 26 10:22:12 2016
@@ -128,7 +128,7 @@ public class StoreMessageManager<Id exte
private final QuotaRootResolver quotaRootResolver;
- private MailboxPathLocker locker;
+ private final MailboxPathLocker locker;
private int fetchBatchSize;
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMessageResultIterator.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMessageResultIterator.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMessageResultIterator.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMessageResultIterator.java Tue Jan 26 10:22:12 2016
@@ -43,15 +43,15 @@ public class StoreMessageResultIterator<
private Iterator<MailboxMessage<Id>> next = null;
private MailboxException exception;
- private Mailbox<Id> mailbox;
- private FetchGroup group;
- private long from;
+ private final Mailbox<Id> mailbox;
+ private final FetchGroup group;
+ private final long from;
private long cursor;
- private long to;
- private int batchSize;
- private Type type;
- private MessageMapper<Id> mapper;
- private FetchType ftype;
+ private final long to;
+ private final int batchSize;
+ private final Type type;
+ private final MessageMapper<Id> mapper;
+ private final FetchType ftype;
public StoreMessageResultIterator(MessageMapper<Id> mapper, Mailbox<Id> mailbox, MessageRange range, int batchSize, org.apache.james.mailbox.model.MessageResult.FetchGroup group) {
this.mailbox = mailbox;
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/event/MailboxListenerRegistry.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/event/MailboxListenerRegistry.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/event/MailboxListenerRegistry.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/event/MailboxListenerRegistry.java Tue Jan 26 10:22:12 2016
@@ -33,8 +33,8 @@ import com.google.common.collect.Multima
public class MailboxListenerRegistry {
- private Multimap<MailboxPath, MailboxListener> listeners;
- private ConcurrentLinkedQueue<MailboxListener> globalListeners;
+ private final Multimap<MailboxPath, MailboxListener> listeners;
+ private final ConcurrentLinkedQueue<MailboxListener> globalListeners;
public MailboxListenerRegistry() {
this.globalListeners = new ConcurrentLinkedQueue<MailboxListener>();
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/json/SimpleMailboxACLJsonConverter.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/json/SimpleMailboxACLJsonConverter.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/json/SimpleMailboxACLJsonConverter.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/json/SimpleMailboxACLJsonConverter.java Tue Jan 26 10:22:12 2016
@@ -45,7 +45,7 @@ public class SimpleMailboxACLJsonConvert
}
}
- private static ObjectMapper objectMapper = new ObjectMapper();
+ private static final ObjectMapper objectMapper = new ObjectMapper();
static {
objectMapper.addMixInAnnotations(SimpleMailboxACL.Rfc4314Rights.class, Rfc4314RightsMixIn.class);
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleMailbox.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleMailbox.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleMailbox.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleMailbox.java Tue Jan 26 10:22:12 2016
@@ -30,7 +30,7 @@ public class SimpleMailbox<Id extends Ma
private String namespace;
private String user;
private String name;
- private long uidValidity;
+ private final long uidValidity;
private MailboxACL acl = SimpleMailboxACL.EMPTY;
public SimpleMailbox(MailboxPath path, long uidValidity) {
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleProperty.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleProperty.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleProperty.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleProperty.java Tue Jan 26 10:22:12 2016
@@ -21,9 +21,9 @@ package org.apache.james.mailbox.store.m
import org.apache.james.mailbox.store.mail.model.Property;
public final class SimpleProperty implements Property {
- private String namespace;
- private String localName;
- private String value;
+ private final String namespace;
+ private final String localName;
+ private final String value;
/**
* Construct a property.
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaChecker.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaChecker.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaChecker.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaChecker.java Tue Jan 26 10:22:12 2016
@@ -31,9 +31,9 @@ import org.apache.james.mailbox.store.ma
public class QuotaChecker<Id extends MailboxId> {
- private Quota messageQuota;
- private Quota sizeQuota;
- private QuotaRoot quotaRoot;
+ private final Quota messageQuota;
+ private final Quota sizeQuota;
+ private final QuotaRoot quotaRoot;
public QuotaChecker(QuotaManager quotaManager, QuotaRootResolver quotaRootResolver, Mailbox<Id> mailbox) throws MailboxException {
this.quotaRoot = quotaRootResolver.getQuotaRoot(new MailboxPath(mailbox.getNamespace(), mailbox.getUser(), mailbox.getName()));
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaImpl.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaImpl.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaImpl.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaImpl.java Tue Jan 26 10:22:12 2016
@@ -33,7 +33,7 @@ public final class QuotaImpl implements
return new QuotaImpl(used, max);
}
- private long max;
+ private final long max;
private long used;
private QuotaImpl(long used, long max) {
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaRootImpl.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaRootImpl.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaRootImpl.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaRootImpl.java Tue Jan 26 10:22:12 2016
@@ -28,7 +28,7 @@ public class QuotaRootImpl implements Qu
return new QuotaRootImpl(value);
}
- private String value;
+ private final String value;
private QuotaRootImpl(String value) {
this.value = value;
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java Tue Jan 26 10:22:12 2016
@@ -44,7 +44,7 @@ import org.apache.james.mailbox.store.ma
*/
public class LazyMessageSearchIndex<Id extends MailboxId> extends ListeningMessageSearchIndex<Id> {
- private ListeningMessageSearchIndex<Id> index;
+ private final ListeningMessageSearchIndex<Id> index;
private final ConcurrentHashMap<Id, Object> indexed = new ConcurrentHashMap<Id, Object>();
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/ListeningMessageSearchIndex.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/ListeningMessageSearchIndex.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/ListeningMessageSearchIndex.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/ListeningMessageSearchIndex.java Tue Jan 26 10:22:12 2016
@@ -44,7 +44,7 @@ import org.apache.james.mailbox.store.ma
*/
public abstract class ListeningMessageSearchIndex<Id extends MailboxId> implements MessageSearchIndex<Id>, MailboxListener {
- private MessageMapperFactory<Id> factory;
+ private final MessageMapperFactory<Id> factory;
public ListeningMessageSearchIndex(MessageMapperFactory<Id> factory) {
this.factory = factory;
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/comparator/HeaderDisplayComparator.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/comparator/HeaderDisplayComparator.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/comparator/HeaderDisplayComparator.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/comparator/HeaderDisplayComparator.java Tue Jan 26 10:22:12 2016
@@ -34,7 +34,7 @@ public class HeaderDisplayComparator ext
private final static Comparator<MailboxMessage<?>> REVERSE_TO_COMPARATOR = new ReverseComparator(TO_COMPARATOR);
- private String headerName;
+ private final String headerName;
public HeaderDisplayComparator(String headerName) {
this.headerName = headerName;
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/BodyOffsetInputStream.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/BodyOffsetInputStream.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/BodyOffsetInputStream.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/BodyOffsetInputStream.java Tue Jan 26 10:22:12 2016
@@ -32,7 +32,7 @@ import java.io.PushbackInputStream;
public class BodyOffsetInputStream extends InputStream{
private long count = 0;
private long bodyStartOctet = -1;
- private PushbackInputStream in;
+ private final PushbackInputStream in;
private long readBytes = 0;
public BodyOffsetInputStream(InputStream in) {
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/FullByteContent.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/FullByteContent.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/FullByteContent.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/FullByteContent.java Tue Jan 26 10:22:12 2016
@@ -39,9 +39,9 @@ import org.apache.james.mailbox.model.Me
public class FullByteContent implements Content {
- private List<Header> headers;
- private byte[] body;
- private long size;
+ private final List<Header> headers;
+ private final byte[] body;
+ private final long size;
public FullByteContent(final byte[] body, final List<MessageResult.Header> headers) throws MailboxException {
this.headers = headers;
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/InputStreamContent.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/InputStreamContent.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/InputStreamContent.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/InputStreamContent.java Tue Jan 26 10:22:12 2016
@@ -30,8 +30,8 @@ import org.apache.james.mailbox.store.ma
*/
public final class InputStreamContent implements Content{
- private Message m;
- private Type type;
+ private final Message m;
+ private final Type type;
public static enum Type {
Full,
Modified: james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/PartContentBuilder.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/PartContentBuilder.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/PartContentBuilder.java (original)
+++ james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/PartContentBuilder.java Tue Jan 26 10:22:12 2016
@@ -42,7 +42,7 @@ public class PartContentBuilder {
private static final byte[] EMPTY = {};
- private MimeTokenStream parser;
+ private final MimeTokenStream parser;
private boolean empty = false;
Modified: james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/MailboxEventDispatcherTest.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/MailboxEventDispatcherTest.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/MailboxEventDispatcherTest.java (original)
+++ james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/MailboxEventDispatcherTest.java Tue Jan 26 10:22:12 2016
@@ -63,7 +63,7 @@ public class MailboxEventDispatcherTest
};
- private Mockery mockery = new JUnit4Mockery();
+ private Mockery mockery = new JUnit4Mockery();
private Mailbox<TestId> mailbox = new Mailbox<TestId>() {
Modified: james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/MockAuthenticator.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/MockAuthenticator.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/MockAuthenticator.java (original)
+++ james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/MockAuthenticator.java Tue Jan 26 10:22:12 2016
@@ -23,7 +23,7 @@ import java.util.Map;
public class MockAuthenticator implements Authenticator{
- private Map<String, String> users = new HashMap<String, String>();
+ private final Map<String, String> users = new HashMap<String, String>();
public boolean isAuthentic(String userid, CharSequence passwd) {
String pass = users.get(userid);
Modified: james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/SimpleMailboxMembership.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/SimpleMailboxMembership.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/SimpleMailboxMembership.java (original)
+++ james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/SimpleMailboxMembership.java Tue Jan 26 10:22:12 2016
@@ -200,7 +200,7 @@ public class SimpleMailboxMembership imp
public String mediaType = null;
public Long textualLineCount = null;
- private int size;
+ private final int size;
private long modSeq;
Modified: james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/json/SimpleMailboxACLJsonConverterTest.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/json/SimpleMailboxACLJsonConverterTest.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/json/SimpleMailboxACLJsonConverterTest.java (original)
+++ james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/json/SimpleMailboxACLJsonConverterTest.java Tue Jan 26 10:22:12 2016
@@ -33,7 +33,7 @@ import org.junit.Test;
public class SimpleMailboxACLJsonConverterTest {
public class ACLMapBuilder {
- private Map<SimpleMailboxACL.MailboxACLEntryKey, MailboxACL.MailboxACLRights> map;
+ private final Map<SimpleMailboxACL.MailboxACLEntryKey, MailboxACL.MailboxACLRights> map;
public ACLMapBuilder() {
map = new HashMap<SimpleMailboxACL.MailboxACLEntryKey, MailboxACL.MailboxACLRights>();
Modified: james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/BayesianAnalysis.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/BayesianAnalysis.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/BayesianAnalysis.java (original)
+++ james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/BayesianAnalysis.java Tue Jan 26 10:22:12 2016
@@ -129,7 +129,7 @@ public class BayesianAnalysis extends Ge
/**
* The JDBCBayesianAnalyzer class that does all the work.
*/
- private JDBCBayesianAnalyzer analyzer = new JDBCBayesianAnalyzer(this);
+ private final JDBCBayesianAnalyzer analyzer = new JDBCBayesianAnalyzer(this);
DataSource datasource;
Modified: james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/BayesianAnalysisFeeder.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/BayesianAnalysisFeeder.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/BayesianAnalysisFeeder.java (original)
+++ james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/BayesianAnalysisFeeder.java Tue Jan 26 10:22:12 2016
@@ -133,7 +133,7 @@ public class BayesianAnalysisFeeder exte
/**
* The JDBCBayesianAnalyzer class that does all the work.
*/
- private JDBCBayesianAnalyzer analyzer = new JDBCBayesianAnalyzer(this);
+ private final JDBCBayesianAnalyzer analyzer = new JDBCBayesianAnalyzer(this);
private DataSource datasource;
Modified: james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/CorpusLoaderThread.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/CorpusLoaderThread.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/CorpusLoaderThread.java (original)
+++ james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/CorpusLoaderThread.java Tue Jan 26 10:22:12 2016
@@ -24,7 +24,7 @@ package org.apache.james.ai.classic;
*/
class CorpusLoaderThread extends Thread {
- private BayesianAnalysis analysis;
+ private final BayesianAnalysis analysis;
CorpusLoaderThread(BayesianAnalysis analysis) {
super("BayesianAnalysis Corpus Loader");
Modified: james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/JDBCBayesianAnalyzer.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/JDBCBayesianAnalyzer.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/JDBCBayesianAnalyzer.java (original)
+++ james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/JDBCBayesianAnalyzer.java Tue Jan 26 10:22:12 2016
@@ -58,7 +58,7 @@ public class JDBCBayesianAnalyzer extend
private Log log;
/** Contains all of the sql strings for this component. */
- private SqlResources sqlQueries = new SqlResources();
+ private final SqlResources sqlQueries = new SqlResources();
/** Holds value of property sqlFileName. */
private String sqlFileName;
Modified: james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/SqlResources.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/SqlResources.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/SqlResources.java (original)
+++ james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/SqlResources.java Tue Jan 26 10:22:12 2016
@@ -46,13 +46,13 @@ import org.w3c.dom.NodeList;
*/
class SqlResources {
/** A map of statement types to SQL statements */
- private Map<String, String> m_sql = new HashMap<String, String>();
+ private final Map<String, String> m_sql = new HashMap<String, String>();
/** A map of engine specific options */
- private Map<String, String> m_dbOptions = new HashMap<String, String>();
+ private final Map<String, String> m_dbOptions = new HashMap<String, String>();
/** A set of all used String values */
- static private Map<String, String> stringTable = java.util.Collections.synchronizedMap(new HashMap<String, String>());
+ static private final Map<String, String> stringTable = java.util.Collections.synchronizedMap(new HashMap<String, String>());
/**
* <p>
Modified: james/project/trunk/mailet/api/src/main/java/org/apache/mailet/HostAddress.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/api/src/main/java/org/apache/mailet/HostAddress.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/api/src/main/java/org/apache/mailet/HostAddress.java (original)
+++ james/project/trunk/mailet/api/src/main/java/org/apache/mailet/HostAddress.java Tue Jan 26 10:22:12 2016
@@ -28,7 +28,7 @@ package org.apache.mailet;
* @deprecated
*/
public class HostAddress extends javax.mail.URLName {
- private String hostname;
+ private final String hostname;
/**
* Constructs a new host address with the given details.
Modified: james/project/trunk/mailet/base/src/main/java/org/apache/mailet/base/MatcherInverter.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/base/src/main/java/org/apache/mailet/base/MatcherInverter.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/base/src/main/java/org/apache/mailet/base/MatcherInverter.java (original)
+++ james/project/trunk/mailet/base/src/main/java/org/apache/mailet/base/MatcherInverter.java Tue Jan 26 10:22:12 2016
@@ -36,7 +36,7 @@ import org.apache.mailet.MatcherConfig;
*/
public class MatcherInverter implements Matcher {
- private Matcher wrappedMatcher;
+ private final Matcher wrappedMatcher;
public MatcherInverter(Matcher wrappedMatcher) {
this.wrappedMatcher = wrappedMatcher;
Modified: james/project/trunk/mailet/base/src/main/java/org/apache/mailet/base/RFC822DateFormat.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/base/src/main/java/org/apache/mailet/base/RFC822DateFormat.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/base/src/main/java/org/apache/mailet/base/RFC822DateFormat.java (original)
+++ james/project/trunk/mailet/base/src/main/java/org/apache/mailet/base/RFC822DateFormat.java Tue Jan 26 10:22:12 2016
@@ -33,7 +33,7 @@ public class RFC822DateFormat extends Sy
/**
* A static instance of the RFC822DateFormat, used by toString
*/
- private static RFC822DateFormat instance;
+ private static final RFC822DateFormat instance;
static {
instance = new RFC822DateFormat();
Modified: james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMail.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMail.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMail.java (original)
+++ james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMail.java Tue Jan 26 10:22:12 2016
@@ -50,7 +50,7 @@ public class FakeMail implements Mail {
private Date lastUpdated;
- private HashMap<String, Serializable> attributes = new HashMap<String, Serializable>();
+ private final HashMap<String, Serializable> attributes = new HashMap<String, Serializable>();
private static final long serialVersionUID = 1L;
Modified: james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMailContext.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMailContext.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMailContext.java (original)
+++ james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMailContext.java Tue Jan 26 10:22:12 2016
@@ -41,9 +41,9 @@ public class FakeMailContext implements
public static class SentMail {
- private MailAddress sender;
- private Collection<MailAddress> recipients;
- private MimeMessage msg;
+ private final MailAddress sender;
+ private final Collection<MailAddress> recipients;
+ private final MimeMessage msg;
public SentMail(MailAddress sender, Collection<MailAddress> recipients, MimeMessage msg) {
this.sender = sender;
Modified: james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMailetConfig.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMailetConfig.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMailetConfig.java (original)
+++ james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMailetConfig.java Tue Jan 26 10:22:12 2016
@@ -33,7 +33,7 @@ public class FakeMailetConfig implements
public String mailetName;
public MailetContext mc;
- private Properties properties;
+ private final Properties properties;
public FakeMailetConfig() {
this("A Mailet", new FakeMailContext());
Modified: james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMatcherConfig.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMatcherConfig.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMatcherConfig.java (original)
+++ james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMatcherConfig.java Tue Jan 26 10:22:12 2016
@@ -27,9 +27,9 @@ import org.apache.mailet.MatcherConfig;
*/
public class FakeMatcherConfig implements MatcherConfig {
- private String matcherName;
+ private final String matcherName;
- private MailetContext mc;
+ private final MailetContext mc;
public FakeMatcherConfig(String matcherName, MailetContext mc) {
super();
Modified: james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMimeMessage.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMimeMessage.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMimeMessage.java (original)
+++ james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMimeMessage.java Tue Jan 26 10:22:12 2016
@@ -47,8 +47,8 @@ public class FakeMimeMessage extends Mim
private String[] m_contentLanguage;
private String m_fileName;
private DataHandler m_dataHandler;
- private HashMap<String, String> m_contentHeaders = new HashMap<String, String>();
- private Flags m_setFlags = new Flags();
+ private final HashMap<String, String> m_contentHeaders = new HashMap<String, String>();
+ private final Flags m_setFlags = new Flags();
private boolean m_doMatch;
public FakeMimeMessage() throws MessagingException {
Modified: james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/SMIMEKeyHolder.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/SMIMEKeyHolder.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/SMIMEKeyHolder.java (original)
+++ james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/SMIMEKeyHolder.java Tue Jan 26 10:22:12 2016
@@ -71,17 +71,17 @@ public class SMIMEKeyHolder implements K
/**
* Holds value of property privateKey.
*/
- private PrivateKey privateKey;
+ private final PrivateKey privateKey;
/**
* Holds value of property certificate.
*/
- private X509Certificate certificate;
+ private final X509Certificate certificate;
/**
* Holds value of property certStore.
*/
- private CertStore certStore;
+ private final CertStore certStore;
/**
* Creates a new instance of <CODE>KeyHolder</CODE> using {@link java.security.KeyStore} related parameters.
Modified: james/project/trunk/mailet/mailetdocs-maven-plugin/src/main/java/org/apache/james/mailet/AbstractMailetdocsReport.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/mailetdocs-maven-plugin/src/main/java/org/apache/james/mailet/AbstractMailetdocsReport.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/mailetdocs-maven-plugin/src/main/java/org/apache/james/mailet/AbstractMailetdocsReport.java (original)
+++ james/project/trunk/mailet/mailetdocs-maven-plugin/src/main/java/org/apache/james/mailet/AbstractMailetdocsReport.java Tue Jan 26 10:22:12 2016
@@ -66,7 +66,7 @@ public abstract class AbstractMailetdocs
*/
private static final class TypePredicate implements Predicate {
- private MailetMatcherDescriptor.Type type;
+ private final MailetMatcherDescriptor.Type type;
public TypePredicate(MailetMatcherDescriptor.Type typeMatcher) {
this.type = typeMatcher;
Modified: james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/ClassifyBounce.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/ClassifyBounce.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/ClassifyBounce.java (original)
+++ james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/ClassifyBounce.java Tue Jan 26 10:22:12 2016
@@ -373,8 +373,8 @@ public class ClassifyBounce extends Gene
return m.find();
}
- private String subject;
- private String text;
+ private final String subject;
+ private final String text;
public final static int TYPE_NORMAL = 1;
public final static int TYPE_OUT_OF_OFFICE = 3;
Modified: james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/MailAttributesToMimeHeaders.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/MailAttributesToMimeHeaders.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/MailAttributesToMimeHeaders.java (original)
+++ james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/MailAttributesToMimeHeaders.java Tue Jan 26 10:22:12 2016
@@ -47,7 +47,7 @@ public class MailAttributesToMimeHeaders
/**
* HashMap which holds the attributeName and headerName
*/
- private HashMap<String, String> map = new HashMap<String, String>();
+ private final HashMap<String, String> map = new HashMap<String, String>();
/*
* (non-Javadoc)
Modified: james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/RemoveMailAttribute.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/RemoveMailAttribute.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/RemoveMailAttribute.java (original)
+++ james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/RemoveMailAttribute.java Tue Jan 26 10:22:12 2016
@@ -45,7 +45,7 @@ import javax.mail.MessagingException;
*/
public class RemoveMailAttribute extends GenericMailet {
- private ArrayList<String> attributesToRemove = new ArrayList<String>();
+ private final ArrayList<String> attributesToRemove = new ArrayList<String>();
/**
* Return a string describing this mailet.
Modified: james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/SetMailAttribute.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/SetMailAttribute.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/SetMailAttribute.java (original)
+++ james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/SetMailAttribute.java Tue Jan 26 10:22:12 2016
@@ -48,7 +48,7 @@ import org.apache.mailet.base.GenericMai
*/
public class SetMailAttribute extends GenericMailet {
- private HashMap<String, String> attributesToSet = new HashMap<String, String>(2);
+ private final HashMap<String, String> attributesToSet = new HashMap<String, String>(2);
private Set<Map.Entry<String, String>> entries;
Modified: james/project/trunk/mpt/antlib/src/main/java/org/apache/james/mpt/ant/MailProtocolTestTask.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mpt/antlib/src/main/java/org/apache/james/mpt/ant/MailProtocolTestTask.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mpt/antlib/src/main/java/org/apache/james/mpt/ant/MailProtocolTestTask.java (original)
+++ james/project/trunk/mpt/antlib/src/main/java/org/apache/james/mpt/ant/MailProtocolTestTask.java Tue Jan 26 10:22:12 2016
@@ -59,7 +59,7 @@ public class MailProtocolTestTask extend
private String host = "127.0.0.1";
private boolean skip = false;
private String shabang = null;
- private Collection<AddUser> users = new ArrayList<AddUser>();
+ private final Collection<AddUser> users = new ArrayList<AddUser>();
private String errorProperty;
/**
Modified: james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ByteBufferInputStream.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ByteBufferInputStream.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ByteBufferInputStream.java (original)
+++ james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ByteBufferInputStream.java Tue Jan 26 10:22:12 2016
@@ -28,9 +28,9 @@ import java.nio.charset.CharsetEncoder;
public class ByteBufferInputStream extends InputStream {
- private ByteBuffer buffer = ByteBuffer.allocate(16384);
+ private final ByteBuffer buffer = ByteBuffer.allocate(16384);
- private CharsetEncoder encoder = Charset.forName("ASCII").newEncoder();
+ private final CharsetEncoder encoder = Charset.forName("ASCII").newEncoder();
private boolean readLast = true;
Modified: james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ByteBufferOutputStream.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ByteBufferOutputStream.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ByteBufferOutputStream.java (original)
+++ james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ByteBufferOutputStream.java Tue Jan 26 10:22:12 2016
@@ -29,9 +29,9 @@ import java.nio.charset.Charset;
public class ByteBufferOutputStream extends OutputStream {
- private ByteBuffer buffer = ByteBuffer.allocate(65536);
- private Charset ascii = Charset.forName("ASCII");
- private Continuation continuation;
+ private final ByteBuffer buffer = ByteBuffer.allocate(65536);
+ private final Charset ascii = Charset.forName("ASCII");
+ private final Continuation continuation;
private boolean matchPlus = false;
private boolean matchCR = false;
private boolean matchLF = false;
Modified: james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ScriptBuilder.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ScriptBuilder.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ScriptBuilder.java (original)
+++ james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ScriptBuilder.java Tue Jan 26 10:22:12 2016
@@ -514,9 +514,9 @@ public class ScriptBuilder {
}
public static final class Flags {
- private StringBuffer flags;
+ private final StringBuffer flags;
- private StringBuffer msn;
+ private final StringBuffer msn;
private boolean first;
@@ -1104,7 +1104,7 @@ public class ScriptBuilder {
private final WritableByteChannel sump;
- private ByteBuffer inBuffer = ByteBuffer.allocate(256);
+ private final ByteBuffer inBuffer = ByteBuffer.allocate(256);
private final ByteBuffer outBuffer = ByteBuffer.allocate(262144);
Modified: james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/protocol/ProtocolSession.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/protocol/ProtocolSession.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/protocol/ProtocolSession.java (original)
+++ james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/protocol/ProtocolSession.java Tue Jan 26 10:22:12 2016
@@ -206,9 +206,9 @@ public class ProtocolSession implements
* A client request, which write the specified message to a Writer.
*/
private static class ClientRequest implements ProtocolElement {
- private int sessionNumber;
+ private final int sessionNumber;
- private String message;
+ private final String message;
/**
* Initialises the ClientRequest with the supplied message.
@@ -263,11 +263,11 @@ public class ProtocolSession implements
* this line.
*/
private class ServerResponse implements ProtocolElement {
- private String lastClientMessage;
+ private final String lastClientMessage;
- private int sessionNumber;
+ private final int sessionNumber;
- private String expectedLine;
+ private final String expectedLine;
protected String location;
Modified: james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/script/AbstractSimpleScriptedTestProtocol.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/script/AbstractSimpleScriptedTestProtocol.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/script/AbstractSimpleScriptedTestProtocol.java (original)
+++ james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/script/AbstractSimpleScriptedTestProtocol.java Tue Jan 26 10:22:12 2016
@@ -39,7 +39,7 @@ public abstract class AbstractSimpleScri
private static final Locale BASE_DEFAULT_LOCALE = Locale.getDefault();
- private FileProtocolSessionBuilder builder = new FileProtocolSessionBuilder();
+ private final FileProtocolSessionBuilder builder = new FileProtocolSessionBuilder();
private final String scriptDirectory;
/**
Modified: james/project/trunk/mpt/impl/imap-mailbox/cassandra/src/test/java/org/apache/james/mpt/imapmailbox/cassandra/host/CassandraHostSystem.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mpt/impl/imap-mailbox/cassandra/src/test/java/org/apache/james/mpt/imapmailbox/cassandra/host/CassandraHostSystem.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mpt/impl/imap-mailbox/cassandra/src/test/java/org/apache/james/mpt/imapmailbox/cassandra/host/CassandraHostSystem.java (original)
+++ james/project/trunk/mpt/impl/imap-mailbox/cassandra/src/test/java/org/apache/james/mpt/imapmailbox/cassandra/host/CassandraHostSystem.java Tue Jan 26 10:22:12 2016
@@ -58,7 +58,7 @@ public class CassandraHostSystem extends
private final CassandraMailboxManager mailboxManager;
private final MockAuthenticator userManager;
- private CassandraCluster cassandraClusterSingleton;
+ private final CassandraCluster cassandraClusterSingleton;
public CassandraHostSystem() throws Exception {
CassandraModule mailboxModule = new CassandraModuleComposite(
Modified: james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/imapmailbox/MailboxCreationDelegate.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/imapmailbox/MailboxCreationDelegate.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/imapmailbox/MailboxCreationDelegate.java (original)
+++ james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/imapmailbox/MailboxCreationDelegate.java Tue Jan 26 10:22:12 2016
@@ -29,7 +29,7 @@ public class MailboxCreationDelegate {
private static final Logger LOGGER = LoggerFactory.getLogger(MailboxCreationDelegate.class);
- private MailboxManager mailboxManager;
+ private final MailboxManager mailboxManager;
public MailboxCreationDelegate(MailboxManager mailboxManager) {
this.mailboxManager = mailboxManager;
Modified: james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/imapmailbox/suite/ACLCommands.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/imapmailbox/suite/ACLCommands.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/imapmailbox/suite/ACLCommands.java (original)
+++ james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/imapmailbox/suite/ACLCommands.java Tue Jan 26 10:22:12 2016
@@ -34,7 +34,7 @@ public class ACLCommands extends BaseIma
public static final String OTHER_USER_NAME = "Boby";
public static final String OTHER_USER_PASSWORD = "password";
public static final MailboxPath OTHER_USER_MAILBOX = new MailboxPath("#private", OTHER_USER_NAME, "") ;
- private MailboxACL.MailboxACLRights readWriteSeenRight;
+ private final MailboxACL.MailboxACLRights readWriteSeenRight;
@Inject
private static HostSystem system;
Modified: james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/session/ImapSessionImpl.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/session/ImapSessionImpl.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/session/ImapSessionImpl.java (original)
+++ james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/session/ImapSessionImpl.java Tue Jan 26 10:22:12 2016
@@ -35,7 +35,7 @@ public class ImapSessionImpl implements
private final Map<String, Object> attributesByKey;
- private Logger log;
+ private final Logger log;
public ImapSessionImpl(Logger log) {
this.attributesByKey = new ConcurrentHashMap<String, Object>();
Modified: james/project/trunk/mpt/impl/imap-mailbox/cyrus/src/test/java/org/apache/james/mpt/imapmailbox/cyrus/host/GrantRightsOnCyrusHost.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mpt/impl/imap-mailbox/cyrus/src/test/java/org/apache/james/mpt/imapmailbox/cyrus/host/GrantRightsOnCyrusHost.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mpt/impl/imap-mailbox/cyrus/src/test/java/org/apache/james/mpt/imapmailbox/cyrus/host/GrantRightsOnCyrusHost.java (original)
+++ james/project/trunk/mpt/impl/imap-mailbox/cyrus/src/test/java/org/apache/james/mpt/imapmailbox/cyrus/host/GrantRightsOnCyrusHost.java Tue Jan 26 10:22:12 2016
@@ -28,7 +28,7 @@ import org.apache.james.mpt.protocol.Pro
public class GrantRightsOnCyrusHost implements GrantRightsOnHost {
private static final String GRANT_RIGHTS_LOCATION = "ACLCommands.grantRights";
- private CyrusHostSystem system;
+ private final CyrusHostSystem system;
@Inject
private GrantRightsOnCyrusHost(CyrusHostSystem system) {
Modified: james/project/trunk/mpt/impl/imap-mailbox/cyrus/src/test/java/org/apache/james/mpt/imapmailbox/cyrus/host/MailboxMessageAppenderOnCyrusHost.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mpt/impl/imap-mailbox/cyrus/src/test/java/org/apache/james/mpt/imapmailbox/cyrus/host/MailboxMessageAppenderOnCyrusHost.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mpt/impl/imap-mailbox/cyrus/src/test/java/org/apache/james/mpt/imapmailbox/cyrus/host/MailboxMessageAppenderOnCyrusHost.java (original)
+++ james/project/trunk/mpt/impl/imap-mailbox/cyrus/src/test/java/org/apache/james/mpt/imapmailbox/cyrus/host/MailboxMessageAppenderOnCyrusHost.java Tue Jan 26 10:22:12 2016
@@ -25,9 +25,9 @@ import org.apache.james.mpt.imapmailbox.
import org.apache.james.mpt.protocol.ProtocolSession;
public class MailboxMessageAppenderOnCyrusHost implements MailboxMessageAppender {
- private static String LOCATION = "cyrus.MailboxMessageProviderOnCyrusHost";
+ private static final String LOCATION = "cyrus.MailboxMessageProviderOnCyrusHost";
- private CyrusHostSystem hostSystem;
+ private final CyrusHostSystem hostSystem;
@Inject
private MailboxMessageAppenderOnCyrusHost(CyrusHostSystem hostSystem) {
Modified: james/project/trunk/mpt/impl/imap-mailbox/hbase/src/test/java/org/apache/james/mpt/imapmailbox/hbase/host/HBaseHostSystem.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mpt/impl/imap-mailbox/hbase/src/test/java/org/apache/james/mpt/imapmailbox/hbase/host/HBaseHostSystem.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mpt/impl/imap-mailbox/hbase/src/test/java/org/apache/james/mpt/imapmailbox/hbase/host/HBaseHostSystem.java (original)
+++ james/project/trunk/mpt/impl/imap-mailbox/hbase/src/test/java/org/apache/james/mpt/imapmailbox/hbase/host/HBaseHostSystem.java Tue Jan 26 10:22:12 2016
@@ -65,7 +65,7 @@ public class HBaseHostSystem extends Jam
private final HBaseMailboxManager mailboxManager;
private final MockAuthenticator userManager;
private MiniHBaseCluster hbaseCluster;
- private Configuration conf;
+ private final Configuration conf;
public static synchronized JamesImapHostSystem build() throws Exception {
if (host == null) {
Modified: james/project/trunk/mpt/impl/managesieve/core/src/main/java/org/apache/james/mpt/host/ManageSieveSession.java
URL: http://svn.apache.org/viewvc/james/project/trunk/mpt/impl/managesieve/core/src/main/java/org/apache/james/mpt/host/ManageSieveSession.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/mpt/impl/managesieve/core/src/main/java/org/apache/james/mpt/host/ManageSieveSession.java (original)
+++ james/project/trunk/mpt/impl/managesieve/core/src/main/java/org/apache/james/mpt/host/ManageSieveSession.java Tue Jan 26 10:22:12 2016
@@ -36,10 +36,10 @@ public class ManageSieveSession implemen
private static final Logger LOGGER = LoggerFactory.getLogger(ManageSieveSession.class);
- private ByteBufferOutputStream out;
- private ByteBufferInputStream in;
- private ManageSieveProcessor manageSieveProcessor;
- private SettableSession settableSession;
+ private final ByteBufferOutputStream out;
+ private final ByteBufferInputStream in;
+ private final ManageSieveProcessor manageSieveProcessor;
+ private final SettableSession settableSession;
private boolean isReadLast = true;
public ManageSieveSession(ManageSieveProcessor manageSieveProcessor, Continuation continuation) {
Modified: james/project/trunk/protocols/api/src/test/java/org/apache/james/protocols/api/AbstractProtocolTransportTest.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/api/src/test/java/org/apache/james/protocols/api/AbstractProtocolTransportTest.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/api/src/test/java/org/apache/james/protocols/api/AbstractProtocolTransportTest.java (original)
+++ james/project/trunk/protocols/api/src/test/java/org/apache/james/protocols/api/AbstractProtocolTransportTest.java Tue Jan 26 10:22:12 2016
@@ -212,7 +212,7 @@ public class AbstractProtocolTransportTe
private final static class TestResponse implements Response {
- private String msg;
+ private final String msg;
public TestResponse() {
this.msg = UUID.randomUUID().toString();
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/display/CharsetUtil.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/display/CharsetUtil.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/display/CharsetUtil.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/display/CharsetUtil.java Tue Jan 26 10:22:12 2016
@@ -36,8 +36,8 @@ import com.beetstra.jutf7.CharsetProvide
*/
public class CharsetUtil {
- private static Set<String> charsetNames;
- private static Set<Charset> charsets;
+ private static final Set<String> charsetNames;
+ private static final Set<Charset> charsets;
private static final String X_MODIFIED_UTF_7 = "X-MODIFIED-UTF-7";
private static final Charset X_MODIFIED_UTF_7_CHARSET = new CharsetProvider().charsetForName(X_MODIFIED_UTF_7);
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/FetchData.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/FetchData.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/FetchData.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/FetchData.java Tue Jan 26 10:22:12 2016
@@ -39,7 +39,7 @@ public class FetchData {
private boolean setSeen = false;
- private Set<BodyFetchElement> bodyElements = new HashSet<BodyFetchElement>();
+ private final Set<BodyFetchElement> bodyElements = new HashSet<BodyFetchElement>();
private boolean modSeq;
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/IdRange.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/IdRange.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/IdRange.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/IdRange.java Tue Jan 26 10:22:12 2016
@@ -186,7 +186,7 @@ public final class IdRange implements It
*/
private final class RangeIterator implements Iterator<Long> {
- private long to;
+ private final long to;
private long current;
public RangeIterator(long from, long to) {
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/SearchKey.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/SearchKey.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/SearchKey.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/SearchKey.java Tue Jan 26 10:22:12 2016
@@ -338,11 +338,11 @@ public final class SearchKey {
private final String value;
- private IdRange[] sequence;
+ private final IdRange[] sequence;
- private long seconds;
+ private final long seconds;
- private long modSeq;
+ private final long modSeq;
private SearchKey(final int type, final DayMonthYear date, final List<SearchKey> keys, final long number, final String name, final String value, IdRange[] sequence, long seconds, long modSeq) {
super();
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/MailboxType.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/MailboxType.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/MailboxType.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/MailboxType.java Tue Jan 26 10:22:12 2016
@@ -33,7 +33,7 @@ public enum MailboxType {
ALLMAIL("\\AllMail"),
OTHER(null);
- private String attributeName;
+ private final String attributeName;
MailboxType(String attributeName) {
this.attributeName = attributeName;
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/main/DefaultImapDecoder.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/main/DefaultImapDecoder.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/main/DefaultImapDecoder.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/main/DefaultImapDecoder.java Tue Jan 26 10:22:12 2016
@@ -41,7 +41,7 @@ public class DefaultImapDecoder implemen
private final ImapCommandParserFactory imapCommands;
- private int maxInvalidCommands;
+ private final int maxInvalidCommands;
private final static String INVALID_COMMAND_COUNT = "INVALID_COMMAND_COUNT";
public final static int DEFAULT_MAX_INVALID_COMMANDS = 9;
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/ImapParserFactory.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/ImapParserFactory.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/ImapParserFactory.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/ImapParserFactory.java Tue Jan 26 10:22:12 2016
@@ -34,7 +34,7 @@ import org.apache.james.imap.decode.Mess
* Command instances are created on demand, when first accessed.
*/
public class ImapParserFactory implements ImapCommandParserFactory {
- private Map<String, Class<?>> _imapCommands;
+ private final Map<String, Class<?>> _imapCommands;
private final StatusResponseFactory statusResponseFactory;
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/AbstractMailboxSelectionRequest.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/AbstractMailboxSelectionRequest.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/AbstractMailboxSelectionRequest.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/AbstractMailboxSelectionRequest.java Tue Jan 26 10:22:12 2016
@@ -31,11 +31,11 @@ import org.apache.james.imap.api.message
public abstract class AbstractMailboxSelectionRequest extends AbstractImapRequest {
private final String mailboxName;
private final boolean condstore;
- private Long lastKnownUidValidity;
- private Long knownModSeq;
- private IdRange[] uidSet;
- private IdRange[] knownUidSet;
- private IdRange[] knownSequenceSet;
+ private final Long lastKnownUidValidity;
+ private final Long knownModSeq;
+ private final IdRange[] uidSet;
+ private final IdRange[] knownUidSet;
+ private final IdRange[] knownSequenceSet;
public AbstractMailboxSelectionRequest(final ImapCommand command, final String mailboxName, final boolean condstore, final Long lastKnownUidValidity, final Long knownModSeq, final IdRange[] uidSet, final IdRange[] knownUidSet, final IdRange[] knownSequenceSet, final String tag) {
super(tag, command);
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/CompressRequest.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/CompressRequest.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/CompressRequest.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/CompressRequest.java Tue Jan 26 10:22:12 2016
@@ -22,7 +22,7 @@ import org.apache.james.imap.api.ImapCom
public class CompressRequest extends AbstractImapRequest {
- private String algorithm;
+ private final String algorithm;
public CompressRequest(String tag, ImapCommand command, String algorithm) {
super(tag, command);
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetQuotaRequest.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetQuotaRequest.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetQuotaRequest.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetQuotaRequest.java Tue Jan 26 10:22:12 2016
@@ -30,8 +30,8 @@ import java.util.List;
public class SetQuotaRequest extends AbstractImapRequest {
public class ResourceLimit {
- private String resource;
- private Long limit;
+ private final String resource;
+ private final Long limit;
public ResourceLimit(String resource, long limit) {
this.limit = limit;
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/StoreRequest.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/StoreRequest.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/StoreRequest.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/StoreRequest.java Tue Jan 26 10:22:12 2016
@@ -37,7 +37,7 @@ public class StoreRequest extends Abstra
private final boolean signedPlus;
- private long unchangedSince;
+ private final long unchangedSince;
public StoreRequest(final ImapCommand command, final IdRange[] idSet, final boolean silent, final Flags flags, final boolean useUids, final String tag, final Boolean sign, final long unchangedSince) {
super(tag, command);
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/AbstractListingResponse.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/AbstractListingResponse.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/AbstractListingResponse.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/AbstractListingResponse.java Tue Jan 26 10:22:12 2016
@@ -42,7 +42,7 @@ public abstract class AbstractListingRes
private final String name;
- private MailboxType type;
+ private final MailboxType type;
public AbstractListingResponse(final boolean noInferiors, final boolean noSelect, final boolean marked, final boolean unmarked, boolean hasChildren, boolean hasNoChildren, final String name, final char hierarchyDelimiter, final MailboxType type) {
super();
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/ESearchResponse.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/ESearchResponse.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/ESearchResponse.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/ESearchResponse.java Tue Jan 26 10:22:12 2016
@@ -32,9 +32,9 @@ public class ESearchResponse implements
private final long count;
private final IdRange[] all;
private final String tag;
- private boolean useUid;
- private List<SearchResultOption> options;
- private Long highestModSeq;
+ private final boolean useUid;
+ private final List<SearchResultOption> options;
+ private final Long highestModSeq;
public ESearchResponse(final long minUid, final long maxUid, final long count, final IdRange[] all, final Long highestModSeq, String tag, final boolean useUid, final List<SearchResultOption> options) {
super();
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/QuotaResponse.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/QuotaResponse.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/QuotaResponse.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/QuotaResponse.java Tue Jan 26 10:22:12 2016
@@ -28,9 +28,9 @@ import org.apache.james.mailbox.model.Qu
* Quota Response
*/
public class QuotaResponse implements ImapResponseMessage {
- private String resourceName;
- private String quotaRoot;
- private Quota quota;
+ private final String resourceName;
+ private final String quotaRoot;
+ private final Quota quota;
public QuotaResponse(String resource, String quotaRoot, Quota quota) {
this.quota = quota;
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/VanishedResponse.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/VanishedResponse.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/VanishedResponse.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/VanishedResponse.java Tue Jan 26 10:22:12 2016
@@ -25,8 +25,8 @@ import org.apache.james.imap.api.message
public class VanishedResponse implements ImapResponseMessage{
- private IdRange[] uids;
- private boolean earlier;
+ private final IdRange[] uids;
+ private final boolean earlier;
public VanishedResponse(IdRange[] uids, boolean earlier) {
this.earlier = earlier;
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/CompressProcessor.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/CompressProcessor.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/CompressProcessor.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/CompressProcessor.java Tue Jan 26 10:22:12 2016
@@ -33,7 +33,7 @@ import org.apache.james.imap.processor.b
public class CompressProcessor extends AbstractChainedProcessor<CompressRequest> implements CapabilityImplementingProcessor {
private final static String ALGO = "DEFLATE";
private final static List<String> CAPA = Collections.unmodifiableList(Arrays.asList(ImapConstants.COMPRESS_COMMAND_NAME + "=" + ALGO));
- private StatusResponseFactory factory;
+ private final StatusResponseFactory factory;
private final static String COMPRESSED = "COMPRESSED";
public CompressProcessor(ImapProcessor next, final StatusResponseFactory factory) {
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/StartTLSProcessor.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/StartTLSProcessor.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/StartTLSProcessor.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/StartTLSProcessor.java Tue Jan 26 10:22:12 2016
@@ -35,7 +35,7 @@ import org.apache.james.imap.processor.b
*/
public class StartTLSProcessor extends AbstractChainedProcessor<StartTLSRequest> implements CapabilityImplementingProcessor {
private final static List<String> STARTTLS_CAP = Collections.unmodifiableList(Arrays.asList(ImapConstants.SUPPORTS_STARTTLS));
- private StatusResponseFactory factory;
+ private final StatusResponseFactory factory;
public StartTLSProcessor(final ImapProcessor next, final StatusResponseFactory factory) {
super(StartTLSRequest.class, next);
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/XListProcessor.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/XListProcessor.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/XListProcessor.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/XListProcessor.java Tue Jan 26 10:22:12 2016
@@ -42,7 +42,7 @@ import org.apache.james.mailbox.MailboxM
public class XListProcessor extends ListProcessor implements CapabilityImplementingProcessor {
private final static List<String> XLIST_CAPS = Collections.unmodifiableList(Arrays.asList(SUPPORTS_XLIST));
- private MailboxTyper mailboxTyper;
+ private final MailboxTyper mailboxTyper;
// some interface
public XListProcessor(final ImapProcessor next, final MailboxManager mailboxManager, final StatusResponseFactory factory, final MailboxTyper mailboxTyper) {
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/base/AbstractChainedProcessor.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/base/AbstractChainedProcessor.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/base/AbstractChainedProcessor.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/base/AbstractChainedProcessor.java Tue Jan 26 10:22:12 2016
@@ -26,7 +26,7 @@ import org.apache.james.imap.api.process
abstract public class AbstractChainedProcessor<M extends ImapMessage> implements ImapProcessor {
private final ImapProcessor next;
- private Class<M> acceptableClass;
+ private final Class<M> acceptableClass;
/**
* Constructs a chainable <code>ImapProcessor</code>.
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java Tue Jan 26 10:22:12 2016
@@ -55,7 +55,7 @@ public class SelectedMailboxImpl impleme
private boolean recentUidRemoved = false;
- private MailboxManager mailboxManager;
+ private final MailboxManager mailboxManager;
private MailboxPath path;
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/fetch/PartialFetchBodyElement.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/fetch/PartialFetchBodyElement.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/fetch/PartialFetchBodyElement.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/fetch/PartialFetchBodyElement.java Tue Jan 26 10:22:12 2016
@@ -79,7 +79,7 @@ final class PartialFetchBodyElement impl
private final class LimitingInputStream extends FilterInputStream {
private long pos = 0;
- private long length;
+ private final long length;
private long offset;
public LimitingInputStream(InputStream in, long offset, long length) {
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/protocols/imap/utils/EolInputStream.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/protocols/imap/utils/EolInputStream.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/protocols/imap/utils/EolInputStream.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/protocols/imap/utils/EolInputStream.java Tue Jan 26 10:22:12 2016
@@ -32,7 +32,7 @@ import org.apache.james.imap.decode.Imap
*/
public class EolInputStream extends FilterInputStream {
- private ImapRequestLineReader reader;
+ private final ImapRequestLineReader reader;
private boolean eolCalled = false;
public EolInputStream(ImapRequestLineReader reader, InputStream in) {
Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/protocols/imap/utils/FixedLengthInputStream.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/protocols/imap/utils/FixedLengthInputStream.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/protocols/imap/utils/FixedLengthInputStream.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/protocols/imap/utils/FixedLengthInputStream.java Tue Jan 26 10:22:12 2016
@@ -33,7 +33,7 @@ import java.io.InputStream;
public class FixedLengthInputStream extends FilterInputStream {
private long pos = 0;
- private long length;
+ private final long length;
public FixedLengthInputStream(InputStream in, long length) {
super(in);
Modified: james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/decode/ImapRequestStreamLineReader.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/decode/ImapRequestStreamLineReader.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/decode/ImapRequestStreamLineReader.java (original)
+++ james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/decode/ImapRequestStreamLineReader.java Tue Jan 26 10:22:12 2016
@@ -32,9 +32,9 @@ import org.apache.james.protocols.imap.u
* {@link ImapRequestLineReader} which use normal IO Streaming
*/
public class ImapRequestStreamLineReader extends ImapRequestLineReader {
- private InputStream input;
+ private final InputStream input;
- private OutputStream output;
+ private final OutputStream output;
public ImapRequestStreamLineReader(InputStream input, OutputStream output) {
this.input = input;
Modified: james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/encode/FetchResponseEncoderEnvelopeTest.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/encode/FetchResponseEncoderEnvelopeTest.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/encode/FetchResponseEncoderEnvelopeTest.java (original)
+++ james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/encode/FetchResponseEncoderEnvelopeTest.java Tue Jan 26 10:22:12 2016
@@ -86,7 +86,7 @@ public class FetchResponseEncoderEnvelop
private Address[] to;
private ByteImapResponseWriter writer = new ByteImapResponseWriter();
- private ImapResponseComposer composer = new ImapResponseComposerImpl(writer);
+ private ImapResponseComposer composer = new ImapResponseComposerImpl(writer);
@Before
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org