[GitHub] [geode] jinmeiliao opened pull request #3928: GEODE-6945:geode-managment should create its own set of configuration…

["jinmeiliao (GitHub)" <gi...@apache.org>]

… objects for Region configuration

Co-authored-by: Darrel Schneider <ds...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3928 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #3928: GEODE-6945:geode-managment should create its own set of configuration…

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

add unit test coverage for this method to RegionConfigRealizer. It would be good for that method to verify that this method does the right thing for every RegionType and that the attributes we support make it to the RegionFactory.

[ Full content available at: https://github.com/apache/geode/pull/3928 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] lgtm-com[bot] commented on issue #3928: GEODE-6945:geode-managment should create its own set of configuration…

[lg...@gitbox.apache.org]

This pull request **introduces 1 alert** and **fixes 1** when merging 51e25b17f55d107901c434449e180ab17a69c24d into 6f4bbbd96bcecdb82cf7753ce1dae9fa6baebf9b - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-5b70645175cd713c75738f8564fea692ad6ee9b9)

**new alerts:**

* 1 for Inconsistent equals and hashCode

**fixed alerts:**

* 1 for Inconsistent equals and hashCode

[ Full content available at: https://github.com/apache/geode/pull/3928 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org