You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/08/18 15:11:49 UTC

[GitHub] akrabat opened a new pull request #2646: Content type header improvements

akrabat opened a new pull request #2646: Content type header improvements
URL: https://github.com/apache/incubator-openwhisk/pull/2646
 
 
   Fix the following issues with JSON content types in web actions:
   
   1. base64 encoded bodies with a content-type of 'application/patch-json.json` should work.
   1. JSON dictionary bodies with a content-type of 'application/patch-json.json` should work.
   1. base64 encoded bodies with a content-type of 'application/hal.json` should work.
   1. JSON dictionary bodies with a content-type of 'application/hal.json` should work.
   
   I chose these two media types as one is "known" by Akka and one is "unknown" as the behaviour is currently different for each one. 
   
   In practice, all media types that are of the correct format should be acceptable, so this PR fixes that which means that technically, we don't need both sets of unit tests. However, I used both sets to prove that the fix worked when developing it.
   
   Fixes #2630 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services