You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/01/13 07:55:42 UTC
[GitHub] [fineract] vorburger opened a new pull request #691: add /rebase
comment support for Pull Requests
vorburger opened a new pull request #691: add /rebase comment support for Pull Requests
URL: https://github.com/apache/fineract/pull/691
https://github.com/marketplace/actions/automatic-rebase
https://github.com/cirrus-actions/rebase
@awasum and anyone else reading this, how about adding this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #691: add /rebase comment
support for Pull Requests
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #691: add /rebase comment support for Pull Requests
URL: https://github.com/apache/fineract/pull/691#issuecomment-574051681
> @vorburger Do we need this documented somewhere on the readme. It can be done after this has been merged if you want. Looks like just writing /rebase in a PR comment should activate this action and rebase the PR. Is this correct?
Yeah, but doesn't seem to quite work yet.. watch https://issues.apache.org/jira/browse/FINERACT-829. Once it does work, I'll announce it on the mailing list. We can also add it to the README, good idea. (Though in practice I think folks typically "learn" about such things less by reading about it in doc and more through seeing others use it in PRs and then by copy cat...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #691: add /rebase comment
support for Pull Requests
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #691: add /rebase comment support for Pull Requests
URL: https://github.com/apache/fineract/pull/691#issuecomment-573554719
#693 will fix the build failure seen here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #691: add /rebase comment
support for Pull Requests
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #691: add /rebase comment support for Pull Requests
URL: https://github.com/apache/fineract/pull/691#issuecomment-574045294
self merging this one based on @awasum comment in #692 ("no experience with Github Actions. Merge when you feel comfortable with this.") - I don't expect any other committers could have a problem with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger merged pull request #691: add /rebase comment
support for Pull Requests
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #691: add /rebase comment support for Pull Requests
URL: https://github.com/apache/fineract/pull/691
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #691: add /rebase comment
support for Pull Requests
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #691: add /rebase comment support for Pull Requests
URL: https://github.com/apache/fineract/pull/691#issuecomment-574043551
@vorburger Do we need this documented somewhere on the readme. It can be done after this has been merged if you want. Looks like just writing /rebase in a PR comment should activate this action and rebase the PR. Is this correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services