You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Weston M. Price (Created) (JIRA)" <ji...@apache.org> on 2012/01/06 19:00:40 UTC
[jira] [Created] (QPID-3731) QpidRASessionImpl incorrectly
evaluates ConnectionRequestInfo.type for XA Connection
QpidRASessionImpl incorrectly evaluates ConnectionRequestInfo.type for XA Connection
------------------------------------------------------------------------------------
Key: QPID-3731
URL: https://issues.apache.org/jira/browse/QPID-3731
Project: Qpid
Issue Type: Bug
Components: JCA
Affects Versions: 0.15
Environment: All OS platforms, all supported JEE platforms.
Reporter: Weston M. Price
Fix For: Future
In QpidRASessionImpl prior to returning a reference we evaluate the ConnectionRequestInfo type looking for an XA connection. I believe this code was inadvertently introduced via cut-n-paste and doesn't make sense. Currently it is causing an issue for certain scenarios where we need to manually acknowledge a message via the standard JMS API. This code should be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3731) QpidRASessionImpl incorrectly
evaluates ConnectionRequestInfo.type for XA Connection
Posted by "Weston M. Price (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Weston M. Price updated QPID-3731:
----------------------------------
Attachment: QPID-3731.patch
Patch for QPID-3731
> QpidRASessionImpl incorrectly evaluates ConnectionRequestInfo.type for XA Connection
> ------------------------------------------------------------------------------------
>
> Key: QPID-3731
> URL: https://issues.apache.org/jira/browse/QPID-3731
> Project: Qpid
> Issue Type: Bug
> Components: JCA
> Affects Versions: 0.15
> Environment: All OS platforms, all supported JEE platforms.
> Reporter: Weston M. Price
> Fix For: Future
>
> Attachments: QPID-3731.patch
>
>
> In QpidRASessionImpl prior to returning a reference we evaluate the ConnectionRequestInfo type looking for an XA connection. I believe this code was inadvertently introduced via cut-n-paste and doesn't make sense. Currently it is causing an issue for certain scenarios where we need to manually acknowledge a message via the standard JMS API. This code should be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3731) QpidRAMessage incorrectly calls
getSession to determine if underlying JMS session has been closed.
Posted by "Weston M. Price (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Weston M. Price reassigned QPID-3731:
-------------------------------------
Assignee: Weston M. Price
> QpidRAMessage incorrectly calls getSession to determine if underlying JMS session has been closed.
> --------------------------------------------------------------------------------------------------
>
> Key: QPID-3731
> URL: https://issues.apache.org/jira/browse/QPID-3731
> Project: Qpid
> Issue Type: Bug
> Components: JCA
> Affects Versions: 0.15
> Environment: All OS platforms, all supported JEE platforms.
> Reporter: Weston M. Price
> Assignee: Weston M. Price
> Fix For: Future
>
> Attachments: QPID-3731.patch, QPID-3731.patch
>
>
> In QpidRASessionImpl prior to returning a reference we evaluate the ConnectionRequestInfo type looking for an XA connection. I believe this code was inadvertently introduced via cut-n-paste and doesn't make sense. Currently it is causing an issue for certain scenarios where we need to manually acknowledge a message via the standard JMS API. This code should be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3731) QpidRAMessage incorrectly calls
getSession to determine if underlying JMS session has been closed.
Posted by "Weston M. Price (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Weston M. Price resolved QPID-3731.
-----------------------------------
Resolution: Fixed
Addressed with attached patch.
> QpidRAMessage incorrectly calls getSession to determine if underlying JMS session has been closed.
> --------------------------------------------------------------------------------------------------
>
> Key: QPID-3731
> URL: https://issues.apache.org/jira/browse/QPID-3731
> Project: Qpid
> Issue Type: Bug
> Components: JCA
> Affects Versions: 0.15
> Environment: All OS platforms, all supported JEE platforms.
> Reporter: Weston M. Price
> Assignee: Weston M. Price
> Fix For: Future
>
> Attachments: QPID-3731.patch, QPID-3731.patch
>
>
> In QpidRASessionImpl prior to returning a reference we evaluate the ConnectionRequestInfo type looking for an XA connection. I believe this code was inadvertently introduced via cut-n-paste and doesn't make sense. Currently it is causing an issue for certain scenarios where we need to manually acknowledge a message via the standard JMS API. This code should be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3731) QpidRAMessage incorrectly calls
getSession to determine if underlying JMS session has been closed.
Posted by "Weston M. Price (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Weston M. Price updated QPID-3731:
----------------------------------
Attachment: QPID-3731.patch
Patch for 3731.
> QpidRAMessage incorrectly calls getSession to determine if underlying JMS session has been closed.
> --------------------------------------------------------------------------------------------------
>
> Key: QPID-3731
> URL: https://issues.apache.org/jira/browse/QPID-3731
> Project: Qpid
> Issue Type: Bug
> Components: JCA
> Affects Versions: 0.15
> Environment: All OS platforms, all supported JEE platforms.
> Reporter: Weston M. Price
> Fix For: Future
>
> Attachments: QPID-3731.patch, QPID-3731.patch
>
>
> In QpidRASessionImpl prior to returning a reference we evaluate the ConnectionRequestInfo type looking for an XA connection. I believe this code was inadvertently introduced via cut-n-paste and doesn't make sense. Currently it is causing an issue for certain scenarios where we need to manually acknowledge a message via the standard JMS API. This code should be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3731) QpidRAMessage incorrectly calls
getSession to determine if underlying JMS session has been closed.
Posted by "Weston M. Price (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Weston M. Price updated QPID-3731:
----------------------------------
Summary: QpidRAMessage incorrectly calls getSession to determine if underlying JMS session has been closed. (was: QpidRASessionImpl incorrectly evaluates ConnectionRequestInfo.type for XA Connection)
I am modifying this issue as the original description was incorrect. QpidRAMessage should call session.getSessionInternal() to determine if the underlying session has been closed prior to calling message.acknowledge(). As a result, the original patch is invalid.
> QpidRAMessage incorrectly calls getSession to determine if underlying JMS session has been closed.
> --------------------------------------------------------------------------------------------------
>
> Key: QPID-3731
> URL: https://issues.apache.org/jira/browse/QPID-3731
> Project: Qpid
> Issue Type: Bug
> Components: JCA
> Affects Versions: 0.15
> Environment: All OS platforms, all supported JEE platforms.
> Reporter: Weston M. Price
> Fix For: Future
>
> Attachments: QPID-3731.patch
>
>
> In QpidRASessionImpl prior to returning a reference we evaluate the ConnectionRequestInfo type looking for an XA connection. I believe this code was inadvertently introduced via cut-n-paste and doesn't make sense. Currently it is causing an issue for certain scenarios where we need to manually acknowledge a message via the standard JMS API. This code should be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org