[jira] [Commented] (CALCITE-4292) Remove exist condition from Not equals criteria

["Stamatis Zampetakis (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418513#comment-17418513 ] 

Stamatis Zampetakis commented on CALCITE-4292:
----------------------------------------------

[~shlok7296] The best way to describe the problem is to add a complete SQL query with actual and expected result in the description of the JIRA.

> Remove exist condition from Not equals criteria
> -----------------------------------------------
>
>                 Key: CALCITE-4292
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4292
>             Project: Calcite
>          Issue Type: Bug
>          Components: elasticsearch-adapter
>            Reporter: Shlok Srivastava
>            Assignee: Bill Neil
>            Priority: Major
>              Labels: ElasticSearch, NotEquals, QueryBuilder, calcite, pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> SQL Query for notEquals condition :
> {code:java}
> Name <> "NMQAX"{code}
> RelNode for same - 
> {code:java}
> relB.not(relB.equals(relb.literal("Name"),relb.literal"NMQAX")){code}
>  
> The elasticsearch query formed  for above RelNode is this : 
> {code:java}
> {
>   "query": {
>     "constant_score": {
>       "filter": {
>         "bool": {
>           "must": {
>             "exists": {
>               "field": "Name"
>             }
>           },
>           "must_not": {
>             "term": {
>               "Name": "NMQAX"
>             }
>           }
>         }
>       }
>     }
>   }
> }
> {code}
> *Problem* : The above query ignores document which do not have _Name_ field which is ideally included by elasticsearch but ignored due to must exists condition. 
> *Solution* : Remove the exists condition from Not equals Query Expression. Elasticsearch doesn't put this condition therefore keeping queries in sync. [Code|https://github.com/apache/calcite/blob/1050b36cafbb0c487b7a2ade3efd12850609717e/elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/PredicateAnalyzer.java#L782]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)