You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/08 10:00:25 UTC
[GitHub] [ozone] kaijchen opened a new pull request, #3494: HDDS-6845. Add CI to check pull request title
kaijchen opened a new pull request, #3494:
URL: https://github.com/apache/ozone/pull/3494
## What changes were proposed in this pull request?
Enforce the PR title to match the pattern `^HDDS-[1-9][0-9]{3,4}\. .+$`.
```
HDDS-1234. Pull Request Title // ok
HDDS-1234 Pull Request Title // bad (missing dot)
HDDS-1234.Pull Request Title // bad (missing space)
HDDS-0123. Pull Request Title // bad (leading zero)
HDDS-12345. Pull Request Title // ok (ready for 5 digit Jira number)
HDDS-123456. Pull Request Title // bad (to be enabled when needed)
```
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6845
## How was this patch tested?
Can be verified by changing the title of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1149716677
Closed due to `slashgear/action-check-pr-title@v3.0.0 is not allowed to be used in apache/ozone.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on a diff in pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
sodonnel commented on code in PR #3494:
URL: https://github.com/apache/ozone/pull/3494#discussion_r893371776
##########
.github/workflows/pull-request.yml:
##########
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: pull request
+
+on:
+ pull_request:
+ types:
+ - reopened
+ - opened
+ - edited
+ - synchronize
+
+jobs:
+ title:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Check pull request title
+ env:
+ TITLE: ${{ github.event.pull_request.title }}
+ run:
+ echo "${TITLE}" | grep -E '^HDDS-[1-9][0-9]{3,4}\. .*[^ ]$' | grep -v ' '
Review Comment:
If you want to ensure there is not a double space after the `HDDS-1234.` should we add in something explicit, like:
```
^HDDS-[1-9][0-9]{3,4}\.[[:space:]][^[:space:]]+.*[^[:space:]]$
```
Ie, it is a space; zero or 1 "not a space"; zero or more of any character.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3494:
URL: https://github.com/apache/ozone/pull/3494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1149792333
> Thanks for working on this @kaijchen . In some cases, the pr title has the feature label like [FSO] or [EC]. I guess this won't get handled here
I think those cases should be fine.
For example: `HDDS-6708. [FSO] Make normalize keyPath on key rename request (#3386)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1152708489
Thanks @kaijchen for the contribution, @sadanand48 and @sodonnel for the reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1149821620
Thanks for the review @sadanand48, I have updated this PR to cover cases with illegal spaces.
Please take another look.
PS: Do you think we should check the trailing `.`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on a diff in pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #3494:
URL: https://github.com/apache/ozone/pull/3494#discussion_r892505478
##########
.github/workflows/pull-request.yml:
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: pull request
+
+on:
+ pull_request:
+ types:
+ - reopened
+ - opened
+ - edited
+ - synchronize
+
+jobs:
+ title:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Check pull request title
+ env:
+ TITLE: ${{ github.event.pull_request.title }}
+ run:
+ echo "${TITLE}" | grep -E '^HDDS-[1-9][0-9]{3,4}\. .*[^ ]$'
Review Comment:
good idea, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 commented on a diff in pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
sadanand48 commented on code in PR #3494:
URL: https://github.com/apache/ozone/pull/3494#discussion_r892502685
##########
.github/workflows/pull-request.yml:
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: pull request
+
+on:
+ pull_request:
+ types:
+ - reopened
+ - opened
+ - edited
+ - synchronize
+
+jobs:
+ title:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Check pull request title
+ env:
+ TITLE: ${{ github.event.pull_request.title }}
+ run:
+ echo "${TITLE}" | grep -E '^HDDS-[1-9][0-9]{3,4}\. .*[^ ]$'
Review Comment:
We could also merge both the checks into one using pipe ,` echo "${TITLE}" | grep -E '^HDDS-[1-9][0-9]{3,4}\. .*[^ ]$' | grep -v ' '`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on a diff in pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #3494:
URL: https://github.com/apache/ozone/pull/3494#discussion_r893385924
##########
.github/workflows/pull-request.yml:
##########
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: pull request
+
+on:
+ pull_request:
+ types:
+ - reopened
+ - opened
+ - edited
+ - synchronize
+
+jobs:
+ title:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Check pull request title
+ env:
+ TITLE: ${{ github.event.pull_request.title }}
+ run:
+ echo "${TITLE}" | grep -E '^HDDS-[1-9][0-9]{3,4}\. .*[^ ]$' | grep -v ' '
Review Comment:
The current expression is checking no double space at any place, and I think it's better (and clearer).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1151410923
I have also added detailed error message to help identify the error when the check fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on a diff in pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #3494:
URL: https://github.com/apache/ozone/pull/3494#discussion_r892262798
##########
.github/workflows/pull-request.yml:
##########
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: pull request
+
+on:
+ pull_request:
+ types:
+ - reopened
+ - opened
+ - edited
+ - synchronize
+
+jobs:
+ title:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Check pull request title
+ env:
+ TITLE: ${{ github.event.pull_request.title }}
+ run:
+ echo ${TITLE} | grep -E '^HDDS-[1-9][0-9]{3,4}\. .+$'
Review Comment:
Covered now: https://github.com/apache/ozone/runs/6792860766?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1151568462
Thanks @kaijchen for updating the patch.
The only concern I have is about the requirement for 4-5 digits: there are 93 open Jira issues preceding HDDS-1000. We could not create PRs for these due to to few digits. How about a less strict check for any number of digits (or maybe 1-5)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1151433215
confirmed bats checked in
https://github.com/apache/ozone/runs/6818147594?check_suite_focus=true#step:5:39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1150067582
Thanks for the review @sadanand48.
> I'm not really sure, On checking the current PR Queue, there are a few with '.' and few without it. I think we can leave it
I agree with you. Since we have no check previously, it's better not to be too strict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1149819456
Trailing space is covered in https://github.com/apache/ozone/runs/6792930448?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
sadanand48 commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1150052548
Thanks for updating the PR.
> : Do you think we should check the trailing `.`?
I'm not really sure, On checking the current PR Queue, there are a few with '.' and few without it. I think we can leave it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on a diff in pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
sodonnel commented on code in PR #3494:
URL: https://github.com/apache/ozone/pull/3494#discussion_r893669696
##########
.github/workflows/pull-request.yml:
##########
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: pull request
+
+on:
+ pull_request:
+ types:
+ - reopened
+ - opened
+ - edited
+ - synchronize
+
+jobs:
+ title:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Check pull request title
+ env:
+ TITLE: ${{ github.event.pull_request.title }}
+ run:
+ echo "${TITLE}" | grep -E '^HDDS-[1-9][0-9]{3,4}\. .*[^ ]$' | grep -v ' '
Review Comment:
Ah ok. I didn't realize the check was for double spaces everywhere. Makes sense to keep it as it is then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 commented on a diff in pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
sadanand48 commented on code in PR #3494:
URL: https://github.com/apache/ozone/pull/3494#discussion_r892233752
##########
.github/workflows/pull-request.yml:
##########
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: pull request
+
+on:
+ pull_request:
+ types:
+ - reopened
+ - opened
+ - edited
+ - synchronize
+
+jobs:
+ title:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Check pull request title
+ env:
+ TITLE: ${{ github.event.pull_request.title }}
+ run:
+ echo ${TITLE} | grep -E '^HDDS-[1-9][0-9]{3,4}\. .+$'
Review Comment:
`"HDDS-1234. Pull Request Title "`. multiple spaces after dot is a bad case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on a diff in pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #3494:
URL: https://github.com/apache/ozone/pull/3494#discussion_r892240917
##########
.github/workflows/pull-request.yml:
##########
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: pull request
+
+on:
+ pull_request:
+ types:
+ - reopened
+ - opened
+ - edited
+ - synchronize
+
+jobs:
+ title:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Check pull request title
+ env:
+ TITLE: ${{ github.event.pull_request.title }}
+ run:
+ echo ${TITLE} | grep -E '^HDDS-[1-9][0-9]{3,4}\. .+$'
Review Comment:
Thanks for the advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen closed pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen closed pull request #3494: HDDS-6845. Add CI to check pull request title
URL: https://github.com/apache/ozone/pull/3494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1151830053
> Thanks @kaijchen for updating the patch.
>
> The only concern I have is about the requirement for 4-5 digits: there are 93 open Jira issues preceding [HDDS-1000](https://issues.apache.org/jira/browse/HDDS-1000). We could not create PRs for these due to to few digits. How about a less strict check for any number of digits (or maybe 1-5)?
Sure, I didn't realize some old Jiras are still open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
sadanand48 commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1149798076
> I think those cases should be fine.
Sure thanks for clarifying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1152812361
Thanks @sadanand48 @sodonnel @adoroszlai for the reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1151040095
> Keeping it in separate workflow is OK. The test is useful because it captures valid and invalid examples, and is easier to run than manually editing PR titles.
I got your point. Thanks for the advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1151004760
> I would suggest extracting the check into a script in `dev-support/ci`, and adding `bats` test for it.
It could be in a script but notice the event trigger this CI is different than the others.
We may need to modify `build-info` regarding to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3494: HDDS-6845. Add CI to check pull request title
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3494:
URL: https://github.com/apache/ozone/pull/3494#issuecomment-1151028707
> > I would suggest extracting the check into a script in `dev-support/ci`, and adding `bats` test for it.
>
> It could be in a script but notice the event trigger this CI is different than the others. We may need to modify `build-info` regarding to this.
Keeping it in separate workflow is OK. The test is useful because it captures valid and invalid examples, and is easier to run than manually editing PR titles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org