[GitHub] [pulsar] yjshen commented on a change in pull request #6345: [Java Reader Client] Start reader inside batch result in read first message in batch.

[GitBox <gi...@apache.org>]

yjshen commented on a change in pull request #6345: [Java Reader Client] Start reader inside batch result in read first message in batch.
URL: https://github.com/apache/pulsar/pull/6345#discussion_r394270891
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
 ##########
 @@ -1520,7 +1536,10 @@ public void seek(long timestamp) throws PulsarClientException {
         cnx.sendRequestWithId(seek, requestId).thenRun(() -> {
             log.info("[{}][{}] Successfully reset subscription to message id {}", topic, subscription, messageId);
             acknowledgmentsGroupingTracker.flushAndClean();
-            lastDequeuedMessage = messageId;
+
+            seekMessageId = new BatchMessageIdImpl((MessageIdImpl) messageId);
+            duringSeek.set(true);
 
 Review comment:
   The logic w/o this PR is problematic because `lastDequeueMessage` is insufficient to express seek, startMessageId and normal dequeue behavior. Therefore lead the bug as this PR aims to fix.
   
   Therefore, If it breaks your test, please reconsider your code logic by using the `seekMessageId` or `lastDequeueMessage`. Since the master branch is in the health state

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services