[GitHub] [cordova-plugin-inappbrowser] The-White-Fang commented on pull request #892: Added fullscreen-video support

[GitBox <gi...@apache.org>]

The-White-Fang commented on pull request #892:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/892#issuecomment-883500633


   > Hi there,
   > 
   > First I'd like to thank you for your time in preparing this PR. I was able to give this a glance over and there's a few main things that I want to point out.
   > 
   > 1. There are new classes added that needs to be licensed under the Apache license for Apache to accept the code. If you have permission from the original author to re-license the code under the [Apache License](https://www.apache.org/licenses/LICENSE-2.0), then the Apache license headers needs to be added. Otherwise we cannot accept the Pr unfortunately.
   > 2. This PR adds maintenance support for code going back as Android 3.0 (API 11). Cordova only supports API >= 22 and adding conditional logic to support anything less adds unnecessary complexity. I would like to see this simplified by removing any extra code required to support APIs < 22.
   > 
   > Kind regards,
   > Norman
   
   Hey Norman,
   I would gladly update the code as you have requested. But it might take me some time. Hope you understand.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org