[GitHub] [trafficserver] bneradt opened a new pull request, #9135: 9.1.x: Fix GCC 12 compiler warnings

[GitBox <gi...@apache.org>]

bneradt opened a new pull request, #9135:
URL: https://github.com/apache/trafficserver/pull/9135

   This fixes GCC 12 compiler warnings for 9.1.x:
   
   ```
       LogFilter: fix NULL termination check (#8603)
       
       gcc-12 generated the following warning:
       
       proxy/logging/LogFilter.h: In function 'void wipeField(char**, char*, const char*)':
       proxy/logging/LogFilter.h:477:35: error: comparing the result of pointer addition '(new_param + 1)' and NULL [-Werror=address]
         477 |       if (new_param && (new_param + 1)) {
             |                        ~~~~~~~~~~~^~~~
       
       That is indeed a bug. `new_param + 1` will always be non-NULL even if new_param
       is NULL because 1 will be added to it. The intention was to check for the
       string's null terminator at the offset, which is done via a dereference.
       
       (cherry picked from commit 9966c9b8210ade388598aa42ac49f960126bfff7)
   
   
       Fix Clang 13.0.1 and GCC 12.0.1 Compiler Warnings (#8690)
       
       This cherry-picks two commits from master:
       
       Fix Clang 13.0.1 compiler warnings (#8685)
       
       This fixes a couple compiler warnings raised by Clang 13.0.1.
       
       (cherry picked from commit 96ce993fa53a05b872c5041629e3aac0bc15d56d)
       
       Fix warnings from GCC 12.0.1 (#8684)
       
       This patch fixes warnings generated by GCC 12.0.1. The warnings involved the
       use of the deprecated std::binary_function, std::unary_function, and
       std::iterator interfaces. The use of these was considered more confusing than
       explicitly declaring the associated types. Therefore this patch replaces the
       use of these deprecated interfaces with the declaration of the associated
       types.
       
       (cherry picked from commit 0ae34d4d1699d978f6938027efb2ecb9ae05c89a)
       (cherry picked from commit 1a37ae9efaf40ee19e3a735828c03ed25eac6a4f)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bryancall merged pull request #9135: 9.1.x: Fix GCC 12 compiler warnings

[GitBox <gi...@apache.org>]

bryancall merged PR #9135:
URL: https://github.com/apache/trafficserver/pull/9135


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org