[GitHub] cloudstack pull request #1794: added more guest os

[koushik-das <gi...@git.apache.org>]

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1794#discussion_r91235138
  
    --- Diff: setup/db/db/schema-4910to41000.sql ---
    @@ -45,4 +45,48 @@ CREATE TABLE `cloud`.`vlan_details` (
       `display` tinyint(1) NOT NULL DEFAULT 1 COMMENT 'Should detail be displayed to the end user',
       PRIMARY KEY (`id`),
       CONSTRAINT `fk_vlan_details__vlan_id` FOREIGN KEY `fk_vlan_details__vlan_id`(`vlan_id`) REFERENCES `vlan`(`id`) ON DELETE CASCADE
    -) ENGINE=InnoDB DEFAULT CHARSET=utf8;
    \ No newline at end of file
    +) ENGINE=InnoDB DEFAULT CHARSET=utf8;
    +
    +INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (261, UUID(), 1, 'CentOS 6.6 (32-bit)', now());
    --- End diff --
    
    Is there a need to pass the 'id' in guest_os? As per table definition it is marked as auto incremented. In case there are already entries with same id (for other guest OS), insert won't happen and these newly added guest OS will not show up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---