You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ja...@apache.org on 2021/09/23 20:18:23 UTC

svn commit: r1893582 - /httpd/httpd/trunk/modules/test/mod_dialup.c

Author: jailletc36
Date: Thu Sep 23 20:18:23 2021
New Revision: 1893582

URL: http://svn.apache.org/viewvc?rev=1893582&view=rev
Log:
Tentative update to reduce noise in travis log (i.e. tons of AH02637).

Just switch 2 tests in 'dialup_handler()' when deciding to DECLINE something.

If mod_dialup is not configured, there is no need lo log anything about an
mpm that doesn't support something that is finally not used.

Modified:
    httpd/httpd/trunk/modules/test/mod_dialup.c

Modified: httpd/httpd/trunk/modules/test/mod_dialup.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/test/mod_dialup.c?rev=1893582&r1=1893581&r2=1893582&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/test/mod_dialup.c (original)
+++ httpd/httpd/trunk/modules/test/mod_dialup.c Thu Sep 23 20:18:23 2021
@@ -157,13 +157,6 @@ dialup_handler(request_rec *r)
         return DECLINED;
     }
 
-    rv = ap_mpm_query(AP_MPMQ_CAN_SUSPEND, &mpm_can_suspend);
-    if (!mpm_can_suspend) {
-        ap_log_rerror (APLOG_MARK, APLOG_NOTICE, rv, r, APLOGNO(02637)
-                "dialup: MPM doesn't support suspending");
-        return DECLINED;
-    }
-
     dcfg = ap_get_module_config(r->per_dir_config,
                                 &dialup_module);
 
@@ -171,6 +164,13 @@ dialup_handler(request_rec *r)
         return DECLINED;
     }
 
+    rv = ap_mpm_query(AP_MPMQ_CAN_SUSPEND, &mpm_can_suspend);
+    if (!mpm_can_suspend) {
+        ap_log_rerror (APLOG_MARK, APLOG_NOTICE, rv, r, APLOGNO(02637)
+                "dialup: MPM doesn't support suspending");
+        return DECLINED;
+    }
+
     ccfg = ap_get_core_module_config(r->per_dir_config);