You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/05 10:32:38 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1518: arch/sim: Always preserve the heap memory dynamically

xiaoxiang781216 opened a new pull request #1518:
URL: https://github.com/apache/incubator-nuttx/pull/1518


   ## Summary
   so size with nuttx could report the correct bss value:
     text    data     bss     dec     hex filename
    155467    1464    1948  158879   26c9f nuttx
   otherwise, the heap memmory classify to bss section.
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1518: arch/sim: Always preserve the heap memory dynamically

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1518:
URL: https://github.com/apache/incubator-nuttx/pull/1518#issuecomment-669720287


   Do you mean Windows native? It is impossible to build sim successfully without the reconstruction of implementation. For Cygwin and MSYS2, mmap should always exist.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #1518: arch/sim: Always preserve the heap memory dynamically

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #1518:
URL: https://github.com/apache/incubator-nuttx/pull/1518#issuecomment-669662681


   iirc availability of mmap for some platform (windows?) was a concern here. has the situation changed since then?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jerpelea merged pull request #1518: arch/sim: Always preserve the heap memory dynamically

Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #1518:
URL: https://github.com/apache/incubator-nuttx/pull/1518


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1518: arch/sim: Always preserve the heap memory dynamically

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1518:
URL: https://github.com/apache/incubator-nuttx/pull/1518#issuecomment-670673526


   @yamt could you merge this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #1518: arch/sim: Always preserve the heap memory dynamically

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #1518:
URL: https://github.com/apache/incubator-nuttx/pull/1518#issuecomment-669723887


   i didn't mean anything specific. just a vague concern. if it's ok for those platforms, i have no problem with this change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org