You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Karuppayya <gi...@git.apache.org> on 2015/08/17 15:00:40 UTC
[GitHub] incubator-zeppelin pull request: Clone a note
GitHub user Karuppayya opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/219
Clone a note
Adding ability to clone a note.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Karuppayya/incubator-zeppelin clonenote
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/219.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #219
----
commit 39c0f46b4c72755fa8563da9d003264310a02eae
Author: Karuppayya <ka...@outlook.com>
Date: 2015-08-16T10:55:14Z
Ability to clone a note
commit 4f1f434d37ca2d73d05908462caaa2598bf65843
Author: Karuppayya <ka...@qubole.com>
Date: 2015-08-17T06:06:47Z
implement clone method in paragraph
commit 12a9e455b46a406bfd0c8db24155341995e78997
Author: Karuppayya <ka...@qubole.com>
Date: 2015-08-17T12:44:44Z
Minor bug fixes
commit 39a0919dbc33ffb6a213e382a222c989d1a3e74c
Author: Karuppayya <ka...@qubole.com>
Date: 2015-08-17T12:49:17Z
Minor bug fixes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Clone a note
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-132883411
@zenglinxi0615 the feature is complete. U can pull my branch to get hands on.
As to when it will be merged , tagging @Leemoonsoo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Clone a note
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-132387297
+1 on copy icon and interpreter bindings
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Clone a note
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-132964251
Can we resolve the following issue.?
https://issues.apache.org/jira/browse/ZEPPELIN-126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Clone a note
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/219
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Clone a note
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-133212432
@Karuppayya could tell me your jira id?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Clone a note
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-132184238
LGTM!
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Clone a note
Posted by jitenderaswani <gi...@git.apache.org>.
Github user jitenderaswani commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-132698032
This is a much needed feature! Love it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Clone a note
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-132446858
@Leemoonsoo The copy icon looks better :-).
@Leemoonsoo @felixcheung I have also added code to copy the interpreter bindings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Clone a note
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-132348355
Tested and working nicely.
Current icon "icon-grid"
is not very intuitive to me.
What do you think "fa fa-copy"
?
Cloning notebook does not copy interpreter bindings. How about copying interpreter bindings, too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Clone a note
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-133253840
@Karuppayya can not find your jira apache id `karuppayya1990`. Could you confirm?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Clone a note
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-132735329
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Clone a note
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-133257965
Oops.. id is karup1990 @Leemoonsoo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Clone a note
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-133240864
@Leemoonsoo my id is karuppayya1990
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Clone a note
Posted by zenglinxi0615 <gi...@git.apache.org>.
Github user zenglinxi0615 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-132873724
this feature sounds very good and helpful! thanks for your work! Love it very much!
can I ask that, what's the schedule of this feature or is this work already finished?
when will this feature merge to master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---