[GitHub] jinhuang415 opened a new pull request #11090: Define build target for mkldnn lib build to fix 'make clean USE_MKMLDNN=1' issue

[GitBox <gi...@apache.org>]

jinhuang415 opened a new pull request #11090: Define build target for mkldnn lib build to fix 'make clean USE_MKMLDNN=1' issue
URL: https://github.com/apache/incubator-mxnet/pull/11090
 
 
   This is a follow up for https://github.com/apache/incubator-mxnet/pull/10783, the view is messed up in that PR so open this new one.
   
   This is to fix the 'make clean USE_MKMLDNN=1' will download and build MKLDNN library issue. As suggested in https://github.com/apache/incubator-mxnet/pull/10783, the new solution is to define a mkldnn make target and integrate into current make dependency, this solution will be cleaner.  It also simplifies current mkldnn library build logic a little bit. One simplification is assume MKLDNNROOT and MKLROOT now share the same directory since we always download mklml and copy the headers/libs to MKLDNN lib directory. Since we used mkldnn.mk to handle build logic,  prepare_mkldnn.sh/prepare_mkl.sh is not needed anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services