You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by si...@apache.org on 2018/05/05 05:26:44 UTC

[incubator-pulsar] branch master updated: Simplify creation of functions namespace (#1735)

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new bb98419  Simplify creation of functions namespace (#1735)
bb98419 is described below

commit bb98419a41581410f79f3a23383c1a6c9ab32d11
Author: Sanjeev Kulkarni <sa...@gmail.com>
AuthorDate: Fri May 4 22:26:41 2018 -0700

    Simplify creation of functions namespace (#1735)
---
 .../java/org/apache/pulsar/functions/worker/Worker.java    | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/Worker.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/Worker.java
index a7fd982..469cdf0 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/Worker.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/Worker.java
@@ -24,6 +24,7 @@ import lombok.extern.slf4j.Slf4j;
 import org.apache.pulsar.client.admin.PulsarAdmin;
 import org.apache.pulsar.client.admin.PulsarAdminException;
 import org.apache.pulsar.common.conf.InternalConfigurationData;
+import org.apache.pulsar.common.policies.data.Policies;
 import org.apache.pulsar.common.policies.data.RetentionPolicies;
 import org.apache.pulsar.functions.worker.rest.WorkerServer;
 
@@ -101,7 +102,10 @@ public class Worker extends AbstractService {
                 if (e.getStatusCode() == Response.Status.NOT_FOUND.getStatusCode()) {
                     // if not found than create
                     try {
-                        admin.namespaces().createNamespace(workerConfig.getPulsarFunctionsNamespace());
+                        Policies policies = new Policies();
+                        policies.retention_policies = new RetentionPolicies(-1, -1);
+                        admin.namespaces().createNamespace(workerConfig.getPulsarFunctionsNamespace(),
+                                policies);
                     } catch (PulsarAdminException e1) {
                         // prevent race condition with other workers starting up
                         if (e1.getStatusCode() != Response.Status.CONFLICT.getStatusCode()) {
@@ -110,14 +114,6 @@ public class Worker extends AbstractService {
                             throw e1;
                         }
                     }
-                    try {
-                        admin.namespaces().setRetention(
-                                workerConfig.getPulsarFunctionsNamespace(),
-                                new RetentionPolicies(Integer.MAX_VALUE, Integer.MAX_VALUE));
-                    } catch (PulsarAdminException e1) {
-                        log.error("Failed to set retention policy for pulsar functions namespace", e);
-                        throw new RuntimeException(e1);
-                    }
                 } else {
                     log.error("Failed to get retention policy for pulsar function namespace {}",
                             workerConfig.getPulsarFunctionsNamespace(), e);

-- 
To stop receiving notification emails like this one, please contact
sijie@apache.org.