You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/08/19 10:32:17 UTC
[GitHub] [camel] klease opened a new pull request #5962: CAMEL-16874: fix bug with sendEmptyMessages and pollEnrich
klease opened a new pull request #5962:
URL: https://github.com/apache/camel/pull/5962
When the file endpoint is used with option sendEmptyMessageWhenIdle=true in pollEnrich, an empty event is queued but is never read. So on the next call, even if a real file is present, the empty event is returned. The correction forces the empty event to be consumed. I also added a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] binhjy commented on pull request #5962: CAMEL-16874: fix bug with sendEmptyMessages and pollEnrich
Posted by GitBox <gi...@apache.org>.
binhjy commented on pull request #5962:
URL: https://github.com/apache/camel/pull/5962#issuecomment-1074748777
Hi @klease
I think this is exactly what I am encountering with my proj atm after upgrading camel from 2.24.2 to 3.2.0, first call pollEnrich no file so body is empty, second call pollEnrich with file but the body still empty (even I saw in the log camel still received the file), after check all using properties and removing this sendEmptyMessageWhenIdle, it works but don't know why.
I have a question: why this issue not happened with old version like 2.24.2?
Thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #5962: CAMEL-16874: fix bug with sendEmptyMessages and pollEnrich
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #5962:
URL: https://github.com/apache/camel/pull/5962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] binhjy edited a comment on pull request #5962: CAMEL-16874: fix bug with sendEmptyMessages and pollEnrich
Posted by GitBox <gi...@apache.org>.
binhjy edited a comment on pull request #5962:
URL: https://github.com/apache/camel/pull/5962#issuecomment-1074748777
Hi @klease
I think this is exactly what I am encountering with my proj atm after upgrading camel from 2.24.2 to 3.2.0, first call pollEnrich no file so body is empty, second call pollEnrich with file but the body still empty (even I saw in the log camel still received the file), after check all using properties and removing this sendEmptyMessageWhenIdle, it works but don't know why.
I have a question: why this issue not happened with old version like 2.24.2? (as I compared this file in version 2.25 vs 3.2, not much difference).
Thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] binhjy commented on pull request #5962: CAMEL-16874: fix bug with sendEmptyMessages and pollEnrich
Posted by GitBox <gi...@apache.org>.
binhjy commented on pull request #5962:
URL: https://github.com/apache/camel/pull/5962#issuecomment-1085466352
Hi @klease
Due to this issue, we have to remove the sendEmptyMessageWhenIdle=true atm
pollEnrich(xxx)
when(body().isNull())
I tested with remove sendEmptyMessageWhenIdle, it still working fine, so I am wondering what is the purpose of sendEmptyMessageWhenIdle? both sendEmptyMessageWhenIdle=true/false, the body still empty when no file, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] binhjy edited a comment on pull request #5962: CAMEL-16874: fix bug with sendEmptyMessages and pollEnrich
Posted by GitBox <gi...@apache.org>.
binhjy edited a comment on pull request #5962:
URL: https://github.com/apache/camel/pull/5962#issuecomment-1074748777
Hi @klease
I think this is exactly what I am encountering with my proj atm after upgrading camel from 2.24.2 to 3.2.0, first call pollEnrich no file so body is empty, second call pollEnrich with file but the body still empty (even I saw in the log camel still received the file), after check all using properties and removing this sendEmptyMessageWhenIdle, it works but don't know why.
I have a question: why this issue not happened with old version like 2.24.2? (as I compared this file in version 2.25 https://www.javadoc.io/doc/org.apache.camel/camel-core/2.25.2/src-html/org/apache/camel/component/file/GenericFilePollingConsumer.html#line.36 vs 3.2, not much difference).
Thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #5962: CAMEL-16874: fix bug with sendEmptyMessages and pollEnrich
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5962:
URL: https://github.com/apache/camel/pull/5962#issuecomment-901861565
there is a little bit of cleanup in the unit test file to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] binhjy edited a comment on pull request #5962: CAMEL-16874: fix bug with sendEmptyMessages and pollEnrich
Posted by GitBox <gi...@apache.org>.
binhjy edited a comment on pull request #5962:
URL: https://github.com/apache/camel/pull/5962#issuecomment-1085466352
Hi @klease
Due to this issue, we have to remove the sendEmptyMessageWhenIdle=true atm
Our route is like this:
pollEnrich(xxx)
when(body().isNull())
I tested with remove sendEmptyMessageWhenIdle, it still working fine, so I am wondering what is the purpose of sendEmptyMessageWhenIdle? both sendEmptyMessageWhenIdle=true/false, the body still empty when no file, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] klease commented on pull request #5962: CAMEL-16874: fix bug with sendEmptyMessages and pollEnrich
Posted by GitBox <gi...@apache.org>.
klease commented on pull request #5962:
URL: https://github.com/apache/camel/pull/5962#issuecomment-1083318365
Hi @binhjy,
I didn't look into the past to see where the issue arose. But it should be fixed in these versions: 3.7.6, 3.11.2 and 3.12.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org