[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #18833: [fix] [tx] Transaction buffer recover blocked by readNext

[GitBox <gi...@apache.org>]

BewareMyPower commented on code in PR #18833:
URL: https://github.com/apache/pulsar/pull/18833#discussion_r1044312124


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TopicTransactionBufferRecoverTest.java:
##########
@@ -119,18 +129,18 @@ protected void cleanup() throws Exception {
     }
 
     @DataProvider(name = "testTopic")
-    public Object[] testTopic() {
-        return new Object[] {
-                RECOVER_ABORT,
-                RECOVER_COMMIT
+    public Object[][] testTopic() {
+        return new Object[][] {
+                {RECOVER_ABORT},
+                {RECOVER_COMMIT}
         };
     }
 
     @DataProvider(name = "enableSnapshotSegment")
-    public Object[] testSnapshot() {
-        return new Boolean[] {
-                true,
-                false
+    public Object[][] testSnapshot() {
+        return new Object[][] {
+                {true},
+                {false}
         };
     }

Review Comment:
   Please avoid unnecessary changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org