You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "antovespoli (via GitHub)" <gi...@apache.org> on 2023/04/04 08:21:46 UTC
[GitHub] [flink-connector-aws] antovespoli opened a new pull request, #67: [FLINK-31675][Connectors/AWS] Update AWS SDKv2 to v2.20.32 for 3.x
antovespoli opened a new pull request, #67:
URL: https://github.com/apache/flink-connector-aws/pull/67
## Purpose of the change
AWS SDK v2 from 2.19.14 to 2.20.32
Reorder NOTICE files for consistency
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Significant changes
- [x ] Dependencies have been added or upgraded
- [ ] Public API has been changed (Public API is any class annotated with `@Public(Evolving)`)
- [ ] Serializers have been changed
- [ ] New feature has been introduced
- If yes, how is this documented? NA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] hlteoh37 commented on pull request #67: [FLINK-31675][Connectors/AWS] Update AWS SDKv2 to v2.20.32 for 3.x
Posted by "hlteoh37 (via GitHub)" <gi...@apache.org>.
hlteoh37 commented on PR #67:
URL: https://github.com/apache/flink-connector-aws/pull/67#issuecomment-1508289752
Should we change the notice files for the other SQL connectors as well? (like in https://github.com/apache/flink-connector-aws/pull/68/files)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] hlteoh37 commented on pull request #67: [FLINK-31675][Connectors/AWS] Update AWS SDKv2 to v2.20.32 for 3.x
Posted by "hlteoh37 (via GitHub)" <gi...@apache.org>.
hlteoh37 commented on PR #67:
URL: https://github.com/apache/flink-connector-aws/pull/67#issuecomment-1519888859
Could we merge into 1 commit please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] dannycranmer merged pull request #67: [FLINK-31675][Connectors/AWS] Update AWS SDKv2 to v2.20.32 for 3.x
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer merged PR #67:
URL: https://github.com/apache/flink-connector-aws/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] hlteoh37 commented on a diff in pull request #67: [FLINK-31675][Connectors/AWS] Update AWS SDKv2 to v2.20.32 for 3.x
Posted by "hlteoh37 (via GitHub)" <gi...@apache.org>.
hlteoh37 commented on code in PR #67:
URL: https://github.com/apache/flink-connector-aws/pull/67#discussion_r1175108409
##########
flink-sql-connector-dynamodb/src/main/resources/META-INF/NOTICE:
##########
@@ -7,26 +7,26 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
-- software.amazon.awssdk:utils:2.19.14
-- software.amazon.awssdk:third-party-jackson-core:2.19.14
-- software.amazon.awssdk:sts:2.19.14
-- software.amazon.awssdk:sdk-core:2.19.14
-- software.amazon.awssdk:regions:2.19.14
-- software.amazon.awssdk:protocol-core:2.19.14
-- software.amazon.awssdk:profiles:2.19.14
-- software.amazon.awssdk:netty-nio-client:2.19.14
-- software.amazon.awssdk:metrics-spi:2.19.14
-- software.amazon.awssdk:json-utils:2.19.14
-- software.amazon.awssdk:http-client-spi:2.19.14
-- software.amazon.awssdk:endpoints-spi:2.19.14
-- software.amazon.awssdk:dynamodb:2.19.14
-- software.amazon.awssdk:dynamodb-enhanced:2.19.14
-- software.amazon.awssdk:aws-query-protocol:2.19.14
-- software.amazon.awssdk:aws-json-protocol:2.19.14
-- software.amazon.awssdk:aws-core:2.19.14
-- software.amazon.awssdk:auth:2.19.14
-- software.amazon.awssdk:apache-client:2.19.14
-- software.amazon.awssdk:annotations:2.19.14
+- software.amazon.awssdk:utils:2.20.32
Review Comment:
Verified ok from build output
```
[INFO] --- maven-shade-plugin:3.1.1:shade (shade-flink) @ flink-sql-connector-dynamodb ---
[INFO] Including org.apache.flink:flink-connector-dynamodb:jar:3.0-SNAPSHOT in the shaded jar.
[INFO] Including org.apache.flink:flink-connector-base:jar:1.16.0 in the shaded jar.
[INFO] Including org.apache.flink:flink-connector-aws-base:jar:1.16.0 in the shaded jar.
[INFO] Including software.amazon.awssdk:netty-nio-client:jar:2.20.32 in the shaded jar.
[INFO] Including io.netty:netty-codec-http:jar:4.1.86.Final in the shaded jar.
[INFO] Including io.netty:netty-codec-http2:jar:4.1.86.Final in the shaded jar.
[INFO] Including io.netty:netty-codec:jar:4.1.86.Final in the shaded jar.
[INFO] Including io.netty:netty-transport:jar:4.1.86.Final in the shaded jar.
[INFO] Including io.netty:netty-resolver:jar:4.1.86.Final in the shaded jar.
[INFO] Including io.netty:netty-common:jar:4.1.86.Final in the shaded jar.
[INFO] Including io.netty:netty-buffer:jar:4.1.86.Final in the shaded jar.
[INFO] Including io.netty:netty-handler:jar:4.1.86.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-native-unix-common:jar:4.1.86.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-classes-epoll:jar:4.1.86.Final in the shaded jar.
[INFO] Including org.reactivestreams:reactive-streams:jar:1.0.3 in the shaded jar.
[INFO] Including software.amazon.awssdk:sts:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-query-protocol:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:dynamodb:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-json-protocol:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:third-party-jackson-core:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:protocol-core:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:profiles:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:sdk-core:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:auth:jar:2.20.32 in the shaded jar.
[INFO] Excluding software.amazon.eventstream:eventstream:jar:1.0.1 from the shaded jar.
[INFO] Including software.amazon.awssdk:http-client-spi:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:regions:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:annotations:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:utils:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-core:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:metrics-spi:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:json-utils:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:endpoints-spi:jar:2.20.32 in the shaded jar.
[INFO] Including software.amazon.awssdk:apache-client:jar:2.20.32 in the shaded jar.
[INFO] Including org.apache.httpcomponents:httpclient:jar:4.5.13 in the shaded jar.
[INFO] Including commons-logging:commons-logging:jar:1.2 in the shaded jar.
[INFO] Including org.apache.httpcomponents:httpcore:jar:4.4.13 in the shaded jar.
[INFO] Including commons-codec:commons-codec:jar:1.15 in the shaded jar.
[INFO] Including software.amazon.awssdk:dynamodb-enhanced:jar:2.20.32 in the shaded jar.
[INFO] Excluding org.apache.flink:flink-shaded-force-shading:jar:16.0 from the shaded jar.
[INFO] Excluding org.slf4j:slf4j-api:jar:1.7.36 from the shaded jar.
[INFO] No artifact matching filter io.netty:netty
[INFO] Replacing original artifact with shaded artifact.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] boring-cyborg[bot] commented on pull request #67: [FLINK-31675][Connectors/AWS] Update AWS SDKv2 to v2.20.32 for 3.x
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #67:
URL: https://github.com/apache/flink-connector-aws/pull/67#issuecomment-1523521621
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org