You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Prabhjyot Singh <pr...@gmail.com> on 2018/01/02 19:18:19 UTC
Review Request 64894: zeppelin.livy.url is not getting updated after
moving livy to a new host
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64894/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
Bugs: AMBARI-22716
https://issues.apache.org/jira/browse/AMBARI-22716
Repository: ambari
Description
-------
zeppelin.livy.url is not getting updated after moving livy to a new host
Steps to reproduce :
1) Create a cluster with both Spark and Spark2 component
2) Delete livy component from current host.
3) Add the livy component on a new host
4) Restart zeppelin server.
5) Now check the zeppelin interpreter settings. zeppelin.livy.url is still referring to older livy host.
Its not reflecting the new livy server address.
Note 1 : If I restart zeppelin server after step1 (ie after deleting the livy host) before performing rest of the steps, then changes are getting reflected properly. System test was mistakenly doing this step so didn't fail during nightly run
Note 2 : Issue is happening only when both Spark and Spark2 are installed. If cluster contains only Spark2, this feature works as expected.
Issue is coming if I add Spark(version 1) to it.
Diffs
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py efa3ffe3ba
ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py f5027b2aee
Diff: https://reviews.apache.org/r/64894/diff/1/
Testing
-------
Manually tested on CentOS 6
Thanks,
Prabhjyot Singh
Re: Review Request 64894: zeppelin.livy.url is not getting updated
after moving livy to a new host
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64894/#review194645
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
Lines 397 (patched)
<https://reviews.apache.org/r/64894/#comment273559>
Maybe just comment on why this is needed ...
- Jonathan Hurley
On Jan. 2, 2018, 2:18 p.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64894/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2018, 2:18 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
>
>
> Bugs: AMBARI-22716
> https://issues.apache.org/jira/browse/AMBARI-22716
>
>
> Repository: ambari
>
>
> Description
> -------
>
> zeppelin.livy.url is not getting updated after moving livy to a new host
>
> Steps to reproduce :
> 1) Create a cluster with both Spark and Spark2 component
> 2) Delete livy component from current host.
> 3) Add the livy component on a new host
> 4) Restart zeppelin server.
> 5) Now check the zeppelin interpreter settings. zeppelin.livy.url is still referring to older livy host.
> Its not reflecting the new livy server address.
>
> Note 1 : If I restart zeppelin server after step1 (ie after deleting the livy host) before performing rest of the steps, then changes are getting reflected properly. System test was mistakenly doing this step so didn't fail during nightly run
>
> Note 2 : Issue is happening only when both Spark and Spark2 are installed. If cluster contains only Spark2, this feature works as expected.
> Issue is coming if I add Spark(version 1) to it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py efa3ffe3ba
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py f5027b2aee
>
>
> Diff: https://reviews.apache.org/r/64894/diff/1/
>
>
> Testing
> -------
>
> Manually tested on CentOS 6
>
>
> File Attachments
> ----------------
>
> 0AMBARI-22716_branch-2.6_v1.patch
> https://reviews.apache.org/media/uploaded/files/2018/01/02/2c206e6b-759d-4f94-899d-8d595e29832c__0AMBARI-22716_branch-2.6_v1.patch
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 64894: zeppelin.livy.url is not getting updated
after moving livy to a new host
Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64894/
-----------------------------------------------------------
(Updated Jan. 3, 2018, 1:11 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
Bugs: AMBARI-22716
https://issues.apache.org/jira/browse/AMBARI-22716
Repository: ambari
Description
-------
zeppelin.livy.url is not getting updated after moving livy to a new host
Steps to reproduce :
1) Create a cluster with both Spark and Spark2 component
2) Delete livy component from current host.
3) Add the livy component on a new host
4) Restart zeppelin server.
5) Now check the zeppelin interpreter settings. zeppelin.livy.url is still referring to older livy host.
Its not reflecting the new livy server address.
Note 1 : If I restart zeppelin server after step1 (ie after deleting the livy host) before performing rest of the steps, then changes are getting reflected properly. System test was mistakenly doing this step so didn't fail during nightly run
Note 2 : Issue is happening only when both Spark and Spark2 are installed. If cluster contains only Spark2, this feature works as expected.
Issue is coming if I add Spark(version 1) to it.
Diffs
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py efa3ffe3ba
ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py f5027b2aee
Diff: https://reviews.apache.org/r/64894/diff/2/
Testing
-------
Manually tested on CentOS 6
File Attachments (updated)
----------------
0AMBARI-22716_branch-2.6_v1.patch
https://reviews.apache.org/media/uploaded/files/2018/01/02/2c206e6b-759d-4f94-899d-8d595e29832c__0AMBARI-22716_branch-2.6_v1.patch
0AMBARI-22716_branch-2.6_v2.patch
https://reviews.apache.org/media/uploaded/files/2018/01/02/4bf2c460-c5cd-443a-a0ce-80357ec5bd93__0AMBARI-22716_branch-2.6_v2.patch
Thanks,
Prabhjyot Singh
Re: Review Request 64894: zeppelin.livy.url is not getting updated
after moving livy to a new host
Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64894/
-----------------------------------------------------------
(Updated Jan. 3, 2018, 1:10 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
Bugs: AMBARI-22716
https://issues.apache.org/jira/browse/AMBARI-22716
Repository: ambari
Description
-------
zeppelin.livy.url is not getting updated after moving livy to a new host
Steps to reproduce :
1) Create a cluster with both Spark and Spark2 component
2) Delete livy component from current host.
3) Add the livy component on a new host
4) Restart zeppelin server.
5) Now check the zeppelin interpreter settings. zeppelin.livy.url is still referring to older livy host.
Its not reflecting the new livy server address.
Note 1 : If I restart zeppelin server after step1 (ie after deleting the livy host) before performing rest of the steps, then changes are getting reflected properly. System test was mistakenly doing this step so didn't fail during nightly run
Note 2 : Issue is happening only when both Spark and Spark2 are installed. If cluster contains only Spark2, this feature works as expected.
Issue is coming if I add Spark(version 1) to it.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py efa3ffe3ba
ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py f5027b2aee
Diff: https://reviews.apache.org/r/64894/diff/2/
Changes: https://reviews.apache.org/r/64894/diff/1-2/
Testing
-------
Manually tested on CentOS 6
File Attachments
----------------
0AMBARI-22716_branch-2.6_v1.patch
https://reviews.apache.org/media/uploaded/files/2018/01/02/2c206e6b-759d-4f94-899d-8d595e29832c__0AMBARI-22716_branch-2.6_v1.patch
Thanks,
Prabhjyot Singh
Re: Review Request 64894: zeppelin.livy.url is not getting updated
after moving livy to a new host
Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64894/
-----------------------------------------------------------
(Updated Jan. 3, 2018, 12:48 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
Bugs: AMBARI-22716
https://issues.apache.org/jira/browse/AMBARI-22716
Repository: ambari
Description
-------
zeppelin.livy.url is not getting updated after moving livy to a new host
Steps to reproduce :
1) Create a cluster with both Spark and Spark2 component
2) Delete livy component from current host.
3) Add the livy component on a new host
4) Restart zeppelin server.
5) Now check the zeppelin interpreter settings. zeppelin.livy.url is still referring to older livy host.
Its not reflecting the new livy server address.
Note 1 : If I restart zeppelin server after step1 (ie after deleting the livy host) before performing rest of the steps, then changes are getting reflected properly. System test was mistakenly doing this step so didn't fail during nightly run
Note 2 : Issue is happening only when both Spark and Spark2 are installed. If cluster contains only Spark2, this feature works as expected.
Issue is coming if I add Spark(version 1) to it.
Diffs
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py efa3ffe3ba
ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py f5027b2aee
Diff: https://reviews.apache.org/r/64894/diff/1/
Testing
-------
Manually tested on CentOS 6
File Attachments (updated)
----------------
0AMBARI-22716_branch-2.6_v1.patch
https://reviews.apache.org/media/uploaded/files/2018/01/02/2c206e6b-759d-4f94-899d-8d595e29832c__0AMBARI-22716_branch-2.6_v1.patch
Thanks,
Prabhjyot Singh