[GitHub] [tvm] jwfromm commented on a change in pull request #9678: Fix for tvm.build()'s name warning

[GitBox <gi...@apache.org>]

jwfromm commented on a change in pull request #9678:
URL: https://github.com/apache/tvm/pull/9678#discussion_r765274865



##########
File path: python/tvm/driver/build_module.py
##########
@@ -93,7 +93,7 @@ def schedule_to_module(
 def lower(
     inp: Union[schedule.Schedule, PrimFunc, IRModule],
     args: Optional[List[Union[Buffer, tensor.Tensor, Var]]] = None,
-    name: str = "main",
+    name: str = None,

Review comment:
       I think this might break a lot of things. "main" is used quite often as the default Function name in IRModules and I expect it'll show up in a lot of tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org