You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/06 16:26:50 UTC
[GitHub] [pulsar] xuesong172500 opened a new pull request #7774: fix bug: https://github.com/apache/pulsar/issues/7706
xuesong172500 opened a new pull request #7774:
URL: https://github.com/apache/pulsar/pull/7774
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes
https://github.com/apache/pulsar/issues/7706
Master Issue: #<xyz>
### Motivation
Pulsar-Proxy/Pulsar-Discovery-Service No active broker is available
### Modifications
Change zookeeper getValue interface
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] massakam closed pull request #7774: fix bug: https://github.com/apache/pulsar/issues/7706
Posted by GitBox <gi...@apache.org>.
massakam closed pull request #7774:
URL: https://github.com/apache/pulsar/pull/7774
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] massakam commented on pull request #7774: fix bug: https://github.com/apache/pulsar/issues/7706
Posted by GitBox <gi...@apache.org>.
massakam commented on pull request #7774:
URL: https://github.com/apache/pulsar/pull/7774#issuecomment-673206865
If #7690 has already solved the issue, I will close this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] xuesong172500 commented on pull request #7774: fix bug: https://github.com/apache/pulsar/issues/7706
Posted by GitBox <gi...@apache.org>.
xuesong172500 commented on pull request #7774:
URL: https://github.com/apache/pulsar/pull/7774#issuecomment-673197785
I tested the code of PR #7690 and solved the issues #7706. The PR #7774 submitted by me can also solve the problems of pulsar proxy and pulsar discovery service modules, so please decide which PR to use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] xuesong172500 commented on pull request #7774: fix bug: https://github.com/apache/pulsar/issues/7706
Posted by GitBox <gi...@apache.org>.
xuesong172500 commented on pull request #7774:
URL: https://github.com/apache/pulsar/pull/7774#issuecomment-672545569
Yes, I submitted the code one day later than the latest code in the master branch. I passed the test on the old code, but did not merge and retest the latest code of the master branch.
daxia_xue@126.com
From: Masahiro Sakamoto
Date: 2020-08-12 10:57
To: apache/pulsar
CC: xuesong172500; Assign
Subject: Re: [apache/pulsar] fix bug: https://github.com/apache/pulsar/issues/7706 (#7774)
Changes in #7690 seem to be reverted. Is this intentional?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] massakam commented on pull request #7774: fix bug: https://github.com/apache/pulsar/issues/7706
Posted by GitBox <gi...@apache.org>.
massakam commented on pull request #7774:
URL: https://github.com/apache/pulsar/pull/7774#issuecomment-672529124
Changes in https://github.com/apache/pulsar/pull/7690 seem to be reverted. Is this intentional?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] xuesong172500 commented on pull request #7774: fix bug: https://github.com/apache/pulsar/issues/7706
Posted by GitBox <gi...@apache.org>.
xuesong172500 commented on pull request #7774:
URL: https://github.com/apache/pulsar/pull/7774#issuecomment-672630913
Yes, I will fork the master branch again and submit a new pull request.
daxia_xue@126.com
From: Masahiro Sakamoto
Date: 2020-08-12 13:12
To: apache/pulsar
CC: xuesong172500; Assign
Subject: Re: [apache/pulsar] fix bug: https://github.com/apache/pulsar/issues/7706 (#7774)
If we revert #7690 changes, the deadlock issue will reappear, so we should not it. Can the issue of #7706 be reproduced on the master branch? If so, could you fix the code in the master branch?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] massakam commented on pull request #7774: fix bug: https://github.com/apache/pulsar/issues/7706
Posted by GitBox <gi...@apache.org>.
massakam commented on pull request #7774:
URL: https://github.com/apache/pulsar/pull/7774#issuecomment-672578813
If we revert #7690 changes, the deadlock issue will reappear, so we should not it. Can the issue of #7706 be reproduced on the master branch? If so, could you fix the code in the master branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org