You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/17 14:10:18 UTC
[GitHub] [incubator-seatunnel] liugddx opened a new pull request, #2770: Improve jdbc connector. change the jdbc driver scope to provider
liugddx opened a new pull request, #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
change the jdbc driver scope to provider
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#discussion_r975543747
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-jdbc-flink-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcDmdbIT.java:
##########
@@ -144,4 +145,9 @@ public void testJdbcDmdbSourceAndSink() throws IOException, InterruptedException
assertHasData(SINK_TABLE);
}
+ @Override
+ protected void executeExtraCommands(GenericContainer<?> container) throws IOException, InterruptedException {
+ Container.ExecResult extraCommands = container.execInContainer("bash", "-c", "mkdir -p /tmp/seatunnel/plugins/Jdbc/lib && cd /tmp/flink/seatunnel/plugins/Jdbc/lib && curl -O " + THIRD_PARTY_PLUGINS_URL);
Review Comment:
Other similar code in this PR is handled like this:
```suggestion
Container.ExecResult extraCommands = container.execInContainer("bash", "-c", "mkdir -p /tmp/seatunnel/plugins/Jdbc/lib && cd /tmp/seatunnel/plugins/Jdbc/lib && curl -O " + THIRD_PARTY_PLUGINS_URL);
```
To support multiple engines, I unified the Seatunnel Home(`/tmp/seatunnel`) without engine prefixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#issuecomment-1260321461
@TyrantLucifer PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#issuecomment-1253138526
@ashulin i fixed those problems, and PTAL again ,thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#discussion_r979533648
##########
seatunnel-e2e/pom.xml:
##########
@@ -40,6 +40,17 @@
<junit4.version>4.13.2</junit4.version>
<maven-jar-plugin.version>2.4</maven-jar-plugin.version>
</properties>
+ <dependencyManagement>
Review Comment:
Why e2e root pom need add `connector-jdbc`'s dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#issuecomment-1260290566
please rerun CI. @EricJoy2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin merged pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
ashulin merged PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#issuecomment-1258926952
> LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#discussion_r979597547
##########
seatunnel-e2e/pom.xml:
##########
@@ -40,6 +40,17 @@
<junit4.version>4.13.2</junit4.version>
<maven-jar-plugin.version>2.4</maven-jar-plugin.version>
</properties>
+ <dependencyManagement>
Review Comment:
You need fixed ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#issuecomment-1250215401
subtask of #2642 .change the jdbc driver scope to provider and improve the jdbc connector doc.
PTAL @ashulin @Hisoka-X @TyrantLucifer thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#discussion_r975333532
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-jdbc-flink-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcPhoenixIT.java:
##########
@@ -177,4 +178,10 @@ private void batchInsertData() throws SQLException, ClassNotFoundException {
throw e;
}
}
+
+ @Override
+ protected void executeExtraCommands(GenericContainer<?> container) throws IOException, InterruptedException {
+ Container.ExecResult extraCommands = container.execInContainer("bash", "-c", "mkdir -p /tmp/flink/seatunnel/plugins/Jdbc/lib && cd /tmp/flink/seatunnel/plugins/Jdbc/lib && curl -O " + THIRD_PARTY_PLUGINS_URL);
Review Comment:
as above
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-jdbc-flink-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcDmdbIT.java:
##########
@@ -144,4 +145,9 @@ public void testJdbcDmdbSourceAndSink() throws IOException, InterruptedException
assertHasData(SINK_TABLE);
}
+ @Override
+ protected void executeExtraCommands(GenericContainer<?> container) throws IOException, InterruptedException {
+ Container.ExecResult extraCommands = container.execInContainer("bash", "-c", "mkdir -p /tmp/flink/seatunnel/plugins/Jdbc/lib && cd /tmp/flink/seatunnel/plugins/Jdbc/lib && curl -O " + THIRD_PARTY_PLUGINS_URL);
Review Comment:
Use dir `/tmp/seatunnel/plugins/`?
reference
#2762
##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/connector-jdbc-spark-e2e/src/test/java/org/apache/seatunnel/e2e/spark/v2/jdbc/JdbcPhoenixIT.java:
##########
@@ -177,4 +178,10 @@ private void batchInsertData() throws SQLException, ClassNotFoundException {
throw e;
}
}
+
+ @Override
+ protected void executeExtraCommands(GenericContainer<?> container) throws IOException, InterruptedException {
+ Container.ExecResult extraCommands = container.execInContainer("bash", "-c", "mkdir -p /tmp/spark/seatunnel/plugins/Jdbc/lib && cd /tmp/spark/seatunnel/plugins/Jdbc/lib && curl -O " + THIRD_PARTY_PLUGINS_URL);
Review Comment:
as above
##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/connector-jdbc-spark-e2e/src/test/java/org/apache/seatunnel/e2e/spark/v2/jdbc/JdbcDmdbIT.java:
##########
@@ -148,4 +148,10 @@ public void testDMDBSourceToJdbcSink() throws SQLException, IOException, Interru
assertHasData(SINK_TABLE);
}
+ @Override
+ protected void executeExtraCommands(GenericContainer<?> container) throws IOException, InterruptedException {
+ Container.ExecResult extraCommands = container.execInContainer("bash", "-c", "mkdir -p /tmp/spark/seatunnel/plugins/Jdbc/lib && cd /tmp/spark/seatunnel/plugins/Jdbc/lib && curl -O " + THIRD_PARTY_PLUGINS_URL);
Review Comment:
as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
ic4y commented on PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#issuecomment-1257353330
Need to add driver package download for all JDBC inheritance tests
E.g XaGroupOpsImplIT.testRecoverAndRollback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
liugddx commented on code in PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#discussion_r979602264
##########
seatunnel-e2e/pom.xml:
##########
@@ -40,6 +40,17 @@
<junit4.version>4.13.2</junit4.version>
<maven-jar-plugin.version>2.4</maven-jar-plugin.version>
</properties>
+ <dependencyManagement>
Review Comment:
>
mysql and postgres e2e fail.and i have fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#issuecomment-1254444817
@ashulin @TyrantLucifer @CalvinKirs @Hisoka-X @EricJoy2048 PTAL thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 closed pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
EricJoy2048 closed pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
URL: https://github.com/apache/incubator-seatunnel/pull/2770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
liugddx commented on code in PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#discussion_r979595124
##########
seatunnel-e2e/pom.xml:
##########
@@ -40,6 +40,17 @@
<junit4.version>4.13.2</junit4.version>
<maven-jar-plugin.version>2.4</maven-jar-plugin.version>
</properties>
+ <dependencyManagement>
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#issuecomment-1252418206
PTAL @hailin0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#discussion_r975533655
##########
docs/en/connector-v2/sink/Jdbc.md:
##########
@@ -84,6 +84,7 @@ there are some reference value for params above.
| mysql | com.mysql.cj.jdbc.Driver | jdbc:mysql://localhost:3306/test | com.mysql.cj.jdbc.MysqlXADataSource | https://mvnrepository.com/artifact/mysql/mysql-connector-java |
| postgresql | org.postgresql.Driver | jdbc:postgresql://localhost:5432/postgres | org.postgresql.xa.PGXADataSource | https://mvnrepository.com/artifact/org.postgresql/postgresql | |
| dm | dm.jdbc.driver.DmDriver | jdbc:dm://localhost:5236 | dm.jdbc.driver.DmdbXADataSource | https://mvnrepository.com/artifact/com.dameng/DmJdbcDriver18 |
+| phoenix | org.apache.phoenix.queryserver.client.Driver | jdbc:phoenix:thin:url=http://localhost:8765;serialization=PROTOBUF | / | https://mvnrepository.com/artifact/com.aliyun.phoenix/ali-phoenix-shaded-thin-client |
Review Comment:
check markdown style
##########
seatunnel-connectors-v2/connector-jdbc/pom.xml:
##########
@@ -29,13 +29,6 @@
<artifactId>connector-jdbc</artifactId>
- <properties>
- <phoenix.version>5.2.5-HBase-2.x</phoenix.version>
- <mysql.version>8.0.16</mysql.version>
- <postgresql.version>42.3.3</postgresql.version>
- <dm-jdbc.version>8.1.2.141</dm-jdbc.version>
- </properties>
-
Review Comment:
Don‘t manage the properties of the connector in root pom.xml
That's my suggestion:
```xml
<properties>
<phoenix.version>5.2.5-HBase-2.x</phoenix.version>
<mysql.version>8.0.16</mysql.version>
<postgresql.version>42.3.3</postgresql.version>
<dm-jdbc.version>8.1.2.141</dm-jdbc.version>
</properties>
<dependencies>
<dependency>
<groupId>com.aliyun.phoenix</groupId>
<artifactId>ali-phoenix-shaded-thin-client</artifactId>
</dependency>
</dependencies>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>com.aliyun.phoenix</groupId>
<artifactId>ali-phoenix-shaded-thin-client</artifactId>
<version>${phoenix.version}</version>
</dependency>
</dependencies>
</dependencyManagement>
```
This is then used in the E2E module
```xml
<dependencies>
<dependency>
<groupId>com.aliyun.phoenix</groupId>
<artifactId>ali-phoenix-shaded-thin-client</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.apache.seatunnel</groupId>
<artifactId>connector-jdbc</artifactId>
<version>${project.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
```
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-jdbc-flink-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcDmdbIT.java:
##########
@@ -144,4 +145,9 @@ public void testJdbcDmdbSourceAndSink() throws IOException, InterruptedException
assertHasData(SINK_TABLE);
}
+ @Override
+ protected void executeExtraCommands(GenericContainer<?> container) throws IOException, InterruptedException {
+ Container.ExecResult extraCommands = container.execInContainer("bash", "-c", "mkdir -p /tmp/seatunnel/plugins/Jdbc/lib && cd /tmp/flink/seatunnel/plugins/Jdbc/lib && curl -O " + THIRD_PARTY_PLUGINS_URL);
Review Comment:
Other similar code in this PR is handled like this:
```suggestion
Container.ExecResult extraCommands = container.execInContainer("bash", "-c", "mkdir -p /tmp/seatunnel/plugins/Jdbc/lib && cd /tmp/seatunnel/plugins/Jdbc/lib && curl -O " + THIRD_PARTY_PLUGINS_URL);
```
To support multiple engines, I unified the Seatunnel Home(`/tmp/seatunnel`) without requiring engine prefixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#discussion_r976247259
##########
seatunnel-connectors-v2/connector-jdbc/pom.xml:
##########
@@ -30,12 +30,40 @@
<artifactId>connector-jdbc</artifactId>
<properties>
- <phoenix.version>5.2.5-HBase-2.x</phoenix.version>
<mysql.version>8.0.16</mysql.version>
<postgresql.version>42.3.3</postgresql.version>
<dm-jdbc.version>8.1.2.141</dm-jdbc.version>
+ <phoenix.version>5.2.5-HBase-2.x</phoenix.version>
</properties>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>com.aliyun.phoenix</groupId>
+ <artifactId>ali-phoenix-shaded-thin-client</artifactId>
+ <version>${phoenix.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>mysql</groupId>
+ <artifactId>mysql-connector-java</artifactId>
+ <version>${mysql.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.postgresql</groupId>
+ <artifactId>postgresql</artifactId>
+ <version>${postgresql.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>com.dameng</groupId>
+ <artifactId>DmJdbcDriver18</artifactId>
+ <version>${dm-jdbc.version}</version>
+ </dependency>
Review Comment:
```suggestion
<dependency>
<groupId>com.dameng</groupId>
<artifactId>DmJdbcDriver18</artifactId>
<version>${dm-jdbc.version}</version>
<scope>provided</scope>
</dependency>
```
Then delete version from <version># line83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#issuecomment-1257412391
Done. @ic4y .please rerun CI
@EricJoy2048 thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#discussion_r979588978
##########
seatunnel-e2e/pom.xml:
##########
@@ -40,6 +40,17 @@
<junit4.version>4.13.2</junit4.version>
<maven-jar-plugin.version>2.4</maven-jar-plugin.version>
</properties>
+ <dependencyManagement>
Review Comment:
Just import it in `seatunnel-flink-connector-v2-e2e/connector-jdbc-flink-e2e` and `seatunnel-spark-connector-v2-e2e/connector-jdbc-spark-e2e`, not here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#issuecomment-1256966465
@TyrantLucifer @EricJoy2048 PTAL thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
Posted by GitBox <gi...@apache.org>.
liugddx commented on code in PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#discussion_r979544182
##########
seatunnel-e2e/pom.xml:
##########
@@ -40,6 +40,17 @@
<junit4.version>4.13.2</junit4.version>
<maven-jar-plugin.version>2.4</maven-jar-plugin.version>
</properties>
+ <dependencyManagement>
Review Comment:
The driver jar is used by connector and e2e,so i want a unified version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org