You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/14 18:16:15 UTC
[GitHub] [arrow] jonkeane opened a new pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
jonkeane opened a new pull request #12422:
URL: https://github.com/apache/arrow/pull/12422
Adds a crossbow build that builds libarrow with `CMAKE_BUILT_TYPE=MinSizeRel` and runs the R tests on that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1050369040
@github-actions crossbow submit test-r-minsizerel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039521141
It's a bit hidden by the way the tests are run, but the `Dump test logs` still has: https://github.com/ursacomputing/crossbow/runs/5189845009?check_suite_focus=true#step:10:8126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039523955
Ok, I see. If this is the same crash as you got locally, then I'm inclined to think it's a compiler bug where clang emits a BMI2 instruction even though only `-msse4.2` is given on the command line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1040122492
Revision: 7b90730f2435819abe4e31d9c978a17d4b0e14ef
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1635](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1635)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1635-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1052208004
Revision: 7900fa728cc688b88f47bc44b923740b526a880c
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1686](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1686)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1686-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039519465
@jonkeane There is no traceback displayed anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039440121
@github-actions crossbow submit test-r-minsizerel
with ARROW_R_DEV globally so that it is set when the tests run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1040072456
Revision: 1969bc739c9f54a072512122ca33cd0a30ebc596
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1634](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1634)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1634-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1051278800
Revision: 5d0f404d5a23cad621bb72cc92fedd42bd121da7
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1684](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1684)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1684-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1040301559
@github-actions crossbow submit test-r-minsizerel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039403903
Revision: d69929ab5f51845e31f0c0a7054aeeccbe24c9c9
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1629](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1629)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1629-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1040309320
Revision: 5e81c0823df0b79274332e39e9b7d4479b8996c2
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1637](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1637)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1637-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1050878059
Revision: ffe6725f18ce663ddd550f067cb8db06abbfa6dc
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1681](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1681)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1681-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1052206519
@github-actions crossbow submit test-r-minsizerel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039441192
Revision: 3d900698379407c1bfc7c8cf47ac37ac9a0f7816
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1632](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1632)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1632-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1040308175
@github-actions crossbow submit test-r-minsizerel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039519465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane removed a comment on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane removed a comment on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039402571
@github-actions crossbow submit test-r-minsizerel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039484760
Revision: 2391edfb1bd5739da4efce6cb129f20fafee0949
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1633](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1633)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1633-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane edited a comment on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane edited a comment on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039521141
It's a bit hidden by the way the tests are run, but the `Dump test logs` still has: https://github.com/ursacomputing/crossbow/runs/5189845009?check_suite_focus=true#step:10:8126
Which also now includes `arrow_info()` too: https://github.com/ursacomputing/crossbow/runs/5189845009?check_suite_focus=true#step:10:98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1051278049
@github-actions crossbow submit test-r-minsizerel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039403903
Revision: d69929ab5f51845e31f0c0a7054aeeccbe24c9c9
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1629](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1629)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1629-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1040302864
Revision: d1c635168e43e8011c0a2779f7046252d3d46dde
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1636](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1636)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1636-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1040121426
@github-actions crossbow submit test-r-minsizerel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#discussion_r806118922
##########
File path: dev/tasks/tasks.yml
##########
@@ -1252,6 +1252,12 @@ tasks:
ci: github
template: r/github.linux.offline.build.yml
+ test-r-minsizerel:
+ ci: github
+ template: r/github.macos-linux.local.yml
Review comment:
This builds on macos + linux, which isn't strictly necessary for triggering what we're trying to trigger, but might be worth checking both linux + macos anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039402676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#discussion_r806118341
##########
File path: r/tests/testthat.R
##########
@@ -20,6 +20,8 @@ library(arrow)
library(tibble)
if (identical(tolower(Sys.getenv("ARROW_R_DEV", "false")), "true")) {
+ arrow::arrow_info()
+
Review comment:
This might be helpful in debugging. We can remove it before we merge this, though it should only impact our CI builds and maybe it's good/fine to keep it around?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039403903
Revision: d69929ab5f51845e31f0c0a7054aeeccbe24c9c9
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1629](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1629)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1629-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039409436
Revision: 1e0ecc4f4c07fb8dd08bec085efb7cda6871b305
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1631](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1631)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1631-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039408273
@github-actions crossbow submit test-r-minsizerel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#discussion_r806969469
##########
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##########
@@ -642,6 +642,9 @@ elseif("${CMAKE_BUILD_TYPE}" STREQUAL "PROFILE_GEN")
elseif("${CMAKE_BUILD_TYPE}" STREQUAL "PROFILE_BUILD")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${C_FLAGS_PROFILE_BUILD}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_FLAGS_PROFILE_BUILD}")
+elseif("${CMAKE_BUILD_TYPE}" STREQUAL "MINSIZEREL")
+ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${C_FLAGS_MINSIZEREL}")
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_FLAGS_MINSIZEREL}")
Review comment:
Can you make a separate (presumably minor) PR for this change + the arrow_info() addition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane edited a comment on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane edited a comment on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039521141
It's a bit hidden by the way the tests are run, but the `Dump test logs` still has: https://github.com/ursacomputing/crossbow/runs/5189845009?check_suite_focus=true#step:10:8126
Which also now includes `arrow_info()` too: https://github.com/ursacomputing/crossbow/runs/5189845009?check_suite_focus=true#step:10:98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1050877121
@github-actions crossbow submit test-r-minsizerel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1050369625
Revision: 20ca138cc08d0a2833ed98b37a51d07f23f3dd51
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1679](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1679)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1679-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039483683
@github-actions crossbow submit test-r-minsizerel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039402571
@github-actions crossbow submit test-r-minsizerel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039589243
Yup, that's the same place I saw locally.
If it helps, here's the stack trace + disassembly from when when I triggered it locally as well:
```
2491 Thread_829819
+ 2491 thread_start (in libsystem_pthread.dylib) + 15 [0x7ff801c3e00f]
+ 2491 _pthread_start (in libsystem_pthread.dylib) + 125 [0x7ff801c424f4]
+ 2491 void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, arrow::internal::ThreadPool::LaunchWorkersUnlocked(int)::$_3> >(void*) (in arrow.so) + 380 [0x109203749]
+ 2491 arrow::internal::FnOnce<void ()>::operator()() && (in arrow.so) + 26 [0x109201f30]
+ 2491 arrow::internal::FnOnce<void ()>::FnImpl<std::__1::__bind<arrow::detail::ContinueFuture, arrow::Future<std::__1::shared_ptr<arrow::ChunkedArray> >&, parquet::arrow::(anonymous namespace)::FileReaderImpl::DecodeRowGroups(std::__1::shared_ptr<parquet::arrow::(anonymous namespace)::FileReaderImpl>, std::__1::vector<int, std::__1::allocator<int> > const&, std::__1::vector<int, std::__1::allocator<int> > const&, arrow::internal::Executor*)::$_4&, unsigned long&, std::__1::shared_ptr<parquet::arrow::ColumnReaderImpl> > >::invoke() (in arrow.so) + 98 [0x108f125c2]
+ 2491 parquet::arrow::(anonymous namespace)::FileReaderImpl::DecodeRowGroups(std::__1::shared_ptr<parquet::arrow::(anonymous namespace)::FileReaderImpl>, std::__1::vector<int, std::__1::allocator<int> > const&, std::__1::vector<int, std::__1::allocator<int> > const&, arrow::internal::Executor*)::$_4::operator()(unsigned long, std::__1::shared_ptr<parquet::arrow::ColumnReaderImpl>) const (in arrow.so) + 47 [0x108f11ed5]
+ 2491 parquet::arrow::(anonymous namespace)::FileReaderImpl::ReadColumn(int, std::__1::vector<int, std::__1::allocator<int> > const&, parquet::arrow::ColumnReader*, std::__1::shared_ptr<arrow::ChunkedArray>*) (in arrow.so) + 273 [0x108f0c037]
+ 2491 parquet::arrow::ColumnReaderImpl::NextBatch(long long, std::__1::shared_ptr<arrow::ChunkedArray>*) (in arrow.so) + 39 [0x108f0733b]
+ 2491 parquet::arrow::(anonymous namespace)::LeafReader::LoadBatch(long long) (in arrow.so) + 137 [0x108f0794b]
+ 2491 parquet::internal::(anonymous namespace)::TypedRecordReader<parquet::PhysicalType<(parquet::Type::type)1> >::ReadRecords(long long) (in arrow.so) + 442 [0x108f4f53e]
+ 2491 parquet::internal::(anonymous namespace)::TypedRecordReader<parquet::PhysicalType<(parquet::Type::type)1> >::ReadRecordData(long long) (in arrow.so) + 471 [0x108f50503]
+ 2491 void parquet::internal::standard::DefLevelsToBitmapSimd<false>(short const*, long long, parquet::internal::LevelInfo, parquet::internal::ValidityBitmapInputOutput*) (in arrow.so) + 250 [0x108fc2a5a]
+ 2491 long long parquet::internal::standard::DefLevelsBatchToBitmap<false>(short const*, long long, long long, parquet::internal::LevelInfo, arrow::internal::FirstTimeBitmapWriter*) (in arrow.so) + 63 [0x108fc34da]
+ 2491 ??? (in <unknown binary>) [0x600001354518]
+ 2491 _sigtramp (in libsystem_platform.dylib) + 29 [0x7ff801c57e2d]
+ 2491 sigactionSegv (in libR.dylib) + 649 [0x1042598c9] main.c:625
+ 2491 Rstd_ReadConsole (in libR.dylib) + 2042 [0x10435160a] sys-std.c:1044
+ 2491 R_SelectEx (in libR.dylib) + 308 [0x104350854] sys-std.c:178
+ 2491 __select (in libsystem_kernel.dylib) + 10 [0x7ff801c0de4a]
```
```
Dump of assembler code from 0x13ac6db00 to 0x13ac6db99ff:
...
--Type <RET> for more, q to quit, c to continue without paging--
0x000000013ac6db82: mov $0x8,%ecx
0x000000013ac6db87: sub %rax,%rcx
0x000000013ac6db8a: lea 0xf1520b(%rip),%rdi # 0x13bb82d9c
0x000000013ac6db91: movzbl (%rcx,%rdi,1),%edi
0x000000013ac6db95: mov %esi,%ebx
0x000000013ac6db97: and %edi,%ebx
=> 0x000000013ac6db99: shlx %rax,%rbx,%rax
0x000000013ac6db9e: or 0x18(%r15),%al
0x000000013ac6dba2: mov %al,0x18(%r15)
0x000000013ac6dba6: cmp %rdx,%rcx
0x000000013ac6dba9: jg 0x13ac6dbf5
0x000000013ac6dbab: mov %al,(%r14)
0x000000013ac6dbae: inc %r14
0x000000013ac6dbb1: shrx %rcx,%rsi,%rax
0x000000013ac6dbb6: mov %rax,-0x20(%rbp)
0x000000013ac6dbba: sub %rcx,%rdx
0x000000013ac6dbbd: mov %rdx,%rbx
0x000000013ac6dbc0: sar $0x3,%rbx
0x000000013ac6dbc4: and $0x7,%edx
0x000000013ac6dbc7: cmp $0x1,%rdx
0x000000013ac6dbcb: sbb $0xffffffffffffffff,%rbx
0x000000013ac6dbcf: lea -0x20(%rbp),%rsi
0x000000013ac6dbd3: mov %r14,%rdi
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039402571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1051346283
Revision: bfb7b85d6221c64ec16eab2045db10a81b27b8d6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1685](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1685)
|Task|Status|
|----|------|
|test-r-minsizerel|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1685-github-test-r-minsizerel)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1057201921
I tried also running GCC, it _seems_ to run the test just fine but I'm still getting segfaults when the tests finish(?) I also tried isolating the tests to just the one file that has the test that segfaults with clang and that has been freezing + timing out.
I'm going to close this and move on to other tasks — if anyone wants to take it up, feel free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane closed pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane closed pull request #12422:
URL: https://github.com/apache/arrow/pull/12422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039439753
```
Unable to match any tasks for `with`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/1842912357```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039438960
@github-actions crossbow submit test-r-minsizerel with ARROW_R_DEV globally so that it is set when the tests run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#discussion_r806118341
##########
File path: r/tests/testthat.R
##########
@@ -20,6 +20,8 @@ library(arrow)
library(tibble)
if (identical(tolower(Sys.getenv("ARROW_R_DEV", "false")), "true")) {
+ arrow::arrow_info()
+
Review comment:
This might be helpful in debugging. We can remove it before we merge this, though it should only impact our CI builds and maybe it's good/fine to keep it around?
##########
File path: dev/tasks/tasks.yml
##########
@@ -1252,6 +1252,12 @@ tasks:
ci: github
template: r/github.linux.offline.build.yml
+ test-r-minsizerel:
+ ci: github
+ template: r/github.macos-linux.local.yml
Review comment:
This builds on macos + linux, which isn't strictly necessary for triggering what we're trying to trigger, but might be worth checking both linux + macos anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039590176
Yes, it's based on that info that I estimate that it's a compiler bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#discussion_r806969469
##########
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##########
@@ -642,6 +642,9 @@ elseif("${CMAKE_BUILD_TYPE}" STREQUAL "PROFILE_GEN")
elseif("${CMAKE_BUILD_TYPE}" STREQUAL "PROFILE_BUILD")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${C_FLAGS_PROFILE_BUILD}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_FLAGS_PROFILE_BUILD}")
+elseif("${CMAKE_BUILD_TYPE}" STREQUAL "MINSIZEREL")
+ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${C_FLAGS_MINSIZEREL}")
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_FLAGS_MINSIZEREL}")
Review comment:
Can you make a separate (presumably minor) PR for this change + the arrow_info() addition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane removed a comment on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane removed a comment on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039402571
@github-actions crossbow submit test-r-minsizerel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1040070809
@github-actions crossbow submit test-r-minsizerel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12422: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1039402676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12422:
URL: https://github.com/apache/arrow/pull/12422#issuecomment-1051345657
@github-actions crossbow submit test-r-minsizerel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org