[GitHub] [ignite] J-Bakuli commented on a diff in pull request #10328: IGNITE-17383 Stop IdleVerify process for an inactive cluster with per…

["J-Bakuli (via GitHub)" <gi...@apache.org>]

J-Bakuli commented on code in PR #10328:
URL: https://github.com/apache/ignite/pull/10328#discussion_r1163787487


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/VerifyBackupPartitionsTaskV2.java:
##########
@@ -83,6 +83,11 @@ public class VerifyBackupPartitionsTaskV2 extends ComputeTaskAdapter<VisorIdleVe
     /** First version of Ignite that is capable of executing Idle Verify V2. */
     public static final IgniteProductVersion V2_SINCE_VER = IgniteProductVersion.fromString("2.5.3");
 
+    /** Error thrown when idle_verify is called on an inactive cluster with persistence. */
+    public static final String IDLE_VERIFY_ON_INACTIVE_CLUSTER_ERROR_MESSAGE = "Can not perform the operation because " +

Review Comment:
   I agree with you that 'cannot' is better to be used here however we have the same beginning of the message "Can not perform the operation because the cluster is inactive..." in other classes as well.
   For instance, [ClusterStateTestUtils](https://github.com/apache/ignite/blob/3ecb062d91b21fb23e14a7cbe0805468aef3c398/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/ClusterStateTestUtils.java#L91), [IgniteKernal](https://github.com/apache/ignite/blob/3ecb062d91b21fb23e14a7cbe0805468aef3c398/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java#L3121), [IgniteAuthenticationProcessor](https://github.com/apache/ignite/blob/3ecb062d91b21fb23e14a7cbe0805468aef3c398/modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/IgniteAuthenticationProcessor.java#L445).
   
   Should I change the text in other exceptions as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org