You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/06/02 21:00:06 UTC
[GitHub] [storm] agresch opened a new pull request #3279: STORM-3644 update pacemaker connection error log
agresch opened a new pull request #3279:
URL: https://github.com/apache/storm/pull/3279
## What is the purpose of the change
Improve error message on pacemaker connection exceptions.
## How was the change tested
Built storm-client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] agresch commented on a change in pull request #3279: STORM-3644 update pacemaker connection error log
Posted by GitBox <gi...@apache.org>.
agresch commented on a change in pull request #3279:
URL: https://github.com/apache/storm/pull/3279#discussion_r434603387
##########
File path: storm-client/src/jvm/org/apache/storm/pacemaker/PacemakerClient.java
##########
@@ -182,7 +182,7 @@ public HBMessage send(HBMessage m) throws PacemakerConnectionException, Interrup
if (retry <= 0) {
throw e;
}
- LOG.error("error attempting to write to a channel {}.", e.getMessage());
+ LOG.error("Error attempting to write to a channel to host " + host + " - " + e.getMessage());
Review comment:
will update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm commented on a change in pull request #3279: STORM-3644 update pacemaker connection error log
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3279:
URL: https://github.com/apache/storm/pull/3279#discussion_r434588055
##########
File path: storm-client/src/jvm/org/apache/storm/pacemaker/PacemakerClient.java
##########
@@ -182,7 +182,7 @@ public HBMessage send(HBMessage m) throws PacemakerConnectionException, Interrup
if (retry <= 0) {
throw e;
}
- LOG.error("error attempting to write to a channel {}.", e.getMessage());
+ LOG.error("Error attempting to write to a channel to host " + host + " - " + e.getMessage());
Review comment:
why not use `{}`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm merged pull request #3279: STORM-3644 update pacemaker connection error log
Posted by GitBox <gi...@apache.org>.
Ethanlm merged pull request #3279:
URL: https://github.com/apache/storm/pull/3279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org