You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/10/25 17:45:47 UTC

[jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

Overhead of LinkedHashSet/Map is vs not is inconsequential. When porting production code to not break tests across JRE 7 and 8 at square, we wild-carded this change after peer review. It is safe.
You can merge this Pull Request by running:

  git pull https://github.com/adriancole/jclouds-labs-google adrian.iteration-order

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-google/pull/66

-- Commit Summary --

  * Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests. Switch to LinkedHashSet/Map.

-- File Changes --

    M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/strategy/internal/SequentialMultipartUploadStrategy.java (2)
    M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/BucketTemplate.java (6)
    M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/ComposeObjectTemplate.java (2)
    M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/ObjectTemplate.java (4)
    M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GCSBlobIntegrationLiveTest.java (2)
    M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GCSContainerIntegrationLiveTest.java (2)
    M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ObjectApiLiveTest.java (6)
    M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineService.java (2)
    M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/strategy/CreateNodesWithGroupEncodedIntoNameThenAddToSet.java (2)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/66.patch
https://github.com/jclouds/jclouds-labs-google/pull/66.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/66

Re: [jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-labs-google #1543](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1543/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/66#issuecomment-60487160

Re: [jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-labs-google-pull-requests #179](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/179/) FAILURE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/66#issuecomment-60487056

Re: [jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-labs-google-pull-requests #180](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/180/) FAILURE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/66#issuecomment-60488976

Re: [jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

Posted by Adrian Cole <no...@github.com>.

picked into master

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/66#issuecomment-60492756

Re: [jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-labs-google-pull-requests #178](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/178/) FAILURE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/66#issuecomment-60486949

Re: [jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-labs-google-pull-requests #181](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/181/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/66#issuecomment-60489933

Re: [jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-labs-google #1542](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1542/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/66#issuecomment-60487014

Re: [jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

Posted by Adrian Cole <no...@github.com>.

Closed #66.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/66#event-183676537

Re: [jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-labs-google #1545](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1545/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/66#issuecomment-60490031

Re: [jclouds-labs-google] Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests (#66)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-labs-google #1544](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1544/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/66#issuecomment-60489049