[PR] Simplify SpiderMonkey couchjs sources [couchdb]

["big-r81 (via GitHub)" <gi...@apache.org>]

big-r81 opened a new pull request, #5319:
URL: https://github.com/apache/couchdb/pull/5319

   Hi,
   
   I tried to combine and merge the different SpiderMonkey source files together.
   
   During compiling with SM v128 I got the following error message:
   
   ```
   [1] Compiling /Users/big-r/Documents/Developer/CouchDB/couchdb/src/couch/priv/couch_js/102/util.cpp
   /Users/big-r/Documents/Developer/CouchDB/couchdb/src/couch/priv/couch_js/102/util.cpp:327:17: error: invalid operands to binary expression ('std::ostringstream' (aka 'basic_ostringstream<char>') and 'JS::ConstUTF8CharsZ')
               msg << report->filename;
               ~~~ ^  ~~~~~~~~~~~~~~~~
   
   [2] /Users/big-r/Documents/Developer/CouchDB/couchdb/src/couch/priv/couch_js/102/util.cpp:333:49: error: invalid operands to binary expression ('basic_ostream<char, char_traits<char>>' and 'JS::ColumnNumberOneOrigin')
               msg << ':' << report->lineno << ':' << report->column;
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~
   ```
   
   I fixed these both errors with the following statements:
   ```
   [1] msg << report->filename.c_str();
   
   [2] msg << ':' << report->lineno << ':' << report->column.oneOriginValue();
   ```
   
   After that change, I successful compiled against v91, v115 and v128 und run the Fauxton checks!
   It seems, that the missing part in all version was the `deepFreeze` function...
   
   Here is the full log: [error.log](https://github.com/user-attachments/files/17491386/error.log)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Simplify SpiderMonkey couchjs sources [couchdb]

["big-r81 (via GitHub)" <gi...@apache.org>]

big-r81 commented on PR #5319:
URL: https://github.com/apache/couchdb/pull/5319#issuecomment-2432401854

   Closing in favor of #5321 (full CI runs).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Simplify SpiderMonkey couchjs sources [couchdb]

["big-r81 (via GitHub)" <gi...@apache.org>]

big-r81 closed pull request #5319: Simplify SpiderMonkey couchjs sources
URL: https://github.com/apache/couchdb/pull/5319


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org