You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2019/05/29 13:30:05 UTC

Review Request 70745: ATLAS-3243 :- Atlas to support UI access via Knox Trusted Proxy

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70745/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.


Bugs: ATLAS-3243
    https://issues.apache.org/jira/browse/ATLAS-3243


Repository: atlas


Description
-------

This patch provides changes required to support UI access Atlas via Trusted Knox proxy, there some changes required in AtlasAuthenticationFilter.


Diffs
-----

  webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java b6ed545e6 


Diff: https://reviews.apache.org/r/70745/diff/1/


Testing
-------

Tested Atlas different scenario's

1) curl call with kerberos.
2) curl Simple basic heaeder
3) Atlas login page.
4) curl with trusted proxy 
4) Atlas UI with Trusted Proxy with Knox shiroprovider.
5) Atlas UI with Trusted proxy with KnoxSSOCoookieProvider.


Thanks,

Nixon Rodrigues


Re: Review Request 70745: ATLAS-3243 :- Atlas to support UI access via Knox Trusted Proxy

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70745/#review215684
-----------------------------------------------------------


Fix it, then Ship it!





webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
Lines 347 (patched)
<https://reviews.apache.org/r/70745/#comment302478>

    nit: remove additional new line(s). Same for line #763, 764


- Sarath Subramanian


On June 4, 2019, 7:52 a.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70745/
> -----------------------------------------------------------
> 
> (Updated June 4, 2019, 7:52 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3243
>     https://issues.apache.org/jira/browse/ATLAS-3243
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch provides changes required to support UI access Atlas via Trusted Knox proxy, there some changes required in AtlasAuthenticationFilter.
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 782b5a06c 
> 
> 
> Diff: https://reviews.apache.org/r/70745/diff/2/
> 
> 
> Testing
> -------
> 
> Tested Atlas different scenario's
> 
> 1) curl call with kerberos.
> 2) curl Simple basic heaeder
> 3) Atlas login page.
> 4) curl with trusted proxy 
> 4) Atlas UI with Trusted Proxy with Knox shiroprovider.
> 5) Atlas UI with Trusted proxy with KnoxSSOCoookieProvider.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>


Re: Review Request 70745: ATLAS-3243 :- Atlas to support UI access via Knox Trusted Proxy

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70745/
-----------------------------------------------------------

(Updated June 4, 2019, 2:52 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.


Changes
-------

Updated the patch with fix for Atlas UI with trusted proxy.


Bugs: ATLAS-3243
    https://issues.apache.org/jira/browse/ATLAS-3243


Repository: atlas


Description
-------

This patch provides changes required to support UI access Atlas via Trusted Knox proxy, there some changes required in AtlasAuthenticationFilter.


Diffs (updated)
-----

  webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 782b5a06c 


Diff: https://reviews.apache.org/r/70745/diff/2/

Changes: https://reviews.apache.org/r/70745/diff/1-2/


Testing
-------

Tested Atlas different scenario's

1) curl call with kerberos.
2) curl Simple basic heaeder
3) Atlas login page.
4) curl with trusted proxy 
4) Atlas UI with Trusted Proxy with Knox shiroprovider.
5) Atlas UI with Trusted proxy with KnoxSSOCoookieProvider.


Thanks,

Nixon Rodrigues


Re: Review Request 70745: ATLAS-3243 :- Atlas to support UI access via Knox Trusted Proxy

Posted by Sarath Subramanian <sa...@apache.org>.

> On May 29, 2019, 12:54 p.m., Sarath Subramanian wrote:
> > Ship It!

Nixon, can you address Ashutosh's comment and update the review.


- Sarath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70745/#review215587
-----------------------------------------------------------


On May 29, 2019, 6:30 a.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70745/
> -----------------------------------------------------------
> 
> (Updated May 29, 2019, 6:30 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3243
>     https://issues.apache.org/jira/browse/ATLAS-3243
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch provides changes required to support UI access Atlas via Trusted Knox proxy, there some changes required in AtlasAuthenticationFilter.
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java b6ed545e6 
> 
> 
> Diff: https://reviews.apache.org/r/70745/diff/1/
> 
> 
> Testing
> -------
> 
> Tested Atlas different scenario's
> 
> 1) curl call with kerberos.
> 2) curl Simple basic heaeder
> 3) Atlas login page.
> 4) curl with trusted proxy 
> 4) Atlas UI with Trusted Proxy with Knox shiroprovider.
> 5) Atlas UI with Trusted proxy with KnoxSSOCoookieProvider.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>


Re: Review Request 70745: ATLAS-3243 :- Atlas to support UI access via Knox Trusted Proxy

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70745/#review215587
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On May 29, 2019, 6:30 a.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70745/
> -----------------------------------------------------------
> 
> (Updated May 29, 2019, 6:30 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3243
>     https://issues.apache.org/jira/browse/ATLAS-3243
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch provides changes required to support UI access Atlas via Trusted Knox proxy, there some changes required in AtlasAuthenticationFilter.
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java b6ed545e6 
> 
> 
> Diff: https://reviews.apache.org/r/70745/diff/1/
> 
> 
> Testing
> -------
> 
> Tested Atlas different scenario's
> 
> 1) curl call with kerberos.
> 2) curl Simple basic heaeder
> 3) Atlas login page.
> 4) curl with trusted proxy 
> 4) Atlas UI with Trusted Proxy with Knox shiroprovider.
> 5) Atlas UI with Trusted proxy with KnoxSSOCoookieProvider.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>


Re: Review Request 70745: ATLAS-3243 :- Atlas to support UI access via Knox Trusted Proxy

Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70745/#review215576
-----------------------------------------------------------



Optional request: Is it possible to extend _AtlasAuthenticationKerberosFilterTest_ to test for this case?


webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
Line 304 (original), 305 (patched)
<https://reviews.apache.org/r/70745/#comment302300>

    Can you please move all the property strings to private static final String?


- Ashutosh Mestry


On May 29, 2019, 1:30 p.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70745/
> -----------------------------------------------------------
> 
> (Updated May 29, 2019, 1:30 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3243
>     https://issues.apache.org/jira/browse/ATLAS-3243
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch provides changes required to support UI access Atlas via Trusted Knox proxy, there some changes required in AtlasAuthenticationFilter.
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java b6ed545e6 
> 
> 
> Diff: https://reviews.apache.org/r/70745/diff/1/
> 
> 
> Testing
> -------
> 
> Tested Atlas different scenario's
> 
> 1) curl call with kerberos.
> 2) curl Simple basic heaeder
> 3) Atlas login page.
> 4) curl with trusted proxy 
> 4) Atlas UI with Trusted Proxy with Knox shiroprovider.
> 5) Atlas UI with Trusted proxy with KnoxSSOCoookieProvider.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>