You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/19 05:26:30 UTC
[GitHub] [incubator-nuttx-testing] btashton opened a new pull request #50: Add support for building avr targets
btashton opened a new pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50
## Summary
Adds AVR GCC compiler to Darwin environment and to Linux Docker container.
Adds AVR configurations to CI targets
Note we are not using the Microchip toolchain because it is behind a login wall. The Homebrew tap and the Ubuntu version are both quite stable and up-to-date
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] Ouss4 commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660662608
> So far we have been consolidating them to keep the build runners equalized in run time. There is a bit of a job startup overhead that we would pay extra for further splitting.
The reason I'm saying that is because these AVR warnings seem to be an issue/characterestic of the architecture. Splitting the AVR tests would give us more control over them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] Ouss4 commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660649213
I think we should just silence these warnings. For instance, I don't see a way to fix:
```
cast to pointer from integer of different size [-Wint-to-pointer-cast]
FAR struct mtd_protect_s *prot = (FAR struct mtd_protect_s *)arg;
```
Can we just do that for one architecture? I know we can send extraflags to the script but I this will be applied to the whole matrix (mips, xtensa and sim in this case).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660668426
> > BTW, how about we merge incubator-nuttx-testing into nuttx? The seprated git make the change like this become a painful and chaotic process. Another benefit is that all user can run the automation build without any manual setup.
>
> +1
>
> I like the idea of having the testings integrated on NuttX, we could run it before submitting the PR to avoid painful and long interaction cycles.
Ok, I will provide a PR to migrate the build script to nuttx/tools once @btashton finish avr support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] Ouss4 edited a comment on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
Ouss4 edited a comment on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660649213
I think we should just silence these warnings. For instance, I don't see a way to fix:
```
cast to pointer from integer of different size [-Wint-to-pointer-cast]
FAR struct mtd_protect_s *prot = (FAR struct mtd_protect_s *)arg;
```
Can we just do that for one architecture? I know we can send extraflags to the script but this will be applied to the whole matrix (mips, xtensa and sim in this case).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 edited a comment on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660653787
Maybe we can avoid the warning by casting to uintptr_t.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660660889
BTW, how about we merge incubator-nuttx-testing into nuttx? The seprated git make the change like this become a painful and chaotic process. Another benefit is that all user can run the automation build without any manual setup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660598968
@xiaoxiang781216 I'm doing more fixes for this. I'll make the changes you already noted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#discussion_r456868736
##########
File path: testlist/mips-riscv-x86-xtensa-avr.dat
##########
@@ -13,3 +13,5 @@
/x86_64
/xtensa
+
+/avr
Review comment:
let move /avr to the beginning to keep the order.
##########
File path: .github/workflows/build.yml
##########
@@ -79,7 +79,7 @@ jobs:
strategy:
matrix:
- boards: [arm-12, mips-riscv-x86-xtensa, sim]
+ boards: [arm-12, mips-riscv-x86-xtensa-avr, sim]
Review comment:
Change mips-riscv-xtensa-avr to avr-mips-riscv-xtensa to keep the order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660601884
@xiaoxiang781216 we will need to get this PR merged in before the CI will run https://github.com/apache/incubator-nuttx/pull/1423
Also because of the way tests are setup the linux test will not use the docker container that it builds, instead using the one on master. I expect the macOS build to work though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] acassis commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660662176
> BTW, how about we merge incubator-nuttx-testing into nuttx? The seprated git make the change like this become a painful and chaotic process. Another benefit is that all user can run the automation build without any manual setup.
+1
I like the idea of having the testings integrated on NuttX, we could run it before submitting the PR to avoid painful and long interaction cycles.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660659190
Sure, we can comment out avr from testdat until we fix all warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660660052
Ok we can do that instead and I can cat the test list in the OS PR until it passes. I have done that before to work around this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660660886
> I think we would want AVR data to be in a seperate file so that we can control it independently from other architectures.
So far we have been consolidating them to keep the build runners equalized in run time. There is a bit of a job startup overhead that we would pay extra for further splitting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660606790
There are some warnings caused by bugs that we will want to clean up, but I think we can address on the PR to actually enable the tests in the OS repo. For example:
```
====================================================================================
Configuration/Tool: teensy-2.0/usbmsc
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
boardctl.c: In function 'boardctl_usbdevctrl':
boardctl.c:155:2: warning: #warning Missing logic [-Wcpp]
#warning Missing logic
^
common/up_initialize.c: In function 'up_initialize':
common/up_initialize.c:212:3: warning: implicit declaration of function 'up_serialinit' [-Wimplicit-function-declaration]
up_serialinit();
^
net/lib_inetaddr.c: In function 'inet_addr':
net/lib_inetaddr.c:105:27: warning: left shift count >= width of type [-Wshift-count-overflow]
result = (a << 24) | b;
^
net/lib_inetaddr.c:114:27: warning: left shift count >= width of type [-Wshift-count-overflow]
result = (a << 24) | (b << 16) | c;
^
net/lib_inetaddr.c:114:39: warning: left shift count >= width of type [-Wshift-count-overflow]
result = (a << 24) | (b << 16) | c;
^
net/lib_inetaddr.c:123:27: warning: left shift count >= width of type [-Wshift-count-overflow]
result = (a << 24) | (b << 16) | (c << 8) | d;
^
net/lib_inetaddr.c:123:39: warning: left shift count >= width of type [-Wshift-count-overflow]
result = (a << 24) | (b << 16) | (c << 8) | d;
^
avr/up_spi.c: In function 'spi_setfrequency':
avr/up_spi.c:239:2: warning: #warning REVISIT: spcr/spsr are never used [-Wcpp]
#warning REVISIT: spcr/spsr are never used
^
driver/fs_blockpartition.c: In function 'part_ioctl':
driver/fs_blockpartition.c:235:44: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
FAR struct mtd_protect_s *prot = (FAR struct mtd_protect_s *)arg;
^
driver/fs_blockpartition.c:245:33: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
FAR void **base = (FAR void **)arg;
^
driver/fs_blockpartition.c:258:17: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
(FAR struct mtd_geometry_s *)arg;
^
partition/fs_partition.c: In function 'parse_block_partition':
partition/fs_partition.c:159:64: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
ret = state.blk->u.i_bops->ioctl(state.blk, MTDIOC_GEOMETRY, (unsigned long)&mgeo);
^
partition/fs_partition.c: In function 'parse_mtd_partition':
partition/fs_partition.c:210:42: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
ret = mtd->ioctl(mtd, MTDIOC_GEOMETRY, (unsigned long)&mgeo);
^
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660653787
Maybe we avoid the warning by casting to uintptr_t.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] Ouss4 commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660660253
I think we would want AVR data to be in a seperate file so that we can control it independently from other architectures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] Ouss4 commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660656021
I don't know if that would work but this type of casting is used throughout the code base. It would need a huge change to fix everything. I don't think we would want to go there.
And this is just one example there are other warnings, and it is just an issue of the architecture/toolchain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660657004
@xiaoxiang781216 @Ouss4 how about I revert the testdat file and add another one for AVR. That way we don't block the CI for other builds but I can enable it for the AVR fix PR. Then we can unify the testdat back once the AVR warnings are fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on pull request #50: Add support for building avr targets
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #50:
URL: https://github.com/apache/incubator-nuttx-testing/pull/50#issuecomment-660633712
Let's merge this PR first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org