You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sergey Shelukhin (JIRA)" <ji...@apache.org> on 2012/11/07 01:42:12 UTC
[jira] [Created] (HBASE-7110) refactor the compaction selection and
config code similarly to 0.89-fb changes
Sergey Shelukhin created HBASE-7110:
---------------------------------------
Summary: refactor the compaction selection and config code similarly to 0.89-fb changes
Key: HBASE-7110
URL: https://issues.apache.org/jira/browse/HBASE-7110
Project: HBase
Issue Type: Improvement
Affects Versions: 0.96.0
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501667#comment-13501667 ]
Enis Soztutar commented on HBASE-7110:
--------------------------------------
Overall looks good. Some points:
- I think HStore.getTtl() should just returns the configured this.ttl, and should not look at min versions. Looking at min versions only apply at the compaction selection for expiry.
- Some lines exceed 100 chars.
- Checked whether the current compaction policy is unchanged with this patch. Although there are some refactorings and splitting up the work, it seems so.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493450#comment-13493450 ]
Enis Soztutar commented on HBASE-7110:
--------------------------------------
Can you please rebase the patch. It does not apply to trunk now.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492018#comment-13492018 ]
Hadoop QA commented on HBASE-7110:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12552379/HBASE-6371-v5-refactor-only-squashed.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 11 new or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3243//console
This message is automatically generated.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502435#comment-13502435 ]
Sergey Shelukhin commented on HBASE-7110:
-----------------------------------------
With regard to the public stuff - yes, it's all for compaction package visibility... the only way to better control these things seems to be via more restrictive interfaces (e.g. StoreConfiguration, for example - if HStore could be made non-public).
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502205#comment-13502205 ]
Sergey Shelukhin commented on HBASE-7110:
-----------------------------------------
bq I think HStore.getTtl() should just returns the configured this.ttl, and should not look at min versions. Looking at min versions only apply at the compaction selection for expiry.
Renamed for clarity. See javadoc for StoreConfiguration, I hope that such bits of special logic that are currently shared in multiple places/just live where convenient can be unified there.
bq Some lines exceed 100 chars.
Fixed all/most/some old lines too :)
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504247#comment-13504247 ]
Hudson commented on HBASE-7110:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #274 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/274/])
HBASE-7110 refactor the compaction selection and config code similarly to 0.89-fb changes (Revision 1413912)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfiguration.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactSelection.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionPolicy.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSelection.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502527#comment-13502527 ]
Hadoop QA commented on HBASE-7110:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12554611/HBASE-7110-v8.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 11 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 96 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 25 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.TestHeapSize
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3394//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3394//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3394//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3394//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3394//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3394//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3394//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3394//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3394//console
This message is automatically generated.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7110) refactor the compaction selection and
config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Shelukhin updated HBASE-7110:
------------------------------------
Attachment: HBASE-7110-v7.patch
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504986#comment-13504986 ]
Hudson commented on HBASE-7110:
-------------------------------
Integrated in HBase-TRUNK #3570 (See [https://builds.apache.org/job/HBase-TRUNK/3570/])
HBASE-7110 refactor the compaction selection and config code similarly to 0.89-fb changes; REAPPLY v9 (Revision 1414308)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfiguration.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactSelection.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionPolicy.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-follow-up.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493396#comment-13493396 ]
Sergey Shelukhin commented on HBASE-7110:
-----------------------------------------
[~enis] can you please review? Thanks.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493617#comment-13493617 ]
Hadoop QA commented on HBASE-7110:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12552718/HBASE-7110-v6-squashed.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 11 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 85 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 17 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.TestHeapSize
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3276//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3276//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3276//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3276//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3276//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3276//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3276//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3276//console
This message is automatically generated.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492731#comment-13492731 ]
Sergey Shelukhin commented on HBASE-7110:
-----------------------------------------
Manager already renamed to policy; Utils seems to be a better name for this class - StoreTool seems to imply external usage e.g. LoadTestTool
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504217#comment-13504217 ]
Sergey Shelukhin commented on HBASE-7110:
-----------------------------------------
um, this shouldn't have been committed to trunk, I still haven't looked at TestHeapSize failure, I will probably do today.
Sorry for confusion.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7110) refactor the compaction selection and
config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Shelukhin updated HBASE-7110:
------------------------------------
Attachment: HBASE-7110-v9.patch
fixed size calculation.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502285#comment-13502285 ]
stack commented on HBASE-7110:
------------------------------
Looking at patch:
FYI:
{code}
-import org.apache.hadoop.hbase.regionserver.compactions.CompactSelection;
-import org.apache.hadoop.hbase.regionserver.compactions.CompactionProgress;
-import org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest;
+import org.apache.hadoop.hbase.regionserver.compactions.*;
{code}
... not a show stopper but better to list individual imports than use '*'.
This has to be public?
getStoreFileTtl
So it can be picked up by compaction code?
And these need to be public too for same reason?
getMajorCompactionPeriod
getMemstoreFlushSize
In Store there are imports but they are not used?
+import java.lang.reflect.InvocationTargetException;
+import java.util.Collection;
Yeah, why you making stuff public in StoreFile? So can be reached from compaction package?
Should StoreUtils be public? Should it be private to this package?
Patch is good. Anything that can be done about reaching between packages and opening up methods that were previously package protected?
The small stuff in the above I can address on commit.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504245#comment-13504245 ]
Hudson commented on HBASE-7110:
-------------------------------
Integrated in HBase-TRUNK #3566 (See [https://builds.apache.org/job/HBase-TRUNK/3566/])
HBASE-7110 refactor the compaction selection and config code similarly to 0.89-fb changes (Revision 1413912)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfiguration.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactSelection.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionPolicy.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSelection.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502206#comment-13502206 ]
Sergey Shelukhin commented on HBASE-7110:
-----------------------------------------
Well, by "bq", I meant
bq. "bq."
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502258#comment-13502258 ]
Hadoop QA commented on HBASE-7110:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12554553/HBASE-7110-v7.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 11 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 97 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 25 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.TestHeapSize
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3389//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3389//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3389//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3389//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3389//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3389//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3389//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3389//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3389//console
This message is automatically generated.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504372#comment-13504372 ]
stack commented on HBASE-7110:
------------------------------
Thanks for the addendum Sergey. Applied. Sorry for committing before last test run.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-follow-up.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7110) refactor the compaction selection and
config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Shelukhin updated HBASE-7110:
------------------------------------
Status: Patch Available (was: Open)
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493535#comment-13493535 ]
Sergey Shelukhin commented on HBASE-7110:
-----------------------------------------
updated
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492032#comment-13492032 ]
Sergey Shelukhin commented on HBASE-7110:
-----------------------------------------
woops, I meant the above comment to be in 7109
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7110) refactor the compaction selection and
config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Shelukhin updated HBASE-7110:
------------------------------------
Description: Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505110#comment-13505110 ]
Hudson commented on HBASE-7110:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #276 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/276/])
HBASE-7110 refactor the compaction selection and config code similarly to 0.89-fb changes; REAPPLY v9 (Revision 1414308)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfiguration.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactSelection.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionPolicy.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-follow-up.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491994#comment-13491994 ]
Sergey Shelukhin commented on HBASE-7110:
-----------------------------------------
[~enis] can you please take a look eventually? Thanks!
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504382#comment-13504382 ]
stack commented on HBASE-7110:
------------------------------
I removed it all Sergey (v8 and then the addendum). You want me to apply v9 and then the addendum to fix test size? Thanks.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-follow-up.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7110) refactor the compaction selection and
config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Shelukhin updated HBASE-7110:
------------------------------------
Attachment: HBASE-7110-v6-squashed.patch
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7110) refactor the compaction selection and
config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Shelukhin updated HBASE-7110:
------------------------------------
Attachment: HBASE-6371-v5-refactor-only-squashed.patch
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Shelukhin reopened HBASE-7110:
-------------------------------------
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-follow-up.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7110) refactor the compaction selection and
config code similarly to 0.89-fb changes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7110:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch Sergey.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497501#comment-13497501 ]
stack commented on HBASE-7110:
------------------------------
[~enis] Can you review Sergey's latest update?
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504811#comment-13504811 ]
Sergey Shelukhin commented on HBASE-7110:
-----------------------------------------
Tests pass on trunk as of the fix commit... so v9 or v8 plus fix can be committed back... thanks :)
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-follow-up.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504805#comment-13504805 ]
Sergey Shelukhin commented on HBASE-7110:
-----------------------------------------
It should be that v9 == v8 + fix, I will verify on trunk
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-follow-up.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492740#comment-13492740 ]
stack commented on HBASE-7110:
------------------------------
I suggest naming it other than StoreUtils because our convention up to this is that a class with Utils suffix sits over in util package. Going by its current content, it could be used 'externally' given it a bunch of static methods that you pass in lists of StoreFiles. Why ain't this class called StoreFileUtils or StoreFileTool or just be methods on end of StoreFile? If it has been renamed Policy, thats good. Will wait on Enis review before commit.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492721#comment-13492721 ]
stack commented on HBASE-7110:
------------------------------
I'd be +1 on commit (I'd rename StoreUtils as StoreTool or some such and would be in favor of Enis' suggested changing of Manager to Policy since this is what will be swapped out when we introduce a new mechanism).
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502269#comment-13502269 ]
stack commented on HBASE-7110:
------------------------------
@Sergey Is the TestHeapSize failure legit? Caused by this patch? If you can't reproduce, try passing -d32 so you get 32bit jvm; sometimes that'll reveal the heap size issue.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504812#comment-13504812 ]
Sergey Shelukhin commented on HBASE-7110:
-----------------------------------------
as in, TestHeapSize
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-follow-up.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7110) refactor the compaction selection and
config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Shelukhin updated HBASE-7110:
------------------------------------
Attachment: HBASE-7110-v8.patch
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7110) refactor the compaction selection and
config code similarly to 0.89-fb changes
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Shelukhin updated HBASE-7110:
------------------------------------
Attachment: HBASE-7110-follow-up.patch
Patch was committed before test was fixed... attaching followup patch for convenience.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-follow-up.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504402#comment-13504402 ]
Hudson commented on HBASE-7110:
-------------------------------
Integrated in HBase-TRUNK #3567 (See [https://builds.apache.org/job/HBase-TRUNK/3567/])
HBASE-7110 refactor the compaction selection and config code similarly to 0.89-fb changes; REVERT of original patch and ADDENDUM because applied old patch originally, v8 (Revision 1414000)
HBASE-7110 refactor the compaction selection and config code similarly to 0.89-fb changes; ADDENDUM to fix broke TestHeapSize (Revision 1413995)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfiguration.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactSelection.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionPolicy.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-follow-up.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-7110.
--------------------------
Resolution: Fixed
Reapplied v9. Thanks Sergey
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-follow-up.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7110) refactor the compaction selection
and config code similarly to 0.89-fb changes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504542#comment-13504542 ]
Hudson commented on HBASE-7110:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #275 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/275/])
HBASE-7110 refactor the compaction selection and config code similarly to 0.89-fb changes; REVERT of original patch and ADDENDUM because applied old patch originally, v8 (Revision 1414000)
HBASE-7110 refactor the compaction selection and config code similarly to 0.89-fb changes; ADDENDUM to fix broke TestHeapSize (Revision 1413995)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfiguration.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactSelection.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionPolicy.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-follow-up.patch, HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch, HBASE-7110-v8.patch, HBASE-7110-v9.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira