You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2018/09/18 20:13:25 UTC
[GitHub] tinkerpop pull request #933: TINKERPOP-1913 Make status attributes available
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/933
TINKERPOP-1913 Make status attributes available
https://issues.apache.org/jira/browse/TINKERPOP-1913
Status attributes have always been returned from Gremlin Server but they haven't been easy to access unless you were working with the lower end of the protocol. They are now available in a fairly wide number of ways across most of the various drivers in a fairly consistent fashion. The current gap in this feature is related to gremlin-javascript probably needs #922 - [TINKERPOP-1959](https://issues.apache.org/jira/browse/TINKERPOP-1959) so that we even have a "ResultSet" of sorts to hold the status attributes and make them available.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1913
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/933.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #933
----
commit fb3984aad10b1aa78a75a8d4d370e89fa384bac1
Author: Stephen Mallette <sp...@...>
Date: 2018-03-07T15:29:11Z
TINKERPOP-1913 Made status attributes available to the ResultSet
commit 60883a109d493f39b0c0445582a199a65037d1ab
Author: Stephen Mallette <sp...@...>
Date: 2018-03-07T17:05:23Z
TINKERPOP-1913 Added status attribute access to traversal side-effects
commit fe5ae5c369d4724e2c44d74de5357bf894126b9a
Author: Ashwini Singh <as...@...>
Date: 2018-05-14T18:42:54Z
status attribute for gremlin dotnet
commit 705ce4ee3816884a57ee00aef9f5b65eafb0004a
Author: Ashwini Singh <as...@...>
Date: 2018-05-14T18:48:29Z
Adding comment
commit 6310dabb7fc33c44b97ef75e9a8663aa17e51319
Author: Ashwini Singh <as...@...>
Date: 2018-05-16T19:14:01Z
Addressing review comments
commit 24e08d2b99d77ae634576acc6cd0c4061d1b0bac
Author: Stephen Mallette <sp...@...>
Date: 2018-08-16T12:08:11Z
TINKERPOP-1913 Corrected status attributes messages after rebase
Test graphs are now named differently given the refactoring that went into improving integration configurations. Also fixed a bug in NO_CONTENT messages and added a test.
commit f7193c90a3cd1433961028e2e5ad7e330b08c339
Author: Stephen Mallette <sp...@...>
Date: 2018-08-16T13:24:21Z
TINKERPOP-1913 Fixed compile error after rebase on master
commit 956b177f7a62b45713bd7111f139c1140c974915
Author: Stephen Mallette <sp...@...>
Date: 2018-08-16T14:38:48Z
TINKERPOP-1913 ResponseException will have status attributes present
commit 7fca7af74e5bd2695ba6035cf341543f9750fc4d
Author: Stephen Mallette <sp...@...>
Date: 2018-08-16T15:38:09Z
TINKERPOP-1913 Refactored how response status attributes are set
Didn't seem necessary to set them directly into a member variable on ResultQueue when they could be passed more safely by just including them with the completion state update
commit 137f36510a134f4599dc30210341004b6912fbfd
Author: Patrik Husfloen <re...@...>
Date: 2018-09-05T21:40:57Z
Exposes ResultSet<T> on GremlinClient.
Adds StatusAttributes property on ResponseException.
Removed explicit this from ResultSet<T> to align with existing style.
commit 5de845462c61c81cdccf50088481ab5ac831ec4c
Author: Patrik Husfloen <re...@...>
Date: 2018-09-06T21:16:56Z
Updates GremlinClientExtension to pass through ResultSet<T> from client.
commit c720dba7ffa212fc8574af84f4fc90f1b7174b58
Author: Patrik Husfloen <re...@...>
Date: 2018-09-08T14:54:11Z
Adds StatusCode (of type ResponseStatusCode) property on ResponseException.
commit cbc2b68959842a3a01b9f776ed42486d3a135684
Author: Patrik Husfloen <re...@...>
Date: 2018-09-13T21:39:19Z
Tweaks xml doc comment formatting to match existing code.
commit 5eac32efb135520f2d0c844bd085df5204b7920c
Author: Patrik Husfloen <re...@...>
Date: 2018-09-13T21:58:32Z
Fixes incorrect usage of <inheritdoc />
commit 55549cfd49817da35c4dd460b596c734daaaf011
Author: Stephen Mallette <sp...@...>
Date: 2018-09-18T16:45:15Z
TINKERPOP-1913 Modified changelog
commit 9a8f57623a2482711007a840bf0c9ede247943f3
Author: Stephen Mallette <sp...@...>
Date: 2018-09-18T16:47:43Z
TINKERPOP-1913 Cleaned up deprecation messages
commit bb01d96fbd7efdd4de30d7c0e570e48b91c0d490
Author: Stephen Mallette <sp...@...>
Date: 2018-09-18T17:15:59Z
TINKERPOP-1913 Upgrade docs for status attributes on responses
commit 49b1507fdcf15bed2667beb205357cb44a4d57e8
Author: Stephen Mallette <sp...@...>
Date: 2018-09-18T19:06:46Z
TINKERPOP-1913 Added status attributes to ResultSet for python
commit d457d7cba5a4a136597127c2793014bafa47b843
Author: Stephen Mallette <sp...@...>
Date: 2018-09-18T19:38:44Z
TINKERPOP-1913 GremlinServerError for python has status attributes now
commit 3aacd06fa84c4250505aad3809265a578cfc3d8f
Author: Stephen Mallette <sp...@...>
Date: 2018-09-18T19:51:32Z
TINKERPOP-1913 Retrieve status attributes through side-effects in python
----
---
[GitHub] tinkerpop issue #933: TINKERPOP-1913 Make status attributes available
Posted by AbhishekTripathi <gi...@git.apache.org>.
Github user AbhishekTripathi commented on the issue:
https://github.com/apache/tinkerpop/pull/933
Thanks for taking this forward. When can we expect the rc2 nuget package?
---
[GitHub] tinkerpop issue #933: TINKERPOP-1913 Make status attributes available
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/933
Assuming there are no objections on the dev list to doing a release candidate for 3.4.0 then it could be as early as next week, but that discussion needs to run to completion. Please follow along here:
https://lists.apache.org/thread.html/5c31225ad90b1ae4637464bc5d89bcc47e113dc5694f60fa1a9c2cd0@%3Cdev.tinkerpop.apache.org%3E
---
[GitHub] tinkerpop pull request #933: TINKERPOP-1913 Make status attributes available
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/933
---
[GitHub] tinkerpop issue #933: TINKERPOP-1913 Make status attributes available
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/933
VOTE +1
---
[GitHub] tinkerpop issue #933: TINKERPOP-1913 Make status attributes available
Posted by jorgebay <gi...@git.apache.org>.
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/933
VOTE +1
---