[GitHub] [arrow-adbc] WillAyd commented on a diff in pull request #668: feat(c/driver/postgresql): Implement Postgres Get table types

["WillAyd (via GitHub)" <gi...@apache.org>]

WillAyd commented on code in PR #668:
URL: https://github.com/apache/arrow-adbc/pull/668#discussion_r1189096540


##########
c/validation/adbc_validation.cc:
##########
@@ -362,6 +362,20 @@ void ConnectionTest::TestMetadataGetTableTypes() {
   ASSERT_NO_FATAL_FAILURE(CompareSchema(
       &reader.schema.value, {{"table_type", NANOARROW_TYPE_STRING, NOT_NULL}}));
   ASSERT_NO_FATAL_FAILURE(reader.Next());
+
+  bool seen_table = false;

Review Comment:
   Pretty basic but figured worth validating values in the base test class. I think all databases should at least have the concept of tables and views?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org