You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl@perl.apache.org by Clinton Gormley <cl...@drtech.co.uk> on 2003/04/04 10:31:57 UTC
Re: Compiling Apache::Scoreboard
I'm trying to compile Apache::Scoreboard with mod_perl 1.27, and am
getting this error :
.....include/modules/perl/mod_perl.h:261: parse error before '*' token
.....include/modules/perl/mod_perl.h:261: warning: data definition has
no type or storage class
I found a email about this to which Stas replied :
>Stas Bekman wrote:
> I think this has to do with the ordering of including apache headers.
This was
> fixed in the cvs version of mod_perl 1.0. Can you please try to
rebuild mod_perl
> using the cvs version and then give another chance to
Apache::Scoreboard?
After recompiling Apache with the mod_perl CVS snap shot from 4 April,
I'm getting the same error.
Any ideas?
thanks
Clinton
Re: Compiling Apache::Scoreboard
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
>
>> The mod_perl CVS version from 4 April didn't have these changes. I have
>> recompiled with this patch in place and it works now.
>
>
> Let's wait for Geoff to confirm whether this should go in or not. I
> don't remember what was the outcome of an old thread discussing it.
I actually don't remember the thread at all, but I'll look it up. however,
if you were having compile problems and the patch clears it up, the change
seems simple enough to integrate.
--Geoff
Re: Compiling Apache::Scoreboard
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>
>> Let's wait for Geoff to confirm whether this should go in or not. I
>> don't remember what was the outcome of an old thread discussing it.
>>
>
> ok, now I remember the discussion.
>
> http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=104095559928916&w=2
>
> I still don't have any problems building my XS modules that access the
> Apache C API with a threaded perl (such as Apache::AuthDigest). but I
> also can confirm the parse errors with Apache::Scoreboard.
>
> at any rate, the patch fixes the problem for me. I also tried a few of
> my XS modules and they compile and test fine as well.
>
> so +1 on the patch.
Thanks Geoff! Committed.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: Compiling Apache::Scoreboard
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> Let's wait for Geoff to confirm whether this should go in or not. I
> don't remember what was the outcome of an old thread discussing it.
>
ok, now I remember the discussion.
http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=104095559928916&w=2
I still don't have any problems building my XS modules that access the
Apache C API with a threaded perl (such as Apache::AuthDigest). but I also
can confirm the parse errors with Apache::Scoreboard.
at any rate, the patch fixes the problem for me. I also tried a few of my
XS modules and they compile and test fine as well.
so +1 on the patch.
--Geoff
Re: Compiling Apache::Scoreboard
Posted by Stas Bekman <st...@stason.org>.
Clinton Gormley wrote:
> On Mon, 2003-04-07 at 02:08, Stas Bekman wrote:
>
>>>After recompiling Apache with the mod_perl CVS snap shot from 4 April,
>>>I'm getting the same error.
>>
>>I've this outstanding patch that fixes this problem for me. But Geoff was
>>saying that the current mod_perl 1.0 cvs should have no problems. Geoff?
[...]
> The mod_perl CVS version from 4 April didn't have these changes. I have
> recompiled with this patch in place and it works now.
Let's wait for Geoff to confirm whether this should go in or not. I don't
remember what was the outcome of an old thread discussing it.
> By the way, how should I have used this patch? I saved it to a file
> 'patch' and tried 'patch modperl.h patch', but it died with:
> patching file mod_perl.h
> patch: *** malformed patch at line 9: #endif
>
> My version of patch is 2.5.4. What am I doing wrong here? (I eventually
> just patched it by hand).
probably got corrupted by the email-client. I've now attached it.
FWIW, it's better to have a habit to patch with:
% cd modperl
% patch -p0 < patch_file
since in many cases there is more than one file to patch in the diff file.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: Compiling Apache::Scoreboard
Posted by Clinton Gormley <cl...@drtech.co.uk>.
On Mon, 2003-04-07 at 02:08, Stas Bekman wrote:
> > After recompiling Apache with the mod_perl CVS snap shot from 4 April,
> > I'm getting the same error.
>
> I've this outstanding patch that fixes this problem for me. But Geoff was
> saying that the current mod_perl 1.0 cvs should have no problems. Geoff?
>
> Index: src/modules/perl/mod_perl.h
> ===================================================================
> RCS file: /home/cvs/modperl/src/modules/perl/mod_perl.h,v
> retrieving revision 1.117
> diff -u -r1.117 mod_perl.h
> --- src/modules/perl/mod_perl.h 14 Mar 2003 04:55:59 -0000 1.117
> +++ src/modules/perl/mod_perl.h 7 Apr 2003 00:06:23 -0000
> @@ -72,11 +72,8 @@
> #endif
>
> #ifdef PERL_THREADS
> -#define _INCLUDE_APACHE_FIRST
> -#endif
> -
> -#ifdef _INCLUDE_APACHE_FIRST
> #include "apache_inc.h"
> +#define _INCLUDE_APACHE_FIRST
> #endif
>
> #include "EXTERN.h"
>
The mod_perl CVS version from 4 April didn't have these changes. I have
recompiled with this patch in place and it works now.
By the way, how should I have used this patch? I saved it to a file
'patch' and tried 'patch modperl.h patch', but it died with:
patching file mod_perl.h
patch: *** malformed patch at line 9: #endif
My version of patch is 2.5.4. What am I doing wrong here? (I eventually
just patched it by hand).
thanks
Clint
Re: Compiling Apache::Scoreboard
Posted by Stas Bekman <st...@stason.org>.
Clinton Gormley wrote:
> I'm trying to compile Apache::Scoreboard with mod_perl 1.27, and am
> getting this error :
> .....include/modules/perl/mod_perl.h:261: parse error before '*' token
> .....include/modules/perl/mod_perl.h:261: warning: data definition has
> no type or storage class
>
> I found a email about this to which Stas replied :
>
> >Stas Bekman wrote:
> > I think this has to do with the ordering of including apache headers.
> This was
> > fixed in the cvs version of mod_perl 1.0. Can you please try to
> rebuild mod_perl
> > using the cvs version and then give another chance to Apache::Scoreboard?
>
> After recompiling Apache with the mod_perl CVS snap shot from 4 April,
> I'm getting the same error.
I've this outstanding patch that fixes this problem for me. But Geoff was
saying that the current mod_perl 1.0 cvs should have no problems. Geoff?
Index: src/modules/perl/mod_perl.h
===================================================================
RCS file: /home/cvs/modperl/src/modules/perl/mod_perl.h,v
retrieving revision 1.117
diff -u -r1.117 mod_perl.h
--- src/modules/perl/mod_perl.h 14 Mar 2003 04:55:59 -0000 1.117
+++ src/modules/perl/mod_perl.h 7 Apr 2003 00:06:23 -0000
@@ -72,11 +72,8 @@
#endif
#ifdef PERL_THREADS
-#define _INCLUDE_APACHE_FIRST
-#endif
-
-#ifdef _INCLUDE_APACHE_FIRST
#include "apache_inc.h"
+#define _INCLUDE_APACHE_FIRST
#endif
#include "EXTERN.h"
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com